fbcon: change fbcon_*registered_fb variables to static
Subsystems (3)
PATCH 1/1 fbcon: change fbcon_*registered_fb variables to static
Sparse reports these issues
fbcon.c:106:16: warning: symbol 'fbcon_registered_fb' was not declared. Should it be static? fbcon.c:107:5: warning: symbol 'fbcon_num_registered_fb' was not declared. Should it be static?
These variables are only used in fbcon.c. Single file use variables should be static, so change their storage-class specifiers to static.
--- drivers/video/fbdev/core/fbcon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/video/fbdev/core/fbcon.c +2 -2
@@ -103,8 +103,8 @@ enum {static struct fbcon_display fb_display[MAX_NR_CONSOLES ]; -struct fb_info *fbcon_registered_fb[FB_MAX ]; -int fbcon_num_registered_fb; +static struct fb_info *fbcon_registered_fb[FB_MAX ]; +static int fbcon_num_registered_fb;#define fbcon_for_each_registered_fb (i) \ for (i = 0; WARN_CONSOLE_UNLOCKED(), i < FB_MAX; i++) \
Signature · 1 line
2.27.0
Quoted 8 lines · Tom Rix
Sparse reports these issues
fbcon.c:106:16: warning: symbol 'fbcon_registered_fb' was not declared. Should it be static? fbcon.c:107:5: warning: symbol 'fbcon_num_registered_fb' was not declared. Should it be static?These variables are only used in
fbcon.c. Single file use variables should be static, so change their storage-class specifiers to static.Signed-off-by Tom Rix <[email protected]>
Quoted 21 lines
--- drivers/video/fbdev/core/fbcon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/video/fbdev/core/fbcon.c +2
-2@@ -103,8 +103,8 @@ enum {static struct fbcon_display fb_display[MAX_NR_CONSOLES ]; -struct fb_info *fbcon_registered_fb[FB_MAX ]; -int fbcon_num_registered_fb; +static struct fb_info *fbcon_registered_fb[FB_MAX ]; +static int fbcon_num_registered_fb;#define fbcon_for_each_registered_fb (i) \ for (i = 0; WARN_CONSOLE_UNLOCKED(), i < FB_MAX; i++) \Signature · 1 line
2.27.0