Skip to contentSkip to conversation

dt-bindings: net: qcom,ipa: fix example for upcomming smp2p conversion

PATCH In review David Heidelberg 3 participants 8 messages Apr 24, 2022 – Apr 25, 2022

Subsystems (7)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/3 dt-bindings: net: qcom,ipa: fix example for upcomming smp2p conversion

Example of mpss was missing required properties.

---
 Documentation/devicetree/bindings/net/qcom,ipa.yaml | 5 +++++
 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/net/qcom,ipa.yaml +5 -0
index 58ecc62adfaa..852658b4d05c 100644
@@ -182,6 +182,11 @@ examples:
 
         smp2p-mpss {
                 compatible = "qcom,smp2p";
+                mboxes = <&apss_shared 14>;
+                qcom,smem = <435>, <428>;
+                qcom,local-pid = <0>;
+                qcom,remote-pid = <1>;
+
                 ipa_smp2p_out: ipa-ap-to-modem {
                         qcom,entry-name = "ipa";
                         #qcom,smem-state-cells = <1>;
Signature · 1 line
2.35.1
#1 lore raw

PATCH v2 2/3 dt-bindings: mailbox: qcom-ipcc: add missing properties into example

These missing required properties are needed for
smp2p binding reference checks.

Misc: adjusted examples properties formatting from dtsi.

---
 .../devicetree/bindings/mailbox/qcom-ipcc.yaml        | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml +8 -3
index 866efb278813..d573d555f4c6 100644
@@ -75,9 +75,14 @@ examples:
 
         smp2p-modem {
                 compatible = "qcom,smp2p";
-                interrupts-extended = <&ipcc_mproc IPCC_CLIENT_MPSS
-                                IPCC_MPROC_SIGNAL_SMP2P IRQ_TYPE_EDGE_RISING>;
-                mboxes = <&ipcc_mproc IPCC_CLIENT_MPSS IPCC_MPROC_SIGNAL_SMP2P>;
+                qcom,smem = <443>, <429>;
+                interrupts-extended = <&ipcc IPCC_CLIENT_LPASS
+                                             IPCC_MPROC_SIGNAL_SMP2P
+                                             IRQ_TYPE_EDGE_RISING>;
+                mboxes = <&ipcc IPCC_CLIENT_LPASS
+                                IPCC_MPROC_SIGNAL_SMP2P>;
 
+                qcom,local-pid = <0>;
+                qcom,remote-pid = <2>;
                 /* Other SMP2P fields */
         };
Signature · 1 line
2.35.1
Reviewed-by on v2 2/3
#2 lore raw

Re: [PATCH v2 2/3] dt-bindings: mailbox: qcom-ipcc: add missing properties into example

Quoted 4 lines · David Heidelberg

These missing required properties are needed for
smp2p binding reference checks.

Misc: adjusted examples properties formatting from dtsi.

I don't get the "misc:" comment. What is it about?

Best regards,
Krzysztof

#3 lore raw

Re: [PATCH v2 2/3] dt-bindings: mailbox: qcom-ipcc: add missing properties into example

Quoted 6 lines · Krzysztof Kozlowski
Quoted 4 lines · David Heidelberg

These missing required properties are needed for
smp2p binding reference checks.

Misc: adjusted examples properties formatting from dtsi.

I don't get the "misc:" comment. What is it about?

I used same formatting as in dtsi where the node is used (cosmetic change).

Quoted 2 lines

Thanks

Quoted 3 lines

Best regards,
Krzysztof

Signature · 5 lines
David Heidelberg
Consultant Software Engineer

Signal: +420 608 26 33 76
Matrix: @okias:matrix.org
maintainer
#4 lore raw

Re: [PATCH v2 2/3] dt-bindings: mailbox: qcom-ipcc: add missing properties into example

In reply to David Heidelberg
Quoted 10 lines · David Heidelberg

These missing required properties are needed for
smp2p binding reference checks.

Misc: adjusted examples properties formatting from dtsi.

---
 .../devicetree/bindings/mailbox/qcom-ipcc.yaml        | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings.

Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future.

Full log is available here: https://patchwork.ozlabs.org/patch/

mailbox@ed18000: compatible:0: 'qcom,sm8450-ipcc' is not one of ['qcom,sm6350-ipcc', 'qcom,sm8250-ipcc', 'qcom,sm8350-ipcc', 'qcom,sc7280-ipcc']

	arch/arm64/boot/dts/qcom/sm8450-hdk.dtb
	arch/arm64/boot/dts/qcom/sm8450-qrd.dtb
#5 lore raw

PATCH v2 3/3 dt-bindings: soc: qcom: convert QCOM SMP2P binding to yaml

In reply to David Heidelberg

Convert Qualcomm SoC SMP2P binding to the yaml format.

---
v2:
- dropped constraints on sub-node names, converted patternProperties to additionalProperties
- adjusted name from "Point 2 Point" to "Point to Point"

---
 .../bindings/soc/qcom/qcom,smp2p.txt          | 110 --------------
 .../bindings/soc/qcom/qcom,smp2p.yaml         | 136 ++++++++++++++++++
 2 files changed, 136 insertions(+), 110 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,smp2p.txt
 create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,smp2p.yaml
Documentation/devicetree/bindings/soc/qcom/qcom,smp2p.txt deleted +0 -110
deleted file mode 100644
index 49e1d72d3648..000000000000
@@ -1,110 +0,0 @@
-Qualcomm Shared Memory Point 2 Point binding
-
-The Shared Memory Point to Point (SMP2P) protocol facilitates communication of
-a single 32-bit value between two processors.  Each value has a single writer
-(the local side) and a single reader (the remote side).  Values are uniquely
-identified in the system by the directed edge (local processor ID to remote
-processor ID) and a string identifier.
-
-- compatible:
-	Usage: required
-	Value type: <string>
-	Definition: must be one of:
-		    "qcom,smp2p"
-
-- interrupts:
-	Usage: required
-	Value type: <prop-encoded-array>
-	Definition: one entry specifying the smp2p notification interrupt
-
-- mboxes:
-	Usage: required
-	Value type: <prop-encoded-array>
-	Definition: reference to the associated doorbell in APCS, as described
-		    in mailbox/mailbox.txt
-
-- qcom,ipc:
-	Usage: required, unless mboxes is specified
-	Value type: <prop-encoded-array>
-	Definition: three entries specifying the outgoing ipc bit used for
-		    signaling the remote end of the smp2p edge:
-		    - phandle to a syscon node representing the apcs registers
-		    - u32 representing offset to the register within the syscon
-		    - u32 representing the ipc bit within the register
-
-- qcom,smem:
-	Usage: required
-	Value type: <u32 array>
-	Definition: two identifiers of the inbound and outbound smem items used
-		    for this edge
-
-- qcom,local-pid:
-	Usage: required
-	Value type: <u32>
-	Definition: specifies the identifier of the local endpoint of this edge
-
-- qcom,remote-pid:
-	Usage: required
-	Value type: <u32>
-	Definition: specifies the identifier of the remote endpoint of this edge
-
-= SUBNODES
-Each SMP2P pair contain a set of inbound and outbound entries, these are
-described in subnodes of the smp2p device node. The node names are not
-important.
-
-- qcom,entry-name:
-	Usage: required
-	Value type: <string>
-	Definition: specifies the name of this entry, for inbound entries this
-		    will be used to match against the remotely allocated entry
-		    and for outbound entries this name is used for allocating
-		    entries
-
-- interrupt-controller:
-	Usage: required for incoming entries
-	Value type: <empty>
-	Definition: marks the entry as inbound; the node should be specified
-		    as a two cell interrupt-controller as defined in
-		    "../interrupt-controller/interrupts.txt"
-		    If not specified this node will denote the outgoing entry
-
-- #interrupt-cells:
-	Usage: required for incoming entries
-	Value type: <u32>
-	Definition: must be 2 - denoting the bit in the entry and IRQ flags
-
-- #qcom,smem-state-cells:
-	Usage: required for outgoing entries
-	Value type: <u32>
-	Definition: must be 1 - denoting the bit in the entry
-
-= EXAMPLE
-The following example shows the SMP2P setup with the wireless processor,
-defined from the 8974 apps processor's point-of-view. It encompasses one
-inbound and one outbound entry:
-
-wcnss-smp2p {
-	compatible = "qcom,smp2p";
-	qcom,smem = <431>, <451>;
-
-	interrupts = <0 143 1>;
-
-	qcom,ipc = <&apcs 8 18>;
-
-	qcom,local-pid = <0>;
-	qcom,remote-pid = <4>;
-
-	wcnss_smp2p_out: master-kernel {
-		qcom,entry-name = "master-kernel";
-
-		#qcom,smem-state-cells = <1>;
-	};
-
-	wcnss_smp2p_in: slave-kernel {
-		qcom,entry-name = "slave-kernel";
-
-		interrupt-controller;
-		#interrupt-cells = <2>;
-	};
-};
Documentation/devicetree/bindings/soc/qcom/qcom,smp2p.yaml new file +136 -0

136 lines not on this page · raw message

Signature · 1 line
2.35.1
#6 lore raw

Re: [PATCH v2 3/3] dt-bindings: soc: qcom: convert QCOM SMP2P binding to yaml

Quoted 11 lines · David Heidelberg

Convert Qualcomm SoC SMP2P binding to the yaml format.

---
v2:
- dropped constraints on sub-node names, converted patternProperties to additionalProperties
- adjusted name from "Point 2 Point" to "Point to Point"

---
 .../bindings/soc/qcom/qcom,smp2p.txt          | 110 --------------
 .../bindings/soc/qcom/qcom,smp2p.yaml         | 136 ++++++++++++++++++

This was already done. Sorry that I did not notice your earlier work, I am usually checking for prior work but this was missed.

Best regards,
Krzysztof