clk: mux: remove redundant initialization of variable width
Subsystems (2)
PATCH 1/1 clk: mux: remove redundant initialization of variable width
Variable width is being ininitialized with a value that is never read. The ininitializtion is redundant and can be removed. Move the variable to the scope it is required.
Cleans up cppcheck warning:
Variable 'width' is assigned a value that is never used.
Signed-off-by Colin Ian King <[email protected]>
--- drivers/clk/clk-mux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/clk/clk-mux.c +2 -2
@@ -157,11 +157,11 @@ struct clk_hw *__clk_hw_register_mux(struct device *dev, struct device_node *np,struct clk_mux *mux;struct clk_hw *hw;struct clk_init_data init = {}; -u8 width =0 ;int ret = -EINVAL ;if (clk_mux_flags &CLK_MUX_HIWORD_MASK ) { - width =fls (mask) -ffs (mask) +1 ; +u8 width =fls (mask) -ffs (mask) +1 ; +if (width + shift >16 ) {pr_err ("mux value exceeds LOWORD field\n" );return ERR_PTR (-EINVAL );
Signature · 1 line
2.35.1
Quoting Colin Ian King (2022-04-24 11:22:27)
Quoted 9 lines
Variable width is being ininitialized with a value that is never read. The ininitializtion is redundant and can be removed. Move the variable to the scope it is required.
Cleans up cppcheck warning:
Variable 'width' is assigned a value that is never used.Signed-off-by Colin Ian King <[email protected]>---
Applied to clk-next