Skip to contentSkip to conversation

add support for Sierra Wireless EM7590 0xc081 composition.

PATCH In review Ethan Yang 3 participants 5 messages Apr 25, 2022 – Apr 26, 2022

Subsystems (5)
lore
Share & tools
lore

Ethan Yang

author
#0 lore raw

PATCH 1/1 add support for Sierra Wireless EM7590 0xc081 composition.

add support for Sierra Wireless EM7590 0xc081 composition.

---
 drivers/net/usb/qmi_wwan.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/usb/qmi_wwan.c +1 -0
index 3353e761016d..fa220a13edb6 100644
@@ -1351,6 +1351,7 @@ static const struct usb_device_id products[] = {
 	{QMI_QUIRK_SET_DTR(0x1199, 0x907b, 8)},	/* Sierra Wireless EM74xx */
 	{QMI_QUIRK_SET_DTR(0x1199, 0x907b, 10)},/* Sierra Wireless EM74xx */
 	{QMI_QUIRK_SET_DTR(0x1199, 0x9091, 8)},	/* Sierra Wireless EM7565 */
+	{QMI_QUIRK_SET_DTR(0x1199, 0xc081, 8)},	/* Sierra Wireless EM7590 */
 	{QMI_FIXED_INTF(0x1bbb, 0x011e, 4)},	/* Telekom Speedstick LTE II (Alcatel One Touch L100V LTE) */
 	{QMI_FIXED_INTF(0x1bbb, 0x0203, 2)},	/* Alcatel L800MA */
 	{QMI_FIXED_INTF(0x2357, 0x0201, 4)},	/* TP-LINK HSUPA Modem MA180 */
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 12 lines · Ethan Yang

add support for Sierra Wireless EM7590 0xc081 composition.

---
 drivers/net/usb/qmi_wwan.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/usb/qmi_wwan.c +0 -0
index 3353e761016d..fa220a13edb6 100644

drivers/net/usb/qmi_wwan.c static const struct usb_device_id products[] = { · line 1357

Quoted 7 lines
drivers/net/usb/qmi_wwan.c +1 -0
@@ -1351,6 +1351,7 @@ static const struct usb_device_id products[] = {
 	{QMI_QUIRK_SET_DTR(0x1199, 0x907b, 8)},	/* Sierra Wireless EM74xx */
 	{QMI_QUIRK_SET_DTR(0x1199, 0x907b, 10)},/* Sierra Wireless EM74xx */
 	{QMI_QUIRK_SET_DTR(0x1199, 0x9091, 8)},	/* Sierra Wireless EM7565 */
+	{QMI_QUIRK_SET_DTR(0x1199, 0xc081, 8)},	/* Sierra Wireless EM7590 */
 	{QMI_FIXED_INTF(0x1bbb, 0x011e, 4)},	/* Telekom Speedstick LTE II (Alcatel One Touch L100V LTE) */
 	{QMI_FIXED_INTF(0x1bbb, 0x0203, 2)},	/* Alcatel L800MA */
 	{QMI_FIXED_INTF(0x2357, 0x0201, 4)},	/* TP-LINK HSUPA Modem MA180 */

Hello!

The diff looks fine to me, but there are some minor issues with the commit message. This is how it ended up looking in for me with "git log":

---
commit 5e3f386fdb23c8e5ba7c24ff5efd6beb73db3e85 (HEAD -> bugfix-master)

Author: Ethan Yang <[email protected]>
Date:   Mon Apr 25 11:14:11 2022 +0800
    add support for Sierra Wireless EM7590 0xc081 composition.
    
    add support for Sierra Wireless EM7590 0xc081 composition.
    
    Signed-off-by: Ethan Yang <[email protected]>

---

The issues I see there are:

1) subject should have a prefix - e.g. "net: usb: qmi_wwan:"

2) don't repeat the subject in the body - that's redundant and ends up looking like a duplicate line in the commit message. Write something addding more information instead. Anything you find relevant

3) I guess you send from a gmail address for a reason. But you most likely want the Author field to match your Signed-off-by? You can fix this by including something like this as the *first* line of the message body:

From: Ethan Yang <[email protected]>

FYI: checkpatch warns about the last issue:

bjorn@miraculix:/usr/local/src/git/linux$ scripts/checkpatch.pl /tmp/xx
WARNING: From:/Signed-off-by: email address mismatch: 'From: Ethan Yang <[email protected]>' != 'Signed-off-by: Ethan Yang <[email protected]>'

total: 0 errors, 1 warnings, 0 checks, 7 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

/tmp/xx has style problems, please review.

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

Bjørn

#2 lore raw

PATCH v2 1/1 net: usb: qmi_wwan: add support for Sierra Wireless EM7590

From: Ethan Yang <[email protected]>

add support for Sierra Wireless EM7590 0xc081 composition.

---
 drivers/net/usb/qmi_wwan.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/usb/qmi_wwan.c +1 -0
index 3353e761016d..fa220a13edb6 100644
@@ -1351,6 +1351,7 @@ static const struct usb_device_id products[] = {
 	{QMI_QUIRK_SET_DTR(0x1199, 0x907b, 8)},	/* Sierra Wireless EM74xx */
 	{QMI_QUIRK_SET_DTR(0x1199, 0x907b, 10)},/* Sierra Wireless EM74xx */
 	{QMI_QUIRK_SET_DTR(0x1199, 0x9091, 8)},	/* Sierra Wireless EM7565 */
+	{QMI_QUIRK_SET_DTR(0x1199, 0xc081, 8)},	/* Sierra Wireless EM7590 */
 	{QMI_FIXED_INTF(0x1bbb, 0x011e, 4)},	/* Telekom Speedstick LTE II (Alcatel One Touch L100V LTE) */
 	{QMI_FIXED_INTF(0x1bbb, 0x0203, 2)},	/* Alcatel L800MA */
 	{QMI_FIXED_INTF(0x2357, 0x0201, 4)},	/* TP-LINK HSUPA Modem MA180 */
Signature · 1 line
2.17.1
#4 lore raw

Re: [PATCH v2] net: usb: qmi_wwan: add support for Sierra Wireless EM7590

In reply to [email protected]
This patch was applied to netdev/net-next.git (master) by Paolo Abeni <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (master) by Paolo Abeni <[email protected]>:

Quoted 8 lines · On Mon, 25 Apr 2022 13:40:28 +0800 you wrote:

From: Ethan Yang <[email protected]>

add support for Sierra Wireless EM7590 0xc081 composition.

---
 drivers/net/usb/qmi_wwan.c | 1 +
 1 file changed, 1 insertion(+)

Here is the summary with links:
- [v2] net: usb: qmi_wwan: add support for Sierra Wireless EM7590

    https://git.kernel.org/netdev/net-next/c/561215482cc6

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html