ASoC: Add macros for signed TLV controls with callbacks
v2 cover ASoC: Add macros for signed TLV controls with callbacks
This adds SOC_DOUBLE_R_S_EXT_TLV and SOC_SINGLE_S_EXT_TLV macros for signed TLV controls that need custom get/put callbacks. These will be needed by future Cirrus codec drivers, but are not particularly exotic so could be useful for others.
Only change from V1 is sign-off on patch #1.
Richard Fitzgerald (1):
ASoC: soc.h: Add SOC_SINGLE_S_EXT_TLV macro
Simon Trimmer (1):
ASoC: soc.h: Introduce SOC_DOUBLE_R_S_EXT_TLV() macro
include/sound/soc.h | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)
Signature · 1 line
2.30.2
PATCH v2 1/2 ASoC: soc.h: Introduce SOC_DOUBLE_R_S_EXT_TLV() macro
From: Simon Trimmer <[email protected]>
A straightforward extension of the SOC_DOUBLE_R_S_TLV() macro that allows the get and put functions to be customised.
--- include/sound/soc.h | 11 +++++++++++ 1 file changed, 11 insertions(+)
include/sound/soc.h +11 -0
@@ -282,6 +282,17 @@ .get = xhandler_get, .put = xhandler_put, \ .private_value = SOC_DOUBLE_R_VALUE(reg_left, reg_right, xshift, \ xmax, xinvert) } +#define SOC_DOUBLE_R_S_EXT_TLV (xname, reg_left, reg_right, xshift, xmin, xmax, \ + xsign_bit, xinvert, xhandler_get, xhandler_put, \ + tlv_array) \ +{ .iface = SNDRV_CTL_ELEM_IFACE_MIXER, .name = (xname), \ + .access = SNDRV_CTL_ELEM_ACCESS_TLV_READ | \ + SNDRV_CTL_ELEM_ACCESS_READWRITE, \ + .tlv.p = (tlv_array), \ + .info = snd_soc_info_volsw, \ + .get = xhandler_get, .put = xhandler_put, \ + .private_value = SOC_DOUBLE_R_S_VALUE(reg_left, reg_right, xshift, \ + xmin, xmax, xsign_bit, xinvert) }#define SOC_SINGLE_BOOL_EXT (xname, xdata, xhandler_get, xhandler_put) \ { .iface = SNDRV_CTL_ELEM_IFACE_MIXER, .name = xname, \ .info = snd_soc_info_bool_ext, \
Signature · 1 line
2.30.2
PATCH v2 2/2 ASoC: soc.h: Add SOC_SINGLE_S_EXT_TLV macro
In reply to Richard FitzgeraldAdd a SOC_SINGLE_S_EXT_TLV macro as a convenience wrapper around SOC_DOUBLE_R_S_EXT_TLV for mono volume controls.
--- include/sound/soc.h | 6 ++++++ 1 file changed, 6 insertions(+)
include/sound/soc.h +6 -0
@@ -293,6 +293,12 @@ .get = xhandler_get, .put = xhandler_put, \ .private_value = SOC_DOUBLE_R_S_VALUE(reg_left, reg_right, xshift, \ xmin, xmax, xsign_bit, xinvert) } +#define SOC_SINGLE_S_EXT_TLV (xname, xreg, xshift, xmin, xmax, \ + xsign_bit, xinvert, xhandler_get, xhandler_put, \ + tlv_array) \ + SOC_DOUBLE_R_S_EXT_TLV(xname, xreg, xreg, xshift, xmin, xmax, \ + xsign_bit, xinvert, xhandler_get, xhandler_put, \ + tlv_array)#define SOC_SINGLE_BOOL_EXT (xname, xdata, xhandler_get, xhandler_put) \ { .iface = SNDRV_CTL_ELEM_IFACE_MIXER, .name = xname, \ .info = snd_soc_info_bool_ext, \
Signature · 1 line
2.30.2
Mark Brown
maintainerQuoted 8 lines · Richard Fitzgerald
This adds
SOC_DOUBLE_R_S_EXT_TLVandSOC_SINGLE_S_EXT_TLVmacros for signed TLV controls that need custom get/put callbacks. These will be needed by future Cirrus codec drivers, but are not particularly exotic so could be useful for others.Only change from V1 is sign-off on patch #1.
[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/2] ASoC: soc.h: Introduce SOC_DOUBLE_R_S_EXT_TLV() macro
commit: cf51406ccb083941102fc101718d4c0a25b17917
[2/2] ASoC: soc.h: Add SOC_SINGLE_S_EXT_TLV macro
commit: 5349c0c93d15dff27d99fec12fc82040fab340bdAll being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark