Skip to contentSkip to conversation

kernel/crash_core.c : Remove redundant checks for ck_cmdline is NULL

PATCH In review lizhe 2 participants 3 messages Apr 25, 2022 – May 3, 2022 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore

lizhe

author
#0 lore raw

PATCH 1/1 kernel/crash_core.c : Remove redundant checks for ck_cmdline is NULL

When ck_cmdline is NULL, the only caller of get_last_crashkernel() has already done non-NULL check(see __parse_crashkernel()), so it doesn't make any sense to make a check here

---
 kernel/crash_core.c | 3 ---
 1 file changed, 3 deletions(-)
kernel/crash_core.c +0 -3
index 256cf6db573c..c232f01a2c54 100644
@@ -222,9 +222,6 @@ static __init char *get_last_crashkernel(char *cmdline,
 		p = strstr(p+1, name);
 	}
 
-	if (!ck_cmdline)
-		return NULL;
-
 	return ck_cmdline;
 }
 
Signature · 1 line
2.25.1
#1 lore raw

Hi lizhe,

Quoted 3 lines · On Mon, 25 Apr 2022 08:38:57 -0700 lizhe <[email protected]> wrote:

When ck_cmdline is NULL, the only caller of get_last_crashkernel() has already done non-NULL check(see __parse_crashkernel()), so it doesn't make any sense to make a check here

sorry, but I still don't like the description. What I don't understand in particular is why you are mentioning the caller (__parse_crashkernel) here. ck_cmdline is a local variable to get_last_crashkernel. So the caller cannot perform any check on the variable but only the return value of the function. So the patch description should describe why we can remove the additional return NULL without changing the behavior of the function.

Thanks
Philipp

Quoted 19 lines
---
 kernel/crash_core.c | 3 ---
 1 file changed, 3 deletions(-)
kernel/crash_core.c +0 -3
index 256cf6db573c..c232f01a2c54 100644
@@ -222,9 +222,6 @@ static __init char *get_last_crashkernel(char *cmdline,
 		p = strstr(p+1, name);
 	}
 
-	if (!ck_cmdline)
-		return NULL;
-
 	return ck_cmdline;
 }
 

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw

Hi lizhe,

Quoted 11 lines · On Mon, 2 May 2022 18:11:20 +0800 (CST) lizhe <[email protected]> wrote:

HI Philipp Rudo.

When ck_cmdline is NULL. The last three lines of this function are equivalent to :
if ( ! NULL)
return NULL;
return NULL;
This is obviously a redundant check.

I will use the above description to describe the patch,

the explanation looks good to me.

Thanks!
Philipp

Quoted 61 lines

thanks. lizhe

Quoted 39 lines · Philipp Rudo

Hi lizhe,

Quoted 3 lines · On Mon, 25 Apr 2022 08:38:57 -0700 lizhe <[email protected]> wrote:

When ck_cmdline is NULL, the only caller of get_last_crashkernel() has already done non-NULL check(see __parse_crashkernel()), so it doesn't make any sense to make a check here

sorry, but I still don't like the description. What I don't understand in particular is why you are mentioning the caller (__parse_crashkernel) here. ck_cmdline is a local variable to get_last_crashkernel. So the caller cannot perform any check on the variable but only the return value of the function. So the patch description should describe why we can remove the additional return NULL without changing the behavior of the function.

Thanks
Philipp

Quoted 19 lines
---
 kernel/crash_core.c | 3 ---
 1 file changed, 3 deletions(-)
kernel/crash_core.c +0 -3
index 256cf6db573c..c232f01a2c54 100644
@@ -222,9 +222,6 @@ static __init char *get_last_crashkernel(char *cmdline,
 		p = strstr(p+1, name);
 	}
 
-	if (!ck_cmdline)
-		return NULL;
-
 	return ck_cmdline;
 }