dt-bindings: clock: qcom,gcc-apq8064: Fix typo in compatible string
Rob Herring
maintainerPATCH 1/1 dt-bindings: clock: qcom,gcc-apq8064: Fix typo in compatible string
The compatible string should be 'qcom,gcc-apq8064', not 'qcom,gcc-apq8084'. Found by enabling undocumented compatible checks.
--- Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml +1 -1
@@ -25,7 +25,7 @@ description: | properties: compatible: - const: qcom,gcc-apq8084 + const: qcom,gcc-apq8064 nvmem-cells: minItems: 1
Signature · 1 line
2.34.1
Quoted 5 lines · Rob Herring
The compatible string should be 'qcom,gcc-apq8064', not 'qcom,gcc-apq8084'. Found by enabling undocumented compatible checks.
Cc Ansuel Smith <[email protected]>Signed-off-by Rob Herring <[email protected]>
Thanks Rob!
Documentation")
Best regards,
Krzysztof
Stephen Boyd
maintainerQuoting Rob Herring (2022-04-25 06:35:27)
Quoted 14 lines
The compatible string should be 'qcom,gcc-apq8064', not 'qcom,gcc-apq8084'. Found by enabling undocumented compatible checks.
Cc Ansuel Smith <[email protected]>Signed-off-by Rob Herring <[email protected]>--- Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml +0
-0
Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml description: | · line 28
Quoted 5 lines
Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml +1
-1@@ -25,7 +25,7 @@ description: | properties: compatible: - const: qcom,gcc-apq8084 + const: qcom,gcc-apq8064
This file has dt-bindings/clock/qcom,gcc-apq8084.h referenced. Should that be removed? It looks like commit a469bf89a009 ("dt-bindings: clock:
simplify qcom,gcc-apq8064 Documentation") took the more than just the compatible for apq8084 from qcom,gcc-other.yaml and put it in here while removing gcc-apq8064. Probably the apq8084 part needs to be a copy of the apq8064 file with the single compatible changed.
Rob Herring
maintainerQuoted 16 lines · Stephen Boyd
Quoting Rob Herring (2022-04-25 06:35:27)
Quoted 15 lines
The compatible string should be 'qcom,gcc-apq8064', not 'qcom,gcc-apq8084'. Found by enabling undocumented compatible checks.
Cc Ansuel Smith <[email protected]>Signed-off-by Rob Herring <[email protected]>--- Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml +0
-0@@ -25,7 +25,7 @@ description: |
Quoted 11 lines
Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml description: | · line 28
Quoted 4 lines
Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml +1
-1properties: compatible: - const: qcom,gcc-apq8084 + const: qcom,gcc-apq8064This file has
dt-bindings/clock/qcom,gcc-apq8084.hreferenced. Should that be removed? It looks like commita469bf89a009("dt-bindings: clock:
simplify qcom,gcc-apq8064 Documentation") took the more than just the compatible for apq8084 from qcom,gcc-other.yaml and put it in here while removing gcc-apq8064. Probably the apq8084 part needs to be a copy of the apq8064 file with the single compatible changed.
IDK, can someone (Ansuel?) fix this properly?
Rob
Quoted 6 lines · Rob Herring
Quoted 6 lines
Quoted 5 lines
properties:
compatible:Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml +1
-1- const: qcom,gcc-apq8084 + const: qcom,gcc-apq8064
Quoted 8 lines
Quoted 6 lines
This file has
dt-bindings/clock/qcom,gcc-apq8084.hreferenced. Should that be removed? It looks like commita469bf89a009("dt-bindings: clock:
simplify qcom,gcc-apq8064 Documentation") took the more than just the compatible for apq8084 from qcom,gcc-other.yaml and put it in here while removing gcc-apq8064. Probably the apq8084 part needs to be a copy of the apq8064 file with the single compatible changed.IDK, can someone (Ansuel?) fix this properly?
I'll look at this and fix it.
Best regards,
Krzysztof
Quoted 16 lines · Stephen Boyd
Quoting Rob Herring (2022-04-25 06:35:27)
Quoted 15 lines
The compatible string should be 'qcom,gcc-apq8064', not 'qcom,gcc-apq8084'. Found by enabling undocumented compatible checks.
Cc Ansuel Smith <[email protected]>Signed-off-by Rob Herring <[email protected]>--- Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml +0
-0@@ -25,7 +25,7 @@ description: |
Quoted 11 lines
Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml description: | · line 28
Quoted 4 lines
Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml +1
-1properties: compatible: - const: qcom,gcc-apq8084 + const: qcom,gcc-apq8064This file has
dt-bindings/clock/qcom,gcc-apq8084.hreferenced. Should that be removed? It looks like commita469bf89a009("dt-bindings: clock:
simplify qcom,gcc-apq8064 Documentation") took the more than just the compatible for apq8084 from qcom,gcc-other.yaml and put it in here while removing gcc-apq8064. Probably the apq8084 part needs to be a copy of the apq8064 file with the single compatible changed.
Good point, Rob's commit removes entirely qcom,gcc-apq8084 compatible, which is and was used.
Probably the intention of that commit was to merge apq8064 and apq8084. The first uses dt-bindings/clock/qcom,gcc-msm8960.h header for IDs. The second has its own headers, added in mentioned commit.
I am not sure it is worth splitting this into two files. Adding here enum for 8064 and 8084 should work fine.
Best regards,
Krzysztof