Skip to contentSkip to conversation

dt-bindings: List supplies needed for sc7280 eDP

PATCH Applied Douglas Anderson 5 participants 14 messages Apr 25, 2022 – Jun 17, 2022

Subsystems (6)
lore
Share & tools
lore
#0 lore raw

cover dt-bindings: List supplies needed for sc7280 eDP

While looking through dts changes for sc7280 eDP I found that none of the regulators that were being defined were listed in the bindings. That being said, the current Linux drivers _were_ looking for regulators. This series tries to document the reality to the best of my ability.

If someone from Qualcomm has better documentation than I do and wants to correct anything here then I'd be more than happy. For the PHY patch especially I don't have a great way to map what I see in datasheets / schematics to figure out which is the supply for the "phy" and the "pll".

Assuming these look OK, I'd expect the PHY patch to land through the PHY tree and the display patch to land through msm-next. I can split the series up if need be--the two patches are just in one series because they have a similar topic--there are no actual dependencies here.

Douglas Anderson (2):
dt-bindings: msm/dp: List supplies in the bindings
dt-bindings: phy: List supplies for qcom,edp-phy

 .../devicetree/bindings/display/msm/dp-controller.yaml      | 6 ++++++
 Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml     | 6 ++++++
 2 files changed, 12 insertions(+)
Signature · 1 line
2.36.0.rc2.479.g8af0fa9b8e-goog
#1 lore raw

PATCH 1/2 dt-bindings: msm/dp: List supplies in the bindings

We're supposed to list the supplies in the dt bindings but there are none in the DP controller bindings. Looking at the Linux driver and existing device trees, we can see that two supplies are expected:
- vdda-0p9-supply
- vdda-1p2-supply

Let's list them both in the bindings. Note that the datasheet for sc7280 doesn't describe these supplies very verbosely. For the 0p9 supply, for instance, it says "Power for eDP 0.9 V circuits". This this is obvious from the property name, we don't bother cluttering the bindings with a description.

---

 .../devicetree/bindings/display/msm/dp-controller.yaml      | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/display/msm/dp-controller.yaml +6 -0
index cd05cfd76536..dba31108db51 100644
@@ -76,6 +76,9 @@ properties:
   "#sound-dai-cells":
     const: 0
 
+  vdda-0p9-supply: true
+  vdda-1p2-supply: true
+
   ports:
     $ref: /schemas/graph.yaml#/properties/ports
     properties:
@@ -137,6 +140,9 @@ examples:
 
         power-domains = <&rpmhpd SC7180_CX>;
 
+        vdda-0p9-supply = <&vdda_usb_ss_dp_core>;
+        vdda-1p2-supply = <&vdda_usb_ss_dp_1p2>;
+
         ports {
             #address-cells = <1>;
             #size-cells = <0>;
Signature · 1 line
2.36.0.rc2.479.g8af0fa9b8e-goog
#2 lore raw

Re: [PATCH 1/2] dt-bindings: msm/dp: List supplies in the bindings

Quoting Douglas Anderson (2022-04-25 14:06:42)

Quoted 33 lines

We're supposed to list the supplies in the dt bindings but there are none in the DP controller bindings. Looking at the Linux driver and existing device trees, we can see that two supplies are expected:
- vdda-0p9-supply
- vdda-1p2-supply

Let's list them both in the bindings. Note that the datasheet for sc7280 doesn't describe these supplies very verbosely. For the 0p9 supply, for instance, it says "Power for eDP 0.9 V circuits". This this is obvious from the property name, we don't bother cluttering the bindings with a description.

---

 .../devicetree/bindings/display/msm/dp-controller.yaml      | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/display/msm/dp-controller.yaml +3 -0
index cd05cfd76536..dba31108db51 100644
@@ -76,6 +76,9 @@ properties:
   "#sound-dai-cells":
     const: 0
 
+  vdda-0p9-supply: true
+  vdda-1p2-supply: true
+
   ports:
     $ref: /schemas/graph.yaml#/properties/ports
     properties:

Documentation/devicetree/bindings/display/msm/dp-controller.yaml examples: · line 143

Quoted 4 lines
Documentation/devicetree/bindings/display/msm/dp-controller.yaml +1 -0
@@ -137,6 +140,9 @@ examples:
 
         power-domains = <&rpmhpd SC7180_CX>;
 
+        vdda-0p9-supply = <&vdda_usb_ss_dp_core>;

Having 'a' in 'vdda' typically means 'analog' for 'analog' circuits, so I'd expect this to only matter for the phy that contains the analog circuitry. It would be great to remove the regulator code from drivers/gpu/drm/msm/dp/dp_power.c and move the regulator_set_load() call to the phy driver if possible. Hopefully qcom folks can help clarify here.

Quoted 1 line
Documentation/devicetree/bindings/display/msm/dp-controller.yaml +1 -0
+        vdda-1p2-supply = <&vdda_usb_ss_dp_1p2>;
#3 lore raw

Re: [PATCH 1/2] dt-bindings: msm/dp: List supplies in the bindings

Hi,

Quoted 38 lines · Stephen Boyd

Quoting Douglas Anderson (2022-04-25 14:06:42)

Quoted 36 lines

We're supposed to list the supplies in the dt bindings but there are none in the DP controller bindings. Looking at the Linux driver and existing device trees, we can see that two supplies are expected:
- vdda-0p9-supply
- vdda-1p2-supply

Let's list them both in the bindings. Note that the datasheet for sc7280 doesn't describe these supplies very verbosely. For the 0p9 supply, for instance, it says "Power for eDP 0.9 V circuits". This this is obvious from the property name, we don't bother cluttering the bindings with a description.

---

 .../devicetree/bindings/display/msm/dp-controller.yaml      | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/display/msm/dp-controller.yaml +3 -0
index cd05cfd76536..dba31108db51 100644
@@ -76,6 +76,9 @@ properties:
   "#sound-dai-cells":
     const: 0
 
+  vdda-0p9-supply: true
+  vdda-1p2-supply: true
+
   ports:
     $ref: /schemas/graph.yaml#/properties/ports
     properties:
@@ -137,6 +140,9 @@ examples:
 
         power-domains = <&rpmhpd SC7180_CX>;
 
Quoted 8 lines

Documentation/devicetree/bindings/display/msm/dp-controller.yaml examples: · line 143

Quoted 1 line
Documentation/devicetree/bindings/display/msm/dp-controller.yaml +1 -0
+        vdda-0p9-supply = <&vdda_usb_ss_dp_core>;

Having 'a' in 'vdda' typically means 'analog' for 'analog' circuits, so I'd expect this to only matter for the phy that contains the analog circuitry. It would be great to remove the regulator code from drivers/gpu/drm/msm/dp/dp_power.c and move the regulator_set_load() call to the phy driver if possible. Hopefully qcom folks can help clarify here.

Interesting. Oddly enough, the sc7280 datasheet doesn't list the "_A". It calls these "VDD_VREF_0P9" and "VDD_VREF_1P2". However, on the schematic in front of me someone labeled these pins on the sc7280 with the "A". ...and the driver looks for a supply with the "a". :-/

It would be good to get clarification from someone with better information.

-Doug

#4 lore raw

RE: [PATCH 1/2] dt-bindings: msm/dp: List supplies in the bindings

Hi Doug,

Quoted 51 lines
Quoted 42 lines

Quoting Douglas Anderson (2022-04-25 14:06:42)

Quoted 40 lines

We're supposed to list the supplies in the dt bindings but there are none in the DP controller bindings. Looking at the Linux driver and existing device trees, we can see that two supplies are expected:
- vdda-0p9-supply
- vdda-1p2-supply

Let's list them both in the bindings. Note that the datasheet for sc7280 doesn't describe these supplies very verbosely. For the 0p9 supply, for instance, it says "Power for eDP 0.9 V circuits". This this is obvious from the property name, we don't bother cluttering the bindings with a description.

---

 .../devicetree/bindings/display/msm/dp-controller.yaml      | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml index cd05cfd76536..dba31108db51 100644
---
a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.ya +++ ml

Documentation/devicetree/bindings/display/msm/dp-controller.yaml +3 -0
@@ -76,6 +76,9 @@ properties:
   "#sound-dai-cells":
     const: 0
 
+  vdda-0p9-supply: true
+  vdda-1p2-supply: true
+
   ports:
     $ref: /schemas/graph.yaml#/properties/ports
     properties:
@@ -137,6 +140,9 @@ examples:
 
         power-domains = <&rpmhpd SC7180_CX>;
 
Quoted 8 lines

Documentation/devicetree/bindings/display/msm/dp-controller.yaml examples: · line 143

Quoted 1 line
Documentation/devicetree/bindings/display/msm/dp-controller.yaml +1 -0
+        vdda-0p9-supply = <&vdda_usb_ss_dp_core>;

Having 'a' in 'vdda' typically means 'analog' for 'analog' circuits, so I'd expect this to only matter for the phy that contains the analog circuitry. It would be great to remove the regulator code from drivers/gpu/drm/msm/dp/dp_power.c and move the regulator_set_load() call to the phy driver if possible. Hopefully qcom folks can help clarify here.

Quoted 8 lines

Interesting. Oddly enough, the sc7280 datasheet doesn't list the "_A". It calls these "VDD_VREF_0P9" and "VDD_VREF_1P2". However, on the schematic in front of me someone labeled these pins on the sc7280 with the "A". ...and the driver looks for a supply with the "a". :-/

It would be good to get clarification from someone with better information.

-Doug

Our internal power grid documents list the regulators as VDD_A_*_1P2 and VDD_A_*_0P9 for all the platforms.

So, as a practice, we put the same name in the DT files. Hence,

Thank you,
Sankeerth

#5 lore raw

RE: [PATCH 1/2] dt-bindings: msm/dp: List supplies in the bindings

Quoting Sankeerth Billakanti (2022-05-05 11:02:36)

Quoted 15 lines
Quoted 15 lines
Quoted 9 lines

Quoting Douglas Anderson (2022-04-25 14:06:42)

Having 'a' in 'vdda' typically means 'analog' for 'analog' circuits, so I'd expect this to only matter for the phy that contains the analog circuitry. It would be great to remove the regulator code from drivers/gpu/drm/msm/dp/dp_power.c and move the regulator_set_load() call to the phy driver if possible. Hopefully qcom folks can help clarify here.

Interesting. Oddly enough, the sc7280 datasheet doesn't list the "_A". It calls these "VDD_VREF_0P9" and "VDD_VREF_1P2". However, on the schematic in front of me someone labeled these pins on the sc7280 with the "A". ...and the driver looks for a supply with the "a". :-/

Quoted 6 lines
Quoted 3 lines

It would be good to get clarification from someone with better information.

-Doug

Our internal power grid documents list the regulators as VDD_A_*_1P2 and VDD_A_*_0P9 for all the platforms.

Do your internal power grid documents indicate what these supplies are powering? The question is if these supplies power any of the logic inside the eDP controller or if they only supply power to the analog circuits in the eDP phy. If it's the eDP phy only then the regulator usage in the eDP driver should be removed. I would suspect this is the case because the controller is probably all digital logic and runs at the typical 1.8V that the rest of the SoC uses. Similarly, these are voltage references which sound like a PLL reference voltage.

Please clarify this further.

Quoted 5 lines

So, as a practice, we put the same name in the DT files. Hence,

#6 lore raw

RE: [PATCH 1/2] dt-bindings: msm/dp: List supplies in the bindings

Quoted 34 lines

Quoting Sankeerth Billakanti (2022-05-05 11:02:36)

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

Quoting Douglas Anderson (2022-04-25 14:06:42)

Having 'a' in 'vdda' typically means 'analog' for 'analog' circuits, so I'd expect this to only matter for the phy that contains the analog circuitry. It would be great to remove the regulator code from drivers/gpu/drm/msm/dp/dp_power.c and move

the

Quoted 9 lines
Quoted 9 lines
Quoted 2 lines

regulator_set_load() call to the phy driver if possible. Hopefully qcom folks can help clarify here.

Interesting. Oddly enough, the sc7280 datasheet doesn't list the "_A". It calls these "VDD_VREF_0P9" and "VDD_VREF_1P2". However, on the schematic in front of me someone labeled these pins on the sc7280 with the "A". ...and the driver looks for a supply with the "a". :-/

It would be good to get clarification from someone with better

information.

Quoted 5 lines
Quoted 2 lines

-Doug

Our internal power grid documents list the regulators as VDD_A_*_1P2 and VDD_A_*_0P9 for all the platforms.

Do your internal power grid documents indicate what these supplies are powering? The question is if these supplies power any of the logic inside the eDP controller or if they only supply power to the analog circuits in the eDP phy. If it's the eDP phy only then the regulator usage in the eDP driver should be removed. I would suspect this is the case because the controller is probably all digital logic and runs at the typical 1.8V that the rest of the SoC uses. Similarly, these are voltage references which sound like a PLL reference voltage.

Quoted 2 lines

Please clarify this further.

For the DP driver using the usb-dp combo phy, there were cases where the usb driver
was turning off the phy and pll regulators whenever usb-dp concurrent mode need not be supported. This caused phy and pll to be powered down causing aux transaction failures and display blankouts. From then on, it became a practice for the controller driver to vote for the phy and pll regulators also.

Quoted 5 lines
Quoted 5 lines

So, as a practice, we put the same name in the DT files. Hence,

#7 lore raw

RE: [PATCH 1/2] dt-bindings: msm/dp: List supplies in the bindings

Quoting Sankeerth Billakanti (QUIC) (2022-05-05 11:47:20)

Quoted 14 lines
Quoted 14 lines

Quoting Sankeerth Billakanti (2022-05-05 11:02:36)

Quoted 3 lines

Our internal power grid documents list the regulators as VDD_A_*_1P2 and VDD_A_*_0P9 for all the platforms.

Do your internal power grid documents indicate what these supplies are powering? The question is if these supplies power any of the logic inside the eDP controller or if they only supply power to the analog circuits in the eDP phy. If it's the eDP phy only then the regulator usage in the eDP driver should be removed. I would suspect this is the case because the controller is probably all digital logic and runs at the typical 1.8V that the rest of the SoC uses. Similarly, these are voltage references which sound like a PLL reference voltage.

Quoted 8 lines
Quoted 2 lines

Please clarify this further.

For the DP driver using the usb-dp combo phy, there were cases where the usb driver
was turning off the phy and pll regulators whenever usb-dp concurrent mode need not be supported. This caused phy and pll to be powered down causing aux transaction failures and display blankouts. From then on, it became a practice for the controller driver to vote for the phy and pll regulators also.

That sounds like USB-DP combo phy driver had improper regulator power management where aux transactions from DP didn't keep the power on to the phy. Where does the power physically go? If the power isn't physically going to the DP controller it shouldn't be controlled from the DP controller driver. If the aux bus needs the DP phy enabled, the DP controller driver should enable the phy power (via phy_power_on()?).

#8 lore raw

RE: [PATCH 1/2] dt-bindings: msm/dp: List supplies in the bindings

Quoted 25 lines
Quoted 11 lines
Quoted 11 lines
Quoted 2 lines

Our internal power grid documents list the regulators as VDD_A_*_1P2 and VDD_A_*_0P9 for all the platforms.

Do your internal power grid documents indicate what these supplies are powering? The question is if these supplies power any of the logic inside the eDP controller or if they only supply power to the analog circuits in the eDP phy. If it's the eDP phy only then the regulator usage in the eDP driver should be removed. I would suspect this is the case because the controller is probably all digital logic and runs at the typical 1.8V that the rest of the SoC uses. Similarly, these are voltage references which sound like a PLL reference

voltage.

Quoted 6 lines
Quoted 3 lines

Please clarify this further.

For the DP driver using the usb-dp combo phy, there were cases where the usb driver was turning off the phy and pll regulators whenever usb-dp

concurrent mode need not be supported.

Quoted 1 line

This caused phy and pll to be powered down causing aux transaction failures

and display blankouts.

Quoted 1 line

From then on, it became a practice for the controller driver to vote for the

phy and pll regulators also.

Quoted 1 line
Quoted 6 lines

That sounds like USB-DP combo phy driver had improper regulator power management where aux transactions from DP didn't keep the power on to the phy. Where does the power physically go? If the power isn't physically going to the DP controller it shouldn't be controlled from the DP controller driver. If the aux bus needs the DP phy enabled, the DP controller driver should enable the phy power (via phy_power_on()?).

Yes, it was limitation earlier when we did not have proper interface to interact with the combo phy.

In this case, the power from the regulators go to the combo phy.

Now that there is an interface for the controller to interact with the combo phy, the proposal to drop the phy regulator voting from the controller driver seems reasonable to me.

The phy_power_on() is used for getting the phy out of low power state or getting it ready for data transfer.

The controller driver needs to enable the phy power via the phy_init() before any interaction with the sink like the aux transactions or before sending the data. The controller can disable the regulators via the phy_exit() call.

Thank you,
Sankeerth

#9 lore raw

Re: [PATCH 1/2] dt-bindings: msm/dp: List supplies in the bindings

Hi,

Quoted 42 lines · Sankeerth Billakanti (QUIC)
Quoted 26 lines
Quoted 4 lines
Quoted 4 lines
Quoted 3 lines

Our internal power grid documents list the regulators as VDD_A_*_1P2 and VDD_A_*_0P9 for all the platforms.

Quoted 8 lines
Quoted 8 lines

Do your internal power grid documents indicate what these supplies are powering? The question is if these supplies power any of the logic inside the eDP controller or if they only supply power to the analog circuits in the eDP phy. If it's the eDP phy only then the regulator usage in the eDP driver should be removed. I would suspect this is the case because the controller is probably all digital logic and runs at the typical 1.8V that the rest of the SoC uses. Similarly, these are voltage references which sound like a PLL reference

voltage.

Quoted 6 lines
Quoted 3 lines

Please clarify this further.

For the DP driver using the usb-dp combo phy, there were cases where the usb driver was turning off the phy and pll regulators whenever usb-dp

concurrent mode need not be supported.

Quoted 1 line

This caused phy and pll to be powered down causing aux transaction failures

and display blankouts.

Quoted 1 line

From then on, it became a practice for the controller driver to vote for the

phy and pll regulators also.

Quoted 1 line
Quoted 6 lines

That sounds like USB-DP combo phy driver had improper regulator power management where aux transactions from DP didn't keep the power on to the phy. Where does the power physically go? If the power isn't physically going to the DP controller it shouldn't be controlled from the DP controller driver. If the aux bus needs the DP phy enabled, the DP controller driver should enable the phy power (via phy_power_on()?).

Yes, it was limitation earlier when we did not have proper interface to interact with the combo phy.

In this case, the power from the regulators go to the combo phy.

Now that there is an interface for the controller to interact with the combo phy, the proposal to drop the phy regulator voting from the controller driver seems reasonable to me.

Quoted 6 lines

The phy_power_on() is used for getting the phy out of low power state or getting it ready for data transfer.

The controller driver needs to enable the phy power via the phy_init() before any interaction with the sink like the aux transactions or before sending the data. The controller can disable the regulators via the phy_exit() call.

I can confirm that if I stop providing these regulators to the DP controller that the screen still comes up. ...but also there are lots of other things (including the PHY) that power these regulators up...

From offline discussion with folks:

1. It sounds like maybe the code for handling the regulators in the DP controller leaked in from downstream where the DP driver itself controls more stuff.

2. We should probably remove these regulators from the DP controller.

3. When we remove this from the DP controller, we'll have to make sure that the PHY driver calls regulator_set_load() as needed.

Kuogee has volunteered to own this issue and send out patches fixing the stuff up. So for now, please consider ${SUBJECT} patch abandoned.

-Doug

#10 lore raw

PATCH 2/2 dt-bindings: phy: List supplies for qcom,edp-phy

In reply to Douglas Anderson

We're supposed to list the supplies in the dt bindings but there are none in the eDP PHY bindings.

Looking at the driver in Linux, I can see that there seem to be two relevant supplies: "vdda-phy" and "vdda-pll". Let's add those to the bindings.

NOTE: from looking at the Qualcomm datasheet for sc7280, it's not immediately clear how to figure out how to fill in these supplies. The only two eDP related supplies are simply described as "power for eDP 0.9V circuits" and "power for eDP 1.2V circuits". From guessing and from comparing how a similar PHY is hooked up on other similar Qualcomm boards, I'll make the educated guess that the 1.2V supply goes to "vdda-phy" and the 0.9V supply goes to "vdda-pll" and I'll use that in the example here.

---

 Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml +6 -0
index a5850ff529f8..cf9e9b8011cb 100644
@@ -41,6 +41,9 @@ properties:
   "#phy-cells":
     const: 0
 
+  vdda-phy-supply: true
+  vdda-pll-supply: true
+
 required:
   - compatible
   - reg
@@ -65,5 +68,8 @@ examples:
 
       #clock-cells = <1>;
       #phy-cells = <0>;
+
+      vdda-phy-supply = <&vdd_a_edp_0_1p2>;
+      vdda-pll-supply = <&vdd_a_edp_0_0p9>;
     };
 ...
Signature · 1 line
2.36.0.rc2.479.g8af0fa9b8e-goog
Reviewed-by on v1 2/2
#11 lore raw

RE: [PATCH 2/2] dt-bindings: phy: List supplies for qcom,edp-phy

Quoted 45 lines

We're supposed to list the supplies in the dt bindings but there are none in the eDP PHY bindings.

Looking at the driver in Linux, I can see that there seem to be two relevant
supplies: "vdda-phy" and "vdda-pll". Let's add those to the bindings.

NOTE: from looking at the Qualcomm datasheet for sc7280, it's not immediately clear how to figure out how to fill in these supplies. The only two eDP related supplies are simply described as "power for eDP 0.9V circuits" and "power for eDP 1.2V circuits". From guessing and from comparing how a similar PHY is hooked up on other similar Qualcomm boards, I'll make the educated guess that the 1.2V supply goes to "vdda-phy" and the 0.9V supply goes to "vdda-pll" and I'll use that in the example here.

---

Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 6 ++++++

1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml +3 -0
index a5850ff529f8..cf9e9b8011cb 100644
@@ -41,6 +41,9 @@ properties:
  "#phy-cells":
    const: 0
 
+  vdda-phy-supply: true
+  vdda-pll-supply: true
+

required:
- compatible
- reg

Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml +3 -1
@@ -65,5 +68,8 @@ examples:
 
      #clock-cells = <1>;
      #phy-cells = <0>;
+
+      vdda-phy-supply = <&vdd_a_edp_0_1p2>;
+      vdda-pll-supply = <&vdd_a_edp_0_0p9>;
    };
...
--
Quoted 1 line

2.36.0.rc2.479.g8af0fa9b8e-goog

#12 lore raw

Re: [PATCH 2/2] dt-bindings: phy: List supplies for qcom,edp-phy

In reply to Douglas Anderson

Hi,

Quoted 17 lines · Douglas Anderson

We're supposed to list the supplies in the dt bindings but there are none in the eDP PHY bindings.

Looking at the driver in Linux, I can see that there seem to be two relevant supplies: "vdda-phy" and "vdda-pll". Let's add those to the bindings.

NOTE: from looking at the Qualcomm datasheet for sc7280, it's not immediately clear how to figure out how to fill in these supplies. The only two eDP related supplies are simply described as "power for eDP 0.9V circuits" and "power for eDP 1.2V circuits". From guessing and from comparing how a similar PHY is hooked up on other similar Qualcomm boards, I'll make the educated guess that the 1.2V supply goes to "vdda-phy" and the 0.9V supply goes to "vdda-pll" and I'll use that in the example here.

Quoted 5 lines

---

 Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

Even though patch #1 in this series should be dropped, this patch (patch #2) is still valid. Vinod: I assume this would land in your tree along with the first two patches in Kuogee's series [1], which are related. Please let me know if you need me to re-send or anything. Thanks!

[1] https://lore.kernel.org/r/[email protected]/

-Doug

maintainer Applied
#13 lore raw

Re: [PATCH 2/2] dt-bindings: phy: List supplies for qcom,edp-phy

Quoted 23 lines · Doug Anderson

Hi,

Quoted 20 lines · Douglas Anderson

We're supposed to list the supplies in the dt bindings but there are none in the eDP PHY bindings.

Looking at the driver in Linux, I can see that there seem to be two relevant supplies: "vdda-phy" and "vdda-pll". Let's add those to the bindings.

NOTE: from looking at the Qualcomm datasheet for sc7280, it's not immediately clear how to figure out how to fill in these supplies. The only two eDP related supplies are simply described as "power for eDP 0.9V circuits" and "power for eDP 1.2V circuits". From guessing and from comparing how a similar PHY is hooked up on other similar Qualcomm boards, I'll make the educated guess that the 1.2V supply goes to "vdda-phy" and the 0.9V supply goes to "vdda-pll" and I'll use that in the example here.

---

Quoted 7 lines
Quoted 2 lines
 Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

Even though patch #1 in this series should be dropped, this patch (patch #2) is still valid. Vinod: I assume this would land in your tree along with the first two patches in Kuogee's series [1], which are related. Please let me know if you need me to re-send or anything.

I have applied this patch, thanks

Quoted 1 line

[1] https://lore.kernel.org/r/[email protected]/

This needs rebase on phy split which I have picked

Signature · 1 line
~Vinod