Skip to contentSkip to conversation

ACPI: AGDI: Fix missing prototype warning for acpi_agdi_init()

PATCH Applied Ilkka Koskinen 2 participants 2 messages Apr 25, 2022 – May 6, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ACPI: AGDI: Fix missing prototype warning for acpi_agdi_init()

When building with W=1, we get the following warning:

drivers/acpi/arm64/agdi.c:88:13: warning: no previous prototype for ‘acpi_agdi_init’ [-Wmissing-prototypes]
void __init acpi_agdi_init(void)

Include AGDI driver's header file to pull in the prototype definition for acpi_agdi_init() to get rid of the compiler warning

Fixes a2a591fb76e6 ("ACPI: AGDI: Add driver for Arm Generic Diagnostic Dump and Reset device")
---
 drivers/acpi/arm64/agdi.c | 1 +
 1 file changed, 1 insertion(+)
drivers/acpi/arm64/agdi.c +1 -0
index 4df337d545b7..cf31abd0ed1b 100644
@@ -9,6 +9,7 @@
 #define pr_fmt(fmt) "ACPI: AGDI: " fmt
 
 #include <linux/acpi.h>
+#include <linux/acpi_agdi.h>
 #include <linux/arm_sdei.h>
 #include <linux/io.h>
 #include <linux/kernel.h>
Signature · 7 lines
2.17.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
maintainer Applied
#1 lore raw
Quoted 21 lines · Ilkka Koskinen

When building with W=1, we get the following warning:

drivers/acpi/arm64/agdi.c:88:13: warning: no previous prototype for ‘acpi_agdi_init’ [-Wmissing-prototypes]
void __init acpi_agdi_init(void)

Include AGDI driver's header file to pull in the prototype definition for acpi_agdi_init() to get rid of the compiler warning

Fixes a2a591fb76e6 ("ACPI: AGDI: Add driver for Arm Generic Diagnostic Dump and Reset device")
---
 drivers/acpi/arm64/agdi.c | 1 +
 1 file changed, 1 insertion(+)
drivers/acpi/arm64/agdi.c +0 -0
index 4df337d545b7..cf31abd0ed1b 100644

drivers/acpi/arm64/agdi.c

Quoted 8 lines
drivers/acpi/arm64/agdi.c +1 -1
@@ -9,6 +9,7 @@
 #define pr_fmt(fmt) "ACPI: AGDI: " fmt
 
 #include <linux/acpi.h>
+#include <linux/acpi_agdi.h>
 #include <linux/arm_sdei.h>
 #include <linux/io.h>
 #include <linux/kernel.h>
--

Applied as 5.19 material, thanks!