Skip to contentSkip to conversation

generic/681, generic/682: add debugging information to $seqreq.full

PATCH In review Theodore Ts'o 2 participants 2 messages Apr 25, 2022 – Apr 26, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 generic/681, generic/682: add debugging information to $seqreq.full

These two tests are checking whether a non-privileged user causing a block allocation while expanding a directory block when over quota will fail with an EDQUOT error. There are three reasons why this can fail.

* Aa test bug, where if the file system is using cluster allocation (for example, ext4 bigalloc) the test doesn't add enough directory entries to actually force directory grwoth.

* A file system bug, where the file system allocates blocks but for some reason isn't charging the space quota correctly (which currently seems to be the case in ext4 with fscrypt).

* A file system bug, where the file system is correctly charging the space quota to the unprivileged user, but isn't failing the system call with EDQUOT.

By adding some additional debugging information about whether directory has grown or not (in addition to the existing repquota output) to the the $seqres.full, it makes easier for the file system developer to disambiguate between these possibilities. It's cheap to do this, and it could save developer time when trying to root cause the failure.

Cc Darrick J. Wong <[email protected]>
---
 tests/generic/681 | 4 ++++
 tests/generic/682 | 4 ++++
 2 files changed, 8 insertions(+)
tests/generic/681 +4 -0
index 2baae9f4..090da795 100755
@@ -50,6 +50,8 @@ echo "set up quota" >> $seqres.full
 setquota -u $qa_user 0 "$((blocksize / 1024))" 0 0 $SCRATCH_MNT
 chown $qa_user $scratchdir $scratchfile
 repquota -upn $SCRATCH_MNT >> $seqres.full
+echo $(ls $scratchdir | wc -l) files in $scratchdir  >> $seqres.full
+ls -sld $scratchdir  >> $seqres.full
 
 # Fail at appending the directory as qa_user to ensure quota enforcement works
 echo "fail quota" >> $seqres.full
@@ -60,6 +62,8 @@ for ((i = 0; i < dirents; i++)); do
 	test "${PIPESTATUS[0]}" -ne 0 && break
 done
 repquota -upn $SCRATCH_MNT >> $seqres.full
+echo $(ls $scratchdir | wc -l) files in $scratchdir  >> $seqres.full
+ls -sld $scratchdir  >> $seqres.full
 
 # success, all done
 echo Silence is golden
tests/generic/682 +4 -0
index 31629a56..b4cd0cd9 100755
@@ -51,6 +51,8 @@ echo "set up quota" >> $seqres.full
 setquota -u $qa_user 0 "$((blocksize / 1024))" 0 0 $SCRATCH_MNT
 chown $qa_user $scratchdir $scratchfile
 repquota -upn $SCRATCH_MNT >> $seqres.full
+echo $(ls $scratchdir | wc -l) files in $scratchdir  >> $seqres.full
+ls -sld $scratchdir  >> $seqres.full
 
 # Fail at renaming into the directory as qa_user to ensure quota enforcement
 # works
@@ -64,6 +66,8 @@ for ((i = 0; i < dirents; i++)); do
 	test "${PIPESTATUS[0]}" -ne 0 && break
 done
 repquota -upn $SCRATCH_MNT >> $seqres.full
+echo $(ls $scratchdir | wc -l) files in $scratchdir  >> $seqres.full
+ls -sld $scratchdir  >> $seqres.full
 
 # success, all done
 echo Silence is golden
Signature · 1 line
2.31.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 24 lines · Theodore Ts'o

These two tests are checking whether a non-privileged user causing a block allocation while expanding a directory block when over quota will fail with an EDQUOT error. There are three reasons why this can fail.

* Aa test bug, where if the file system is using cluster allocation (for example, ext4 bigalloc) the test doesn't add enough directory entries to actually force directory grwoth.

* A file system bug, where the file system allocates blocks but for some reason isn't charging the space quota correctly (which currently seems to be the case in ext4 with fscrypt).

* A file system bug, where the file system is correctly charging the space quota to the unprivileged user, but isn't failing the system call with EDQUOT.

By adding some additional debugging information about whether directory has grown or not (in addition to the existing repquota output) to the the $seqres.full, it makes easier for the file system developer to disambiguate between these possibilities. It's cheap to do this, and it could save developer time when trying to root cause the failure.

Quoted 2 lines
Cc Darrick J. Wong <[email protected]>

Sure, why not? :)

--D

Quoted 52 lines
---
 tests/generic/681 | 4 ++++
 tests/generic/682 | 4 ++++
 2 files changed, 8 insertions(+)
tests/generic/681 +4 -0
index 2baae9f4..090da795 100755
@@ -50,6 +50,8 @@ echo "set up quota" >> $seqres.full
 setquota -u $qa_user 0 "$((blocksize / 1024))" 0 0 $SCRATCH_MNT
 chown $qa_user $scratchdir $scratchfile
 repquota -upn $SCRATCH_MNT >> $seqres.full
+echo $(ls $scratchdir | wc -l) files in $scratchdir  >> $seqres.full
+ls -sld $scratchdir  >> $seqres.full
 
 # Fail at appending the directory as qa_user to ensure quota enforcement works
 echo "fail quota" >> $seqres.full
@@ -60,6 +62,8 @@ for ((i = 0; i < dirents; i++)); do
 	test "${PIPESTATUS[0]}" -ne 0 && break
 done
 repquota -upn $SCRATCH_MNT >> $seqres.full
+echo $(ls $scratchdir | wc -l) files in $scratchdir  >> $seqres.full
+ls -sld $scratchdir  >> $seqres.full
 
 # success, all done
 echo Silence is golden
tests/generic/682 +4 -0
index 31629a56..b4cd0cd9 100755
@@ -51,6 +51,8 @@ echo "set up quota" >> $seqres.full
 setquota -u $qa_user 0 "$((blocksize / 1024))" 0 0 $SCRATCH_MNT
 chown $qa_user $scratchdir $scratchfile
 repquota -upn $SCRATCH_MNT >> $seqres.full
+echo $(ls $scratchdir | wc -l) files in $scratchdir  >> $seqres.full
+ls -sld $scratchdir  >> $seqres.full
 
 # Fail at renaming into the directory as qa_user to ensure quota enforcement
 # works
@@ -64,6 +66,8 @@ for ((i = 0; i < dirents; i++)); do
 	test "${PIPESTATUS[0]}" -ne 0 && break
 done
 repquota -upn $SCRATCH_MNT >> $seqres.full
+echo $(ls $scratchdir | wc -l) files in $scratchdir  >> $seqres.full
+ls -sld $scratchdir  >> $seqres.full
 
 # success, all done
 echo Silence is golden
Signature · 1 line
2.31.0