Skip to contentSkip to conversation

dt-bindings: mailbox: qcom-ipcc: add missing compatible for SM8450

PATCH Applied David Heidelberg 5 participants 8 messages Apr 26, 2022 – May 3, 2022

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH v4 1/2 dt-bindings: mailbox: qcom-ipcc: add missing compatible for SM8450

Fill missing compatible already used in SM8450 DTS.

---
 Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml +1 -0
index 866efb278813..c57dd423e98c 100644
@@ -27,6 +27,7 @@ properties:
           - qcom,sm6350-ipcc
           - qcom,sm8250-ipcc
           - qcom,sm8350-ipcc
+          - qcom,sm8450-ipcc
           - qcom,sc7280-ipcc
       - const: qcom,ipcc
 
Signature · 1 line
2.35.1
#1 lore raw

PATCH v4 2/2 dt-bindings: mailbox: qcom-ipcc: add missing properties into example

These missing required properties are needed for
smp2p binding reference checks.

Also includes cosmetic change to the example formatting.

---
v3:
- add Krzysztof R-b

---
 .../devicetree/bindings/mailbox/qcom-ipcc.yaml        | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml +8 -3
index c57dd423e98c..50f9aa72c670 100644
@@ -76,9 +76,14 @@ examples:
 
         smp2p-modem {
                 compatible = "qcom,smp2p";
-                interrupts-extended = <&ipcc_mproc IPCC_CLIENT_MPSS
-                                IPCC_MPROC_SIGNAL_SMP2P IRQ_TYPE_EDGE_RISING>;
-                mboxes = <&ipcc_mproc IPCC_CLIENT_MPSS IPCC_MPROC_SIGNAL_SMP2P>;
+                qcom,smem = <443>, <429>;
+                interrupts-extended = <&ipcc IPCC_CLIENT_LPASS
+                                             IPCC_MPROC_SIGNAL_SMP2P
+                                             IRQ_TYPE_EDGE_RISING>;
+                mboxes = <&ipcc IPCC_CLIENT_LPASS
+                                IPCC_MPROC_SIGNAL_SMP2P>;
 
+                qcom,local-pid = <0>;
+                qcom,remote-pid = <2>;
                 /* Other SMP2P fields */
         };
Signature · 1 line
2.35.1
#2 lore raw

Re: [PATCH v4 2/2] dt-bindings: mailbox: qcom-ipcc: add missing properties into example

Quoted 5 lines · David Heidelberg

These missing required properties are needed for
smp2p binding reference checks.

Also includes cosmetic change to the example formatting.

Missing reported-by:

Quoted 5 lines

---
v3:
- add Krzysztof R-b

BTW, this patch confuses me a bit... You sent it some time after I sent a fix:
https://lore.kernel.org/all/[email protected]/

Best regards,
Krzysztof

maintainer Reviewed-by on v4 2/2
#3 lore raw

Re: [PATCH v4 2/2] dt-bindings: mailbox: qcom-ipcc: add missing properties into example

In reply to David Heidelberg
Quoted 7 lines · David Heidelberg

These missing required properties are needed for
smp2p binding reference checks.

Also includes cosmetic change to the example formatting.

Thanks,
Mani

Quoted 32 lines

---
v3:
- add Krzysztof R-b

---
 .../devicetree/bindings/mailbox/qcom-ipcc.yaml        | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml +8 -3
index c57dd423e98c..50f9aa72c670 100644
@@ -76,9 +76,14 @@ examples:
 
         smp2p-modem {
                 compatible = "qcom,smp2p";
-                interrupts-extended = <&ipcc_mproc IPCC_CLIENT_MPSS
-                                IPCC_MPROC_SIGNAL_SMP2P IRQ_TYPE_EDGE_RISING>;
-                mboxes = <&ipcc_mproc IPCC_CLIENT_MPSS IPCC_MPROC_SIGNAL_SMP2P>;
+                qcom,smem = <443>, <429>;
+                interrupts-extended = <&ipcc IPCC_CLIENT_LPASS
+                                             IPCC_MPROC_SIGNAL_SMP2P
+                                             IRQ_TYPE_EDGE_RISING>;
+                mboxes = <&ipcc IPCC_CLIENT_LPASS
+                                IPCC_MPROC_SIGNAL_SMP2P>;
 
+                qcom,local-pid = <0>;
+                qcom,remote-pid = <2>;
                 /* Other SMP2P fields */
         };
Signature · 1 line
2.35.1
maintainer Applied
#4 lore raw

Re: [PATCH v4 2/2] dt-bindings: mailbox: qcom-ipcc: add missing properties into example

In reply to David Heidelberg
Quoted 5 lines · David Heidelberg

These missing required properties are needed for
smp2p binding reference checks.

Also includes cosmetic change to the example formatting.

Quoted 8 lines

---
v3:
- add Krzysztof R-b

---
 .../devicetree/bindings/mailbox/qcom-ipcc.yaml        | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

Applied, thanks!

Reviewed-by on v4 1/2
#5 lore raw
In reply to David Heidelberg
Quoted 4 lines · David Heidelberg

Fill missing compatible already used in SM8450 DTS.

Quoted 19 lines
---
 Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml +1 -1
index 866efb278813..c57dd423e98c 100644
@@ -27,6 +27,7 @@ properties:
           - qcom,sm6350-ipcc
           - qcom,sm8250-ipcc
           - qcom,sm8350-ipcc
+          - qcom,sm8450-ipcc
           - qcom,sc7280-ipcc
       - const: qcom,ipcc
 
--

2.35.1

Signature · 2 lines
With best wishes
Dmitry
maintainer Reviewed-by on v4 1/2
#6 lore raw
In reply to David Heidelberg
Quoted 3 lines · David Heidelberg

Fill missing compatible already used in SM8450 DTS.

Thanks,
Mani

Quoted 19 lines
---
 Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml +1 -0
index 866efb278813..c57dd423e98c 100644
@@ -27,6 +27,7 @@ properties:
           - qcom,sm6350-ipcc
           - qcom,sm8250-ipcc
           - qcom,sm8350-ipcc
+          - qcom,sm8450-ipcc
           - qcom,sc7280-ipcc
       - const: qcom,ipcc
 
Signature · 1 line
2.35.1