dt-bindings: mailbox: qcom-ipcc: add missing compatible for SM8450
Subsystems (4)
PATCH v4 1/2 dt-bindings: mailbox: qcom-ipcc: add missing compatible for SM8450
Fill missing compatible already used in SM8450 DTS.
--- Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml +1 -0
@@ -27,6 +27,7 @@ properties: - qcom,sm6350-ipcc - qcom,sm8250-ipcc - qcom,sm8350-ipcc + - qcom,sm8450-ipcc - qcom,sc7280-ipcc - const: qcom,ipcc
Signature · 1 line
2.35.1
PATCH v4 2/2 dt-bindings: mailbox: qcom-ipcc: add missing properties into example
These missing required properties are needed for
smp2p binding reference checks.
Also includes cosmetic change to the example formatting.
---
v3:
- add Krzysztof R-b
--- .../devicetree/bindings/mailbox/qcom-ipcc.yaml | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml +8 -3
@@ -76,9 +76,14 @@ examples: smp2p-modem { compatible = "qcom,smp2p"; - interrupts-extended = <&ipcc_mproc IPCC_CLIENT_MPSS - IPCC_MPROC_SIGNAL_SMP2P IRQ_TYPE_EDGE_RISING>; - mboxes = <&ipcc_mproc IPCC_CLIENT_MPSS IPCC_MPROC_SIGNAL_SMP2P>; + qcom,smem = <443>, <429>; + interrupts-extended = <&ipcc IPCC_CLIENT_LPASS + IPCC_MPROC_SIGNAL_SMP2P + IRQ_TYPE_EDGE_RISING>; + mboxes = <&ipcc IPCC_CLIENT_LPASS + IPCC_MPROC_SIGNAL_SMP2P>; + qcom,local-pid = <0>; + qcom,remote-pid = <2>; /* Other SMP2P fields */ };
Signature · 1 line
2.35.1
Re: [PATCH v4 2/2] dt-bindings: mailbox: qcom-ipcc: add missing properties into example
Quoted 5 lines · David Heidelberg
These missing required properties are needed for
smp2p binding reference checks.Also includes cosmetic change to the example formatting.
Missing reported-by:
Quoted 5 lines
Reviewed-by Krzysztof Kozlowski <[email protected]>Signed-off-by David Heidelberg <[email protected]>---
v3:
- add Krzysztof R-b
BTW, this patch confuses me a bit... You sent it some time after I sent a fix:
https://lore.kernel.org/all/[email protected]/
Best regards,
Krzysztof
Re: [PATCH v4 2/2] dt-bindings: mailbox: qcom-ipcc: add missing properties into example
In reply to David HeidelbergQuoted 7 lines · David Heidelberg
These missing required properties are needed for
smp2p binding reference checks.Also includes cosmetic change to the example formatting.
Reviewed-by Krzysztof Kozlowski <[email protected]>Signed-off-by David Heidelberg <[email protected]>
Thanks,
Mani
Quoted 32 lines
---
v3:
- add Krzysztof R-b--- .../devicetree/bindings/mailbox/qcom-ipcc.yaml | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-)Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml +8
-3@@ -76,9 +76,14 @@ examples: smp2p-modem { compatible = "qcom,smp2p"; - interrupts-extended = <&ipcc_mproc IPCC_CLIENT_MPSS - IPCC_MPROC_SIGNAL_SMP2P IRQ_TYPE_EDGE_RISING>; - mboxes = <&ipcc_mproc IPCC_CLIENT_MPSS IPCC_MPROC_SIGNAL_SMP2P>; + qcom,smem = <443>, <429>; + interrupts-extended = <&ipcc IPCC_CLIENT_LPASS + IPCC_MPROC_SIGNAL_SMP2P + IRQ_TYPE_EDGE_RISING>; + mboxes = <&ipcc IPCC_CLIENT_LPASS + IPCC_MPROC_SIGNAL_SMP2P>; + qcom,local-pid = <0>; + qcom,remote-pid = <2>; /* Other SMP2P fields */ };Signature · 1 line
2.35.1
Re: [PATCH v4 2/2] dt-bindings: mailbox: qcom-ipcc: add missing properties into example
In reply to David HeidelbergQuoted 5 lines · David Heidelberg
These missing required properties are needed for
smp2p binding reference checks.Also includes cosmetic change to the example formatting.
Quoted 8 lines
Reviewed-by Krzysztof Kozlowski <[email protected]>Signed-off-by David Heidelberg <[email protected]>---
v3:
- add Krzysztof R-b--- .../devicetree/bindings/mailbox/qcom-ipcc.yaml | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-)
Applied, thanks!
Quoted 4 lines · David Heidelberg
Fill missing compatible already used in SM8450 DTS.
Signed-off-by David Heidelberg <[email protected]>
Quoted 19 lines
--- Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml | 1 + 1 file changed, 1 insertion(+)Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml +1
-1@@ -27,6 +27,7 @@ properties: - qcom,sm6350-ipcc - qcom,sm8250-ipcc - qcom,sm8350-ipcc + - qcom,sm8450-ipcc - qcom,sc7280-ipcc - const: qcom,ipcc --2.35.1
Signature · 2 lines
With best wishes Dmitry
Quoted 3 lines · David Heidelberg
Fill missing compatible already used in SM8450 DTS.
Signed-off-by David Heidelberg <[email protected]>
Thanks,
Mani
Quoted 19 lines
--- Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml | 1 + 1 file changed, 1 insertion(+)Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml +1
-0@@ -27,6 +27,7 @@ properties: - qcom,sm6350-ipcc - qcom,sm8250-ipcc - qcom,sm8350-ipcc + - qcom,sm8450-ipcc - qcom,sc7280-ipcc - const: qcom,ipccSignature · 1 line
2.35.1
Quoted 7 lines · David Heidelberg
Fill missing compatible already used in SM8450 DTS.
Signed-off-by David Heidelberg <[email protected]>--- Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml | 1 + 1 file changed, 1 insertion(+)
Applied, thanks!