Skip to contentSkip to conversation

i915/gem_eio: Removed early timeout check for forced reset completion

PATCH In review [email protected] 3 participants 3 messages Apr 26, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i915/gem_eio: Removed early timeout check for forced reset completion

From: Bommu Krishnaiah <[email protected]>

GUC log capture is taking more time on few platforms, so removing early timeout check for forced reset completion.
Test is having same check in later.

Cc Kamil Konieczny <[email protected]>
Cc John Harrison <[email protected]>
Cc Andi Shyti <[email protected]>
---
 tests/i915/gem_eio.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
tests/i915/gem_eio.c +3 -2
index d9689534d5a..30eaceb1b3d 100644
@@ -72,8 +72,9 @@ static void trigger_reset(int fd)
 	igt_kmsg(KMSG_DEBUG "Forcing GPU reset\n");
 	igt_force_gpu_reset(fd);
 
-	/* The forced reset should be immediate */
-	igt_assert_lte(igt_seconds_elapsed(&ts), 2);
+	/* The forced reset should be immediate non GUC platforms */
+	if (!gem_using_guc_submission(fd))
+		igt_assert_lte(igt_seconds_elapsed(&ts), 2);
 
 	/* And just check the gpu is indeed running again */
 	igt_kmsg(KMSG_DEBUG "Checking that the GPU recovered\n");
Signature · 1 line
2.25.1
#1 lore raw

[igt-dev] ✗ Fi.CI.BAT: failure for i915/gem_eio: Removed early timeout check for forced reset completion

== Series Details ==

== Series Details ==

Series: i915/gem_eio: Removed early timeout check for forced reset completion
URL : https://patchwork.freedesktop.org/series/103135/
State : failure

== Summary ==

CI Bug Log - changes from IGT_6454 -> IGTPW_7005
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_7005 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_7005, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7005/index.html

Participating hosts (44 -> 44)
------------------------------

Additional (2): bat-adlm-1 bat-adlp-4
Missing (2): fi-bsw-cyan fi-cfl-8700k

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_7005:

### IGT changes ###

#### Possible regressions ####

* igt@i915_pm_rpm@module-reload:
- bat-adlp-4: NOTRUN -> [INCOMPLETE][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7005/bat-adlp-4/igt@[email protected]

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* igt@i915_selftest@live@hugepages:
- {bat-rpls-1}: [PASS][2] -> [DMESG-WARN][3]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6454/bat-rpls-1/igt@i915_selftest@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7005/bat-rpls-1/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@slpc:
- {bat-rpls-1}: NOTRUN -> [INCOMPLETE][4]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7005/bat-rpls-1/igt@i915_selftest@[email protected]

Known issues
------------

Here are the changes found in IGTPW_7005 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_lmem_swapping@basic:
- bat-adlp-4: NOTRUN -> [SKIP][5] ([i915#4613]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7005/bat-adlp-4/igt@[email protected]

* igt@gem_tiled_pread_basic:
- bat-adlp-4: NOTRUN -> [SKIP][6] ([i915#3282])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7005/bat-adlp-4/igt@gem_tiled_pread_basic.html

* igt@i915_selftest@live@hangcheck:
- fi-snb-2600: [PASS][7] -> [INCOMPLETE][8] ([i915#3921])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6454/fi-snb-2600/igt@i915_selftest@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7005/fi-snb-2600/igt@i915_selftest@[email protected]

* igt@kms_busy@basic@modeset:
- bat-adlp-4: NOTRUN -> [DMESG-WARN][9] ([i915#3576]) +2 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7005/bat-adlp-4/igt@kms_busy@[email protected]

* igt@kms_chamelium@dp-crc-fast:
- bat-adlp-4: NOTRUN -> [SKIP][10] ([fdo#111827]) +8 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7005/bat-adlp-4/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- bat-adlp-4: NOTRUN -> [SKIP][11] ([i915#4103]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7005/bat-adlp-4/igt@[email protected]

* igt@kms_force_connector_basic@prune-stale-modes:
- bat-adlp-4: NOTRUN -> [SKIP][12] ([i915#4093]) +3 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7005/bat-adlp-4/igt@[email protected]

* igt@kms_setmode@basic-clone-single-crtc:
- bat-adlp-4: NOTRUN -> [SKIP][13] ([i915#3555])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7005/bat-adlp-4/igt@[email protected]

* igt@prime_vgem@basic-fence-read:
- bat-adlp-4: NOTRUN -> [SKIP][14] ([i915#3291] / [i915#3708]) +2 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7005/bat-adlp-4/igt@[email protected]

* igt@prime_vgem@basic-userptr:
- bat-adlp-4: NOTRUN -> [SKIP][15] ([i915#3301] / [i915#3708])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7005/bat-adlp-4/igt@[email protected]

#### Possible fixes ####

* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: [INCOMPLETE][16] ([i915#4785]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6454/fi-hsw-4770/igt@i915_selftest@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7005/fi-hsw-4770/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@reset:
- {bat-rpls-1}: [DMESG-FAIL][18] ([i915#4983]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6454/bat-rpls-1/igt@i915_selftest@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7005/bat-rpls-1/igt@i915_selftest@[email protected]

* igt@kms_busy@basic@modeset:
- {bat-adlp-6}: [DMESG-WARN][20] ([i915#3576]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6454/bat-adlp-6/igt@kms_busy@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7005/bat-adlp-6/igt@kms_busy@[email protected]

* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b:
- fi-cfl-8109u: [DMESG-WARN][22] ([i915#62]) -> [PASS][23] +12 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6454/fi-cfl-8109u/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7005/fi-cfl-8109u/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#4093]: https://gitlab.freedesktop.org/drm/intel/issues/4093
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5708]: https://gitlab.freedesktop.org/drm/intel/issues/5708
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_6454 -> IGTPW_7005

CI-20190529: 20190529
CI_DRM_11550: 56b089ae03ef8ea8ab7f474eaa70367898891ef0 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_7005: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7005/index.html
IGT_6454: 855dc13d376b5e4561f6c022aa52b01aa4d0892f @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7005/index.html

#2 lore raw
In reply to [email protected]

Hi Krishnaiah,

Quoted 5 lines · On 2022-04-26 at 17:01:06 +0530, [email protected] wrote:

From: Bommu Krishnaiah <[email protected]>

GUC log capture is taking more time on few platforms, so removing early timeout check for forced reset completion.
Test is having same check in later.

s/Test is having same check in later./Test still checks timeout later, before function exit./

Quoted 14 lines
Cc Kamil Konieczny <[email protected]>
Cc John Harrison <[email protected]>
Cc Andi Shyti <[email protected]>
---
 tests/i915/gem_eio.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
tests/i915/gem_eio.c +0 -0
index d9689534d5a..30eaceb1b3d 100644

tests/i915/gem_eio.c static void trigger_reset(int fd) · line 75

Quoted 6 lines
tests/i915/gem_eio.c +1 -2
@@ -72,8 +72,9 @@ static void trigger_reset(int fd)
 	igt_kmsg(KMSG_DEBUG "Forcing GPU reset\n");
 	igt_force_gpu_reset(fd);
 
-	/* The forced reset should be immediate */
-	igt_assert_lte(igt_seconds_elapsed(&ts), 2);
+	/* The forced reset should be immediate non GUC platforms */

---------------------------------------------- ^ Add "for" here and add explanation why we are not checking it in GUC case.

	/*
	 * The forced reset should be immediate for non GUC platforms.
	 * GUC log capture can take some time so skip check here.
	 */

One thing to consider is to remember this condition in bool, before resetting gpu and before taking reference time, as this can eat up a little time. But maybe I overcomplicate this, so with above fixed you can add my r-b tag.

Regards,
Kamil

Quoted 8 lines
tests/i915/gem_eio.c +2 -0
+	if (!gem_using_guc_submission(fd))
+		igt_assert_lte(igt_seconds_elapsed(&ts), 2);
 
 	/* And just check the gpu is indeed running again */
 	igt_kmsg(KMSG_DEBUG "Checking that the GPU recovered\n");
Signature · 1 line
2.25.1