DSS: Add support for DisplayPort
Subsystems (2)
v4 cover DSS: Add support for DisplayPort
The following series of patches enables DisplayPort on j721e-evm
v2:
- use phandle with a parameter to refer clocks insted of sub nodes in serdes_wiz node
- move phy link node to board DTS file
v3:
- Fix the regulator node name as per the DT spec
- Use Macro for GPIO type
v4:
- Move adding of phy link nodes from 2/2 to 1/2, to fix dtbs checks warnings
- Add leading zeros to align reg property addresses and sizes
- Add empty ports for mhdp node in dtsi file to fix dtbs checks warnings
kernel patch verify report:
https://gist.githubusercontent.com/ravi-rahul/a982fef3fae03ec0dbdd5cb475a4cb25/raw/9ef482f96fa351cff7980e4340e9bcb8471ec3ab/report-kernel-patch-verify.txt
Tomi Valkeinen (2):
arm64: dts: ti: k3-j721e-*: add DP & DP PHY
arm64: dts: ti: k3-j721e-common-proc-board: add DP to j7 evm
.../dts/ti/k3-j721e-common-proc-board.dts | 77 ++++++++++++++++++- arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 75 +++++++++++++++++- arch/arm64/boot/dts/ti/k3-j721e-sk.dts | 16 ++++ 3 files changed, 162 insertions(+), 6 deletions(-)
Signature · 1 line
2.17.1
PATCH v4 1/2 arm64: dts: ti: k3-j721e-*: add DP & DP PHY
From: Tomi Valkeinen <[email protected]>
Add DT nodes for DisplayPort and DisplayPort PHY. The DP is Cadence MHDP 8546 and the PHY is a Cadence Torrent PHY with TI WIZ wrapper.
Also add the required phy link nodes in the board dts files.
A slight irregularity in the bindings is the DPTX PHY register block, which is in the MHDP IP, but is needed and mapped by the PHY.
--- .../dts/ti/k3-j721e-common-proc-board.dts | 16 ++++ arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 75 ++++++++++++++++++- arch/arm64/boot/dts/ti/k3-j721e-sk.dts | 16 ++++ 3 files changed, 105 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts +16 -0
@@ -793,6 +793,22 @@ }; }; +&serdes4 { + torrent_phy_dp: phy@0 { + reg = <0>; + resets = <&serdes_wiz4 1>; + cdns,phy-type = <PHY_TYPE_DP>; + cdns,num-lanes = <4>; + cdns,max-bit-rate = <5400>; + #phy-cells = <0>; + }; +}; + +&mhdp { + phys = <&torrent_phy_dp>; + phy-names = "dpphy"; +}; + &pcie0_rc { reset-gpios = <&exp1 6 GPIO_ACTIVE_HIGH>; phys = <&serdes0_pcie_link>;
arch/arm64/boot/dts/ti/k3-j721e-main.dtsi +73 -2
99 lines not on this page · raw message
arch/arm64/boot/dts/ti/k3-j721e-sk.dts +16 -0
@@ -624,6 +624,22 @@ }; }; +&serdes4 { + torrent_phy_dp: phy@0 { + reg = <0>; + resets = <&serdes_wiz4 1>; + cdns,phy-type = <PHY_TYPE_DP>; + cdns,num-lanes = <4>; + cdns,max-bit-rate = <5400>; + #phy-cells = <0>; + }; +}; + +&mhdp { + phys = <&torrent_phy_dp>; + phy-names = "dpphy"; +}; + &usbss0 { pinctrl-names = "default"; pinctrl-0 = <&main_usbss0_pins_default>;
Signature · 1 line
2.17.1
PATCH v4 2/2 arm64: dts: ti: k3-j721e-common-proc-board: add DP to j7 evm
In reply to Rahul T RFrom: Tomi Valkeinen <[email protected]>
Add the endpoint nodes to describe connection from DSS => MHDP => DisplayPort connector.
Also add the required pinmux nodes for hotplug.
--- .../dts/ti/k3-j721e-common-proc-board.dts | 61 +++++++++++++++++-- 1 file changed, 57 insertions(+), 4 deletions(-)
arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts +57 -4
@@ -148,6 +148,28 @@ pinctrl-0 = <&main_mcan2_gpio_pins_default>; standby-gpios = <&main_gpio0 127 GPIO_ACTIVE_HIGH>; }; + + dp_pwr_3v3: regulator-dp-prw { + compatible = "regulator-fixed"; + regulator-name = "dp-pwr"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + gpio = <&exp4 0 GPIO_ACTIVE_HIGH>; /* P0 - DP0_PWR_SW_EN */ + enable-active-high; + }; + + dp0: connector { + compatible = "dp-connector"; + label = "DP0"; + type = "full-size"; + dp-pwr-supply = <&dp_pwr_3v3>; + + port { + dp_connector_in: endpoint { + remote-endpoint = <&dp0_out>; + }; + }; + }; }; &main_pmx0 {
@@ -190,6 +212,12 @@ >; }; + dp0_pins_default: dp0-pins-default { + pinctrl-single,pins = < + J721E_IOPAD(0x1c4, PIN_INPUT, 5) /* SPI0_CS1.DP0_HPD */ + >; + }; + main_i2c1_exp4_pins_default: main-i2c1-exp4-pins-default { pinctrl-single,pins = < J721E_IOPAD(0x230, PIN_INPUT, 7) /* (U2) ECAP0_IN_APWM_OUT.GPIO1_11 */
@@ -658,6 +686,33 @@ <&k3_clks 152 18>; /* PLL23_HSDIV0 */ }; +&dss_ports { + port { + dpi0_out: endpoint { + remote-endpoint = <&dp0_in>; + }; + }; +}; + +&dp0_ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + dp0_in: endpoint { + remote-endpoint = <&dpi0_out>; + }; + }; + + port@4 { + reg = <4>; + dp0_out: endpoint { + remote-endpoint = <&dp_connector_in>; + }; + }; +}; + &mcasp0 { status = "disabled"; };
@@ -807,6 +862,8 @@ &mhdp { phys = <&torrent_phy_dp>; phy-names = "dpphy"; + pinctrl-names = "default"; + pinctrl-0 = <&dp0_pins_default>; }; &pcie0_rc {
@@ -859,10 +916,6 @@ status = "disabled"; }; -&dss { - status = "disabled"; -}; - &icssg0_mdio { status = "disabled"; };
Signature · 1 line
2.17.1
Nishanth Menon
maintainerRe: [PATCH v4 2/2] arm64: dts: ti: k3-j721e-common-proc-board: add DP to j7 evm
Quoted 2 lines · Rahul T R
From: Tomi Valkeinen <[email protected]>
[...]
arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts line 152
Quoted 11 lines
arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts +2
-0@@ -148,6 +148,28 @@ pinctrl-0 = <&main_mcan2_gpio_pins_default>; standby-gpios = <&main_gpio0 127 GPIO_ACTIVE_HIGH>; }; + + dp_pwr_3v3: regulator-dp-prw {
See feedback in https://lore.kernel.org/all/[email protected]/
Quoted 8 lines
arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts +8
-0+ compatible = "regulator-fixed"; + regulator-name = "dp-pwr"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + gpio = <&exp4 0 GPIO_ACTIVE_HIGH>; /* P0 - DP0_PWR_SW_EN */ + enable-active-high; + }; +
Signature · 3 lines
Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
Re: [PATCH v4 2/2] arm64: dts: ti: k3-j721e-common-proc-board: add DP to j7 evm
Quoted 7 lines · Nishanth Menon
Quoted 2 lines · Rahul T R
From: Tomi Valkeinen <[email protected]>
[...]
Quoted 1 line
Quoted 12 lines
arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts line 152
Quoted 10 lines
arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts +2
-0@@ -148,6 +148,28 @@ pinctrl-0 = <&main_mcan2_gpio_pins_default>; standby-gpios = <&main_gpio0 127 GPIO_ACTIVE_HIGH>; }; + + dp_pwr_3v3: regulator-dp-prw {See feedback in https://lore.kernel.org/all/[email protected]/
Hi Nishanth,
As per the feedback in the above thread
the name matches with below convention
"regulator-foo-bar" or "foo-bar-regulator"
Are you referring to the typo here?
regulator-dp-prw => regulator-dp-pwr
will fix this in the respin
Can you please clarify if you there is
any issue other than the typo
Regards
Rahul T R
Quoted 13 lines
Quoted 9 lines
arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts +8
-0+ compatible = "regulator-fixed"; + regulator-name = "dp-pwr"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + gpio = <&exp4 0 GPIO_ACTIVE_HIGH>; /* P0 - DP0_PWR_SW_EN */ + enable-active-high; + }; +Signature · 3 lines
Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D