fsi and hwmon (occ): Prevent occasional checksum failures
Subsystems (2)
Eddie James
maintainerv2 cover fsi and hwmon (occ): Prevent occasional checksum failures
Due to the OCC communication design with a shared SRAM area, checkum errors are expected due to corrupted buffer from OCC communications with other system components. Therefore, use a unique errno for checksum failures and retry the command twice in that case.
Changes since v1:
- Refactor the retry loop
Eddie James (2):
fsi: occ: Fix checksum failure mode
hwmon (occ): Retry for checksum failure
drivers/fsi/fsi-occ.c | 7 +++++-- drivers/hwmon/occ/p9_sbe.c | 15 +++++++++++---- 2 files changed, 16 insertions(+), 6 deletions(-)
Signature · 1 line
2.27.0
Eddie James
maintainerPATCH v2 1/2 fsi: occ: Fix checksum failure mode
Change the checksum errno to something different than the errno used for a bad SBE message. In addition, don't set the user's response length to the data length in this case, since it's not SBE FFDC.
--- drivers/fsi/fsi-occ.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/fsi/fsi-occ.c +5 -2
@@ -246,7 +246,7 @@ static int occ_verify_checksum(struct occ *occ, struct occ_response *resp,if (checksum != checksum_resp) {dev_err (occ->dev,"Bad checksum: %04x!=%04x\n" , checksum, checksum_resp); -return -EBADMSG ; +return -EBADE ; }return 0 ;
@@ -575,8 +575,11 @@ int fsi_occ_submit(struct device *dev, const void *request, size_t req_len,dev_dbg (dev,"resp_status=%02x resp_data_len=%d\n" , resp->return_status, resp_data_length); - occ->client_response_size = resp_data_length +7 ; rc =occ_verify_checksum (occ, resp, resp_data_length); +if (rc) + goto done; + + occ->client_response_size = resp_data_length +7 ; done: *resp_len = occ->client_response_size;
Signature · 1 line
2.27.0
Eddie James
maintainerPATCH v2 2/2 hwmon (occ): Retry for checksum failure
In reply to Eddie JamesDue to the OCC communication design with a shared SRAM area, checkum errors are expected due to corrupted buffer from OCC communications with other system components. Therefore, retry the command twice in the event of a checksum failure.
--- drivers/hwmon/occ/p9_sbe.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-)
drivers/hwmon/occ/p9_sbe.c +11 -4
@@ -14,6 +14,8 @@#include "common.h" +#define OCC_CHECKSUM_RETRIES 3 +struct p9_sbe_occ {struct occ occ;bool sbe_error;
@@ -83,17 +85,22 @@ static int p9_sbe_occ_send_cmd(struct occ *occ, u8 *cmd, size_t len)struct occ_response *resp = &occ->resp;struct p9_sbe_occ *ctx =to_p9_sbe_occ (occ);size_t resp_len =sizeof (*resp); +int i;int rc; - rc =fsi_occ_submit (ctx->sbe, cmd, len, resp, &resp_len); -if (rc <0 ) { +for (i =0 ; i <OCC_CHECKSUM_RETRIES ; ++i) { + rc =fsi_occ_submit (ctx->sbe, cmd, len, resp, &resp_len); +if (rc >=0 ) +break ;if (resp_len) {if (p9_sbe_occ_save_ffdc (ctx, resp, resp_len))sysfs_notify (&occ->bus_dev->kobj,NULL , bin_attr_ffdc.attr.name); - } -return rc; +return rc; + } +if (rc != -EBADE ) +return rc; }switch (resp->return_status) {
Signature · 1 line
2.27.0
Re: [PATCH v2 2/2] hwmon (occ): Retry for checksum failure
Quoted 39 lines · Eddie James
Due to the OCC communication design with a shared SRAM area, checkum errors are expected due to corrupted buffer from OCC communications with other system components. Therefore, retry the command twice in the event of a checksum failure.
Signed-off-by Eddie James <[email protected]>Acked-by Guenter Roeck <[email protected]>--- drivers/hwmon/occ/p9_sbe.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-)drivers/hwmon/occ/p9_sbe.c +7
-2@@ -14,6 +14,8 @@#include "common.h" +#define OCC_CHECKSUM_RETRIES 3 +struct p9_sbe_occ {struct occ occ;bool sbe_error;@@ -83,17 +85,22 @@ static int p9_sbe_occ_send_cmd(struct occ *occ, u8 *cmd, size_t len)struct occ_response *resp = &occ->resp;struct p9_sbe_occ *ctx =to_p9_sbe_occ (occ);size_t resp_len =sizeof (*resp); +int i;int rc; - rc =fsi_occ_submit (ctx->sbe, cmd, len, resp, &resp_len); -if (rc <0 ) { +for (i =0 ; i <OCC_CHECKSUM_RETRIES ; ++i) { + rc =fsi_occ_submit (ctx->sbe, cmd, len, resp, &resp_len); +if (rc >=0 ) +break ;if (resp_len) {
drivers/hwmon/occ/p9_sbe.c static int p9_sbe_occ_send_cmd(struct occ *occ, u8 *cmd, size_t len) · line 103
Quoted 10 lines
drivers/hwmon/occ/p9_sbe.c +4
-2if (p9_sbe_occ_save_ffdc (ctx, resp, resp_len))sysfs_notify (&occ->bus_dev->kobj,NULL , bin_attr_ffdc.attr.name); - } -return rc; +return rc; + } +if (rc != -EBADE ) +return rc;
Future you might appreciate a comment above the EBADE check clarifying why that error is being special cased.
Quoted 6 lines
drivers/hwmon/occ/p9_sbe.c +0
-1}switch (resp->return_status) { --2.27.0