Skip to contentSkip to conversation

dt-bindings: media: mtk-vcodec: Adds encoder power domain property

PATCH In review Irui Wang 2 participants 3 messages Apr 27, 2022

Subsystems (4)
lore
Share & tools
lore

Irui Wang

author
#0 lore raw

PATCH v2 1/1 dt-bindings: media: mtk-vcodec: Adds encoder power domain property

Adds encoder power domain property.

---
changes compared with v1:
- set "power-domains" as a non-required property

The 'make dtbs_check' warnings('mediatek,larb') can be fixed by patch:
https://patchwork.kernel.org/project/linux-mediatek/list/?series=633993

---
 .../devicetree/bindings/media/mediatek,vcodec-encoder.yaml  | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml +6 -0
index deb5b657a2d5..2d1e0c9bd6ee 100644
@@ -41,6 +41,9 @@ properties:
 
   assigned-clock-parents: true
 
+  power-domains:
+    maxItems: 1
+
   iommus:
     minItems: 1
     maxItems: 32
@@ -132,6 +135,7 @@ examples:
     #include <dt-bindings/clock/mt8173-clk.h>
     #include <dt-bindings/memory/mt8173-larb-port.h>
     #include <dt-bindings/interrupt-controller/irq.h>
+    #include <dt-bindings/power/mt8173-power.h>
 
     vcodec_enc_avc: vcodec@18002000 {
       compatible = "mediatek,mt8173-vcodec-enc";
@@ -153,6 +157,7 @@ examples:
       clock-names = "venc_sel";
       assigned-clocks = <&topckgen CLK_TOP_VENC_SEL>;
       assigned-clock-parents = <&topckgen CLK_TOP_VCODECPLL>;
+      power-domains = <&scpsys MT8173_POWER_DOMAIN_VENC>;
     };
 
     vcodec_enc_vp8: vcodec@19002000 {
@@ -173,4 +178,5 @@ examples:
       clock-names = "venc_lt_sel";
       assigned-clocks = <&topckgen CLK_TOP_VENC_LT_SEL>;
       assigned-clock-parents = <&topckgen CLK_TOP_VCODECPLL_370P5>;
+      power-domains = <&scpsys MT8173_POWER_DOMAIN_VENC_LT>;
     };
Signature · 1 line
2.18.0
#1 lore raw

Hi Irui,

I'm merging this patch from Nícolas F. R. A. Prado, which has already been Acked by Rob:

https://patchwork.linuxtv.org/project/linux-media/patch/[email protected]/

If you still want the other changes you made in this patch merged, then please make a v3 on top of Nícolas' patch.

Regards,

Hans

Quoted 49 lines · Irui Wang

Adds encoder power domain property.

---
changes compared with v1:
- set "power-domains" as a non-required property

The 'make dtbs_check' warnings('mediatek,larb') can be fixed by patch:
https://patchwork.kernel.org/project/linux-mediatek/list/?series=633993

---
 .../devicetree/bindings/media/mediatek,vcodec-encoder.yaml  | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml +6 -0
index deb5b657a2d5..2d1e0c9bd6ee 100644
@@ -41,6 +41,9 @@ properties:
 
   assigned-clock-parents: true
 
+  power-domains:
+    maxItems: 1
+
   iommus:
     minItems: 1
     maxItems: 32
@@ -132,6 +135,7 @@ examples:
     #include <dt-bindings/clock/mt8173-clk.h>
     #include <dt-bindings/memory/mt8173-larb-port.h>
     #include <dt-bindings/interrupt-controller/irq.h>
+    #include <dt-bindings/power/mt8173-power.h>
 
     vcodec_enc_avc: vcodec@18002000 {
       compatible = "mediatek,mt8173-vcodec-enc";
@@ -153,6 +157,7 @@ examples:
       clock-names = "venc_sel";
       assigned-clocks = <&topckgen CLK_TOP_VENC_SEL>;
       assigned-clock-parents = <&topckgen CLK_TOP_VCODECPLL>;
+      power-domains = <&scpsys MT8173_POWER_DOMAIN_VENC>;
     };
 
     vcodec_enc_vp8: vcodec@19002000 {
@@ -173,4 +178,5 @@ examples:
       clock-names = "venc_lt_sel";
       assigned-clocks = <&topckgen CLK_TOP_VENC_LT_SEL>;
       assigned-clock-parents = <&topckgen CLK_TOP_VCODECPLL_370P5>;
+      power-domains = <&scpsys MT8173_POWER_DOMAIN_VENC_LT>;
     };
author
#2 lore raw

Dear Hans,

Quoted 6 lines · Hans Verkuil

Hi Irui,

I'm merging this patch from Nícolas F. R. A. Prado, which has already been Acked by Rob:

https://patchwork.linuxtv.org/project/linux-media/patch/[email protected]/

Quoted 4 lines

If you still want the other changes you made in this patch merged, then please make
a v3 on top of Nícolas' patch.

Thanks for your information and Nícolas' patch, we will check it and would send a v3 patch if needed.

Thanks
Best Regards.

Quoted 16 lines

Regards,

Hans

Quoted 10 lines · Irui Wang

Adds encoder power domain property.

---
changes compared with v1:
- set "power-domains" as a non-required property

The 'make dtbs_check' warnings('mediatek,larb') can be fixed by patch:

https://patchwork.kernel.org/project/linux-mediatek/list/?series=633993

Quoted 50 lines
Quoted 48 lines
---
 .../devicetree/bindings/media/mediatek,vcodec-encoder.yaml  | 6
++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec- encoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec- encoder.yaml
index deb5b657a2d5..2d1e0c9bd6ee 100644
--- a/Documentation/devicetree/bindings/media/mediatek,vcodec- encoder.yaml
+++ b/Documentation/devicetree/bindings/media/mediatek,vcodec- encoder.yaml

Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml +6 -0
@@ -41,6 +41,9 @@ properties:
 
   assigned-clock-parents: true
 
+  power-domains:
+    maxItems: 1
+
   iommus:
     minItems: 1
     maxItems: 32
@@ -132,6 +135,7 @@ examples:
     #include <dt-bindings/clock/mt8173-clk.h>
     #include <dt-bindings/memory/mt8173-larb-port.h>
     #include <dt-bindings/interrupt-controller/irq.h>
+    #include <dt-bindings/power/mt8173-power.h>
 
     vcodec_enc_avc: vcodec@18002000 {
       compatible = "mediatek,mt8173-vcodec-enc";
@@ -153,6 +157,7 @@ examples:
       clock-names = "venc_sel";
       assigned-clocks = <&topckgen CLK_TOP_VENC_SEL>;
       assigned-clock-parents = <&topckgen CLK_TOP_VCODECPLL>;
+      power-domains = <&scpsys MT8173_POWER_DOMAIN_VENC>;
     };
 
     vcodec_enc_vp8: vcodec@19002000 {
@@ -173,4 +178,5 @@ examples:
       clock-names = "venc_lt_sel";
       assigned-clocks = <&topckgen CLK_TOP_VENC_LT_SEL>;
       assigned-clock-parents = <&topckgen
 CLK_TOP_VCODECPLL_370P5>;
+      power-domains = <&scpsys MT8173_POWER_DOMAIN_VENC_LT>;
     };