package/wilc-driver: add missing BR2_LINUX_KERNEL dependency
PATCH v2 1/1 package/wilc-driver: add missing BR2_LINUX_KERNEL dependency
Fixes:
- http://autobuild.buildroot.net/results/40b/40b8aa0c19917f64c3f272f5479068e7631ffcc3
---
Changes v1 -> v2:
- add comment when !BR2_LINUX_KERNEL
--- package/wilc-driver/Config.in | 4 ++++ 1 file changed, 4 insertions(+)
package/wilc-driver/Config.in +4 -0
@@ -1,5 +1,6 @@ config BR2_PACKAGE_WILC_DRIVER bool "wilc kernel module" + depends on BR2_LINUX_KERNEL help External kernel module for WILC1000/3000 devices.
@@ -16,6 +17,9 @@ config BR2_PACKAGE_WILC_DRIVER https://github.com/embeddedTS/wilc3000-external-module +comment "wilc kernel module needs a Linux kernel to be built" + depends on !BR2_LINUX_KERNEL + if BR2_PACKAGE_WILC_DRIVER config BR2_PACKAGE_WILC_DRIVER_SPI
Signature · 6 lines
2.25.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Quoted 23 lines · James Hilliard
Fixes:
- http://autobuild.buildroot.net/results/40b/40b8aa0c19917f64c3f272f5479068e7631ffcc3Signed-off-by James Hilliard <[email protected]>---
Changes v1 -> v2:
- add comment when !BR2_LINUX_KERNEL--- package/wilc-driver/Config.in | 4 ++++ 1 file changed, 4 insertions(+)package/wilc-driver/Config.in +1
-0@@ -1,5 +1,6 @@ config BR2_PACKAGE_WILC_DRIVER bool "wilc kernel module" + depends on BR2_LINUX_KERNEL help External kernel module for WILC1000/3000 devices.
package/wilc-driver/Config.in config BR2_PACKAGE_WILC_DRIVER · line 25
Quoted 9 lines
package/wilc-driver/Config.in +3
-0@@ -16,6 +17,9 @@ config BR2_PACKAGE_WILC_DRIVER https://github.com/embeddedTS/wilc3000-external-module +comment "wilc kernel module needs a Linux kernel to be built" + depends on !BR2_LINUX_KERNEL + if BR2_PACKAGE_WILC_DRIVER config BR2_PACKAGE_WILC_DRIVER_SPI
I also just wanted to note that this driver in this form has only ever been tested on AT91 and i.MX6UL ARM platforms. It may work on other architectures, but we've not got any hardware setup for that. I'm not sure if this fact would warrant a depends on ARM architecture for now to limit scope or to leave it open for others to test.
As-is, the patch looks good to me though.
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Arnout Vandecappelle
AppliedQuoted 4 lines · James Hilliard
Fixes:
- http://autobuild.buildroot.net/results/40b/40b8aa0c19917f64c3f272f5479068e7631ffcc3Signed-off-by James Hilliard <[email protected]>
Applied to master, thanks.
Regards,
Arnout
Quoted 19 lines
---
Changes v1 -> v2:
- add comment when !BR2_LINUX_KERNEL--- package/wilc-driver/Config.in | 4 ++++ 1 file changed, 4 insertions(+)package/wilc-driver/Config.in +1
-0@@ -1,5 +1,6 @@ config BR2_PACKAGE_WILC_DRIVER bool "wilc kernel module" + depends on BR2_LINUX_KERNEL help External kernel module for WILC1000/3000 devices.
package/wilc-driver/Config.in config BR2_PACKAGE_WILC_DRIVER · line 25
Quoted 9 lines
package/wilc-driver/Config.in +3
-0@@ -16,6 +17,9 @@ config BR2_PACKAGE_WILC_DRIVER https://github.com/embeddedTS/wilc3000-external-module +comment "wilc kernel module needs a Linux kernel to be built" + depends on !BR2_LINUX_KERNEL + if BR2_PACKAGE_WILC_DRIVER config BR2_PACKAGE_WILC_DRIVER_SPI
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot