Add unit test module for AMD P-State driver
v4 cover Add unit test module for AMD P-State driver
Hi all:
AMD P-State unit test(amd-pstate-ut) is a kernel module for testing the functions of amd-pstate driver.
It could import as a module to launch some test tasks.
1) It can help all users to verify their processor support (SBIOS/ Firmware or Hardware).
2) Kernel can have a basic function test to avoid the kernel regression during the update.
3) We can introduce more functional or performance tests to align the together, it will benefit power and performance scale optimization.
We upstream out AMD P-state driver into Linux kernel and use this unit test module to verify the required conditions and basic functions of amd-pstate before integration test.
We use test module in the kselftest frameworks to implement it. We create amd-pstate-ut module and tie it into kselftest.
For example: The test case aput_acpi_cpc is used to check whether the _CPC object is exist in SBIOS.
The amd-pstate initialization will fail if the _CPC in ACPI SBIOS is not existed at the detected processor, so it is a necessary condition.
At present, it only implements the basic framework and some simple test cases.
TODO : 1) we will add more test cases to improve the depth and coverage of the test.
Please check the documentation amd-pstate.rst for details of the test steps.
See patch series in below git repo:
V1: https://lore.kernel.org/linux-pm/[email protected]/
V2: https://lore.kernel.org/lkml/[email protected]/
V3: https://lore.kernel.org/lkml/[email protected]/
Changes from V1 -> V2:
- cpufreq: amd-pstate:
- - add a trailing of amd-pstate.h to MAINTAINER AMD PSTATE DRIVER.
- selftests: cpufreq:
- - add a wrapper shell script for the amd_pstate_testmod module.
- selftests: cpufreq:
- - remove amd_pstate_testmod kernel module to .../cpufreq/amd_pstate_testmod.
- Documentation: amd-pstate:
- - amd_pstate_testmod rst document is not provided at present.
Changes from V2 -> V3:
- cpufreq: amd-pstate:
- - adjust the order of add amd-pstate.h in MAINTAINERS.
- selftests: cpufreq:
- - remove the call of amd_pstate_testmod.sh from cpufreq Makefile to main.sh.
- selftests: cpufreq:
- - add explain the goal or intention of the AMD P-State Unit Test module.
- - modify comments.
- - use the checkpatch.pl to check my patches.
- - add conditions judgment before formal test.
- - delete some unnecessary test cases.
- - modify test cases about perf and performance etc.
Changes from V3 -> V4:
- selftests: amd-pstate:
- - remove script and test module to tools/testing/selftests/amd-pstate/
- - uniformly named amd-pstate-ut.
- - check current architectures and cpufreq driver in amd-pstate-ut.sh
- - delete codes about conditions in amd-pstate-ut.c
- Documentation: amd-pstate:
- - add introduce document about amd-pstate unit test.
Thanks,
Jasmine
Meng Li (3):
cpufreq: amd-pstate: Expose struct amd_cpudata
selftests: amd-pstate: Add test module for amd-pstate driver
Documentation: amd-pstate: Add unit test introduction
Documentation/admin-guide/pm/amd-pstate.rst | 87 ++++++ MAINTAINERS | 1 + drivers/cpufreq/amd-pstate.c | 60 +--- include/linux/amd-pstate.h | 77 +++++ tools/testing/selftests/Makefile | 1 + tools/testing/selftests/amd-pstate/Makefile | 9 + .../selftests/amd-pstate/amd-pstate-ut.sh | 27 ++ .../amd-pstate/amd-pstate-ut/Makefile | 20 ++ .../amd-pstate/amd-pstate-ut/amd-pstate-ut.c | 275 ++++++++++++++++++ tools/testing/selftests/amd-pstate/config | 1 + 10 files changed, 499 insertions(+), 59 deletions(-) create mode 100644 include/linux/amd-pstate.h create mode 100644 tools/testing/selftests/amd-pstate/Makefile create mode 100755 tools/testing/selftests/amd-pstate/amd-pstate-ut.sh create mode 100644 tools/testing/selftests/amd-pstate/amd-pstate-ut/Makefile create mode 100644 tools/testing/selftests/amd-pstate/amd-pstate-ut/amd-pstate-ut.c create mode 100644 tools/testing/selftests/amd-pstate/config
Signature · 1 line
2.25.1
PATCH v4 1/3 cpufreq: amd-pstate: Expose struct amd_cpudata
Expose struct amd_cpudata to AMD P-State unit test module.
This data struct will be used on the following AMD P-State unit test (amd-pstate-ut) module. The amd-pstate-ut module can get some AMD infomations by this data struct. For example: highest perf, nominal perf, boost supported etc.
--- MAINTAINERS | 1 + drivers/cpufreq/amd-pstate.c | 60 +--------------------------- include/linux/amd-pstate.h | 77 ++++++++++++++++++++++++++++++++++++ 3 files changed, 79 insertions(+), 59 deletions(-) create mode 100644 include/linux/amd-pstate.h
MAINTAINERS +1 -0
@@ -1020,6 +1020,7 @@ L: [email protected] S: Supported F: Documentation/admin-guide/pm/amd-pstate.rst F: drivers/cpufreq/amd-pstate* +F: include/linux/amd-pstate.h F: tools/power/x86/amd_pstate_tracer/amd_pstate_trace.py AMD PTDMA DRIVER
drivers/cpufreq/amd-pstate.c +1 -59
72 lines not on this page · raw message
include/linux/amd-pstate.h new file +77 -0
77 lines not on this page · raw message
Signature · 1 line
2.25.1
Re: [PATCH V4 1/3] cpufreq: amd-pstate: Expose struct amd_cpudata
Hi Li,
Quoted 8 lines · Li (Jassmine)
Expose struct
amd_cpudatato AMD P-State unit test module.This data struct will be used on the following AMD P-State unit test (amd-pstate-ut) module. The amd-pstate-ut module can get some AMD infomations by this data struct. For example: highest perf, nominal perf, boost supported etc.
Signed-off-by Meng Li <[email protected]>
I have acked this patch at the last version.
Next time you can add my Ack here directly.
Quoted 183 lines
--- MAINTAINERS | 1 + drivers/cpufreq/amd-pstate.c | 60 +--------------------------- include/linux/amd-pstate.h | 77 ++++++++++++++++++++++++++++++++++++ 3 files changed, 79 insertions(+), 59 deletions(-) create mode 100644 include/linux/amd-pstate.hMAINTAINERS +1
-0@@ -1020,6 +1020,7 @@ L: [email protected] S: Supported F: Documentation/admin-guide/pm/amd-pstate.rst F: drivers/cpufreq/amd-pstate* +F: include/linux/amd-pstate.h F: tools/power/x86/amd_pstate_tracer/amd_pstate_trace.py AMD PTDMA DRIVERdrivers/cpufreq/amd-pstate.c +1
-59@@ -36,6 +36,7 @@#include <linux/delay.h> #include <linux/uaccess.h> #include <linux/static_call.h> +#include <linux/amd-pstate.h> #include <acpi/processor.h> #include <acpi/cppc_acpi.h> @@ -65,65 +66,6 @@ MODULE_PARM_DESC(shared_mem,static struct cpufreq_driver amd_pstate_driver; -/** -* struct amd_aperf_mperf -* @aperf: actual performance frequency clock count -* @mperf: maximum performance frequency clock count -* @tsc: time stamp counter -*/ -struct amd_aperf_mperf { -u64 aperf; -u64 mperf; -u64 tsc; -}; - -/** -* struct amd_cpudata - private CPU data for AMD P-State -* @cpu: CPU number -* @req: constraint request to apply -* @cppc_req_cached: cached performance request hints -* @highest_perf: the maximum performance an individual processor may reach, -* assuming ideal conditions -* @nominal_perf: the maximum sustained performance level of the processor, -* assuming ideal operating conditions -* @lowest_nonlinear_perf: the lowest performance level at which nonlinear power -* savings are achieved -* @lowest_perf: the absolute lowest performance level of the processor -* @max_freq: the frequency that mapped to highest_perf -* @min_freq: the frequency that mapped to lowest_perf -* @nominal_freq: the frequency that mapped to nominal_perf -* @lowest_nonlinear_freq: the frequency that mapped to lowest_nonlinear_perf -* @cur: Difference of Aperf/Mperf/tsc count between last and current sample -* @prev: Last Aperf/Mperf/tsc count value read from register -* @freq: current cpu frequency value -* @boost_supported: check whether the Processor or SBIOS supports boost mode -* -* The amd_cpudata is key private data for each CPU thread in AMD P-State, and -* represents all the attributes and goals that AMD P-State requests at runtime. -*/ -struct amd_cpudata { -int cpu; - -struct freq_qos_request req[2 ]; -u64 cppc_req_cached; - -u32 highest_perf; -u32 nominal_perf; -u32 lowest_nonlinear_perf; -u32 lowest_perf; - -u32 max_freq; -u32 min_freq; -u32 nominal_freq; -u32 lowest_nonlinear_freq; - -struct amd_aperf_mperf cur; -struct amd_aperf_mperf prev; - -u64 freq; -bool boost_supported; -}; -static inline int pstate_enable (bool enable) {return wrmsrl_safe (MSR_AMD_CPPC_ENABLE , enable);include/linux/amd-pstate.h new file +77
-0@@ -0,0 +1,77 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* +* linux/include/linux/amd-pstate.h +* +* Copyright (C) 2007-2010 Advanced Micro Devices, Inc. +* +* Author: Meng Li <[email protected]> +*/ + +#ifndef _LINUX_AMD_PSTATE_H +#define _LINUX_AMD_PSTATE_H + +#include <linux/pm_qos.h> + +/********************************************************************* +* AMD P-state INTERFACE * +*********************************************************************/ +/** +* struct amd_aperf_mperf +* @aperf: actual performance frequency clock count +* @mperf: maximum performance frequency clock count +* @tsc: time stamp counter +*/ +struct amd_aperf_mperf { +u64 aperf; +u64 mperf; +u64 tsc; +}; + +/** +* struct amd_cpudata - private CPU data for AMD P-State +* @cpu: CPU number +* @req: constraint request to apply +* @cppc_req_cached: cached performance request hints +* @highest_perf: the maximum performance an individual processor may reach, +* assuming ideal conditions +* @nominal_perf: the maximum sustained performance level of the processor, +* assuming ideal operating conditions +* @lowest_nonlinear_perf: the lowest performance level at which nonlinear power +* savings are achieved +* @lowest_perf: the absolute lowest performance level of the processor +* @max_freq: the frequency that mapped to highest_perf +* @min_freq: the frequency that mapped to lowest_perf +* @nominal_freq: the frequency that mapped to nominal_perf +* @lowest_nonlinear_freq: the frequency that mapped to lowest_nonlinear_perf +* @cur: Difference of Aperf/Mperf/tsc count between last and current sample +* @prev: Last Aperf/Mperf/tsc count value read from register +* @freq: current cpu frequency value +* @boost_supported: check whether the Processor or SBIOS supports boost mode +* +* The amd_cpudata is key private data for each CPU thread in AMD P-State, and +* represents all the attributes and goals that AMD P-State requests at runtime. +*/ +struct amd_cpudata { +int cpu; + +struct freq_qos_request req[2 ]; +u64 cppc_req_cached; + +u32 highest_perf; +u32 nominal_perf; +u32 lowest_nonlinear_perf; +u32 lowest_perf; + +u32 max_freq; +u32 min_freq; +u32 nominal_freq; +u32 lowest_nonlinear_freq; + +struct amd_aperf_mperf cur; +struct amd_aperf_mperf prev; + +u64 freq; +bool boost_supported; +}; + +#endif /* _LINUX_AMD_PSTATE_H */ Signature · 1 line
2.25.1
PATCH v4 2/3 selftests: amd-pstate: Add test module for amd-pstate driver
In reply to Meng LiAdd amd-pstate-ut module, which is conceptually out-of-tree module and provides ways for selftests/amd-pstate driver to test various kernel module-related functionality. This module will be expected by some of selftests to be present and loaded.
--- tools/testing/selftests/Makefile | 1 + tools/testing/selftests/amd-pstate/Makefile | 9 + .../selftests/amd-pstate/amd-pstate-ut.sh | 27 ++ .../amd-pstate/amd-pstate-ut/Makefile | 20 ++ .../amd-pstate/amd-pstate-ut/amd-pstate-ut.c | 275 ++++++++++++++++++ tools/testing/selftests/amd-pstate/config | 1 + 6 files changed, 333 insertions(+) create mode 100644 tools/testing/selftests/amd-pstate/Makefile create mode 100755 tools/testing/selftests/amd-pstate/amd-pstate-ut.sh create mode 100644 tools/testing/selftests/amd-pstate/amd-pstate-ut/Makefile create mode 100644 tools/testing/selftests/amd-pstate/amd-pstate-ut/amd-pstate-ut.c create mode 100644 tools/testing/selftests/amd-pstate/config
tools/testing/selftests/Makefile +1 -0
@@ -1,5 +1,6 @@ # SPDX-License-Identifier: GPL-2.0 TARGETS += alsa +TARGETS += amd-pstate TARGETS += arm64 TARGETS += bpf TARGETS += breakpoints
tools/testing/selftests/amd-pstate/Makefile new file +9 -0
@@ -0,0 +1,9 @@ +# SPDX-License-Identifier: GPL-2.0-only +# Makefile for amd-pstate/ function selftests + +# No binaries, but make sure arg-less "make" doesn't trigger "run_tests" +all: + +TEST_PROGS := amd-pstate-ut.sh + +include ../lib.mk
tools/testing/selftests/amd-pstate/amd-pstate-ut.sh new file +27 -0
@@ -0,0 +1,27 @@ +#!/bin/sh +# SPDX-License-Identifier: GPL-2.0 + +# amd-pstate-ut is a test module for testing the amd-pstate driver. +# (1) It can help all users to verify their processor support +# (SBIOS/Firmware or Hardware). +# (2) Kernel can have a basic function test to avoid the kernel +# regression during the update. +# (3) We can introduce more functional or performance tests to align +# the result together, it will benefit power and performance scale optimization. + +# Kselftest framework requirement - SKIP code is 4. +ksft_skip=4 + +if ! uname -m | sed -e s/i.86/x86/ -e s/x86_64/x86/ | grep -q x86; then + echo "$0 # Skipped: Test can only run on x86 architectures." + exit $ksft_skip +fi + +scaling_driver=$(cat /sys/devices/system/cpu/cpufreq/policy0/scaling_driver) + +if [ "$scaling_driver" != "amd-pstate" ]; then + echo "$0 # Skipped: Test can only run on amd-pstate driver." + exit $ksft_skip +fi + +$(dirname $0)/../kselftest/module.sh "amd-pstate-ut" amd-pstate-ut
tools/testing/selftests/amd-pstate/amd-pstate-ut/Makefile new file +20 -0
@@ -0,0 +1,20 @@ +AMD_PSTATE_UT_DIR := $(realpath $(dir $(abspath $(lastword $(MAKEFILE_LIST))))) +KDIR ?= $(abspath $(AMD_PSATE_UT_DIR)/../../../../..) + +ifeq ($(V),1) +Q = +else +Q = @ +endif + +MODULES = amd-pstate-ut.ko + +obj-m += amd-pstate-ut.o +CFLAGS_amd-pstate-ut.o = -I$(src) + +all: + +$(Q)make -C $(KDIR) M=$(AMD_PSTATE_UT_DIR) modules + +clean: + +$(Q)make -C $(KDIR) M=$(AMD_PSTATE_UT_DIR) clean +
tools/testing/selftests/amd-pstate/amd-pstate-ut/amd-pstate-ut.c new file +275 -0
275 lines not on this page · raw message
tools/testing/selftests/amd-pstate/config new file +1 -0
@@ -0,0 +1 @@ +CONFIG_X86_AMD_PSTATE_UT=m
Signature · 1 line
2.25.1
Huang Rui
maintainerRe: [PATCH V4 2/3] selftests: amd-pstate: Add test module for amd-pstate driver
Quoted 65 lines · Li (Jassmine)
Add amd-pstate-ut module, which is conceptually out-of-tree module and provides ways for selftests/amd-pstate driver to test various kernel module-related functionality. This module will be expected by some of selftests to be present and loaded.
Signed-off-by Meng Li <[email protected]>--- tools/testing/selftests/Makefile | 1 + tools/testing/selftests/amd-pstate/Makefile | 9 + .../selftests/amd-pstate/amd-pstate-ut.sh | 27 ++ .../amd-pstate/amd-pstate-ut/Makefile | 20 ++ .../amd-pstate/amd-pstate-ut/amd-pstate-ut.c | 275 ++++++++++++++++++ tools/testing/selftests/amd-pstate/config | 1 + 6 files changed, 333 insertions(+) create mode 100644 tools/testing/selftests/amd-pstate/Makefile create mode 100755 tools/testing/selftests/amd-pstate/amd-pstate-ut.sh create mode 100644 tools/testing/selftests/amd-pstate/amd-pstate-ut/Makefile create mode 100644 tools/testing/selftests/amd-pstate/amd-pstate-ut/amd-pstate-ut.c create mode 100644 tools/testing/selftests/amd-pstate/configtools/testing/selftests/Makefile +1
-0@@ -1,5 +1,6 @@ # SPDX-License-Identifier: GPL-2.0 TARGETS += alsa +TARGETS += amd-pstate TARGETS += arm64 TARGETS += bpf TARGETS += breakpointstools/testing/selftests/amd-pstate/Makefile new file +9
-0@@ -0,0 +1,9 @@ +# SPDX-License-Identifier: GPL-2.0-only +# Makefile for amd-pstate/ function selftests + +# No binaries, but make sure arg-less "make" doesn't trigger "run_tests" +all: + +TEST_PROGS := amd-pstate-ut.sh + +include ../lib.mktools/testing/selftests/amd-pstate/amd-pstate-ut.sh new file +13
-0@@ -0,0 +1,27 @@ +#!/bin/sh +# SPDX-License-Identifier: GPL-2.0 + +# amd-pstate-ut is a test module for testing the amd-pstate driver. +# (1) It can help all users to verify their processor support +# (SBIOS/Firmware or Hardware). +# (2) Kernel can have a basic function test to avoid the kernel +# regression during the update. +# (3) We can introduce more functional or performance tests to align +# the result together, it will benefit power and performance scale optimization. + +# Kselftest framework requirement - SKIP code is 4. +ksft_skip=4
tools/testing/selftests/amd-pstate/amd-pstate-ut.sh line 23
Quoted 10 lines
tools/testing/selftests/amd-pstate/amd-pstate-ut.sh new file +10
-0+ +if ! uname -m | sed -e s/i.86/x86/ -e s/x86_64/x86/ | grep -q x86; then + echo "$0 # Skipped: Test can only run on x86 architectures." + exit $ksft_skip +fi + +scaling_driver=$(cat /sys/devices/system/cpu/cpufreq/policy0/scaling_driver) + +if [ "$scaling_driver" != "amd-pstate" ]; then + echo "$0 # Skipped: Test can only run on amd-pstate driver."
Maybe it's better to print the current scaling_driver which is running here.
tools/testing/selftests/amd-pstate/amd-pstate-ut.sh line 19
Quoted 3 lines
tools/testing/selftests/amd-pstate/amd-pstate-ut.sh new file +3
-0+ exit $ksft_skip +fi +
Can we add load the amd-pstate-ut test module in the script?
Quoted 99 lines
tools/testing/selftests/amd-pstate/amd-pstate-ut.sh new file +1
-0+$(dirname $0)/../kselftest/module.sh "amd-pstate-ut" amd-pstate-uttools/testing/selftests/amd-pstate/amd-pstate-ut/Makefile new file +20
-0@@ -0,0 +1,20 @@ +AMD_PSTATE_UT_DIR := $(realpath $(dir $(abspath $(lastword $(MAKEFILE_LIST))))) +KDIR ?= $(abspath $(AMD_PSATE_UT_DIR)/../../../../..) + +ifeq ($(V),1) +Q = +else +Q = @ +endif + +MODULES = amd-pstate-ut.ko + +obj-m += amd-pstate-ut.o +CFLAGS_amd-pstate-ut.o = -I$(src) + +all: + +$(Q)make -C $(KDIR) M=$(AMD_PSTATE_UT_DIR) modules + +clean: + +$(Q)make -C $(KDIR) M=$(AMD_PSTATE_UT_DIR) clean +tools/testing/selftests/amd-pstate/amd-pstate-ut/amd-pstate-ut.c new file +66
-0@@ -0,0 +1,275 @@ +// SPDX-License-Identifier: GPL-1.0-or-later +/* +* AMD Processor P-state Frequency Driver Unit Test +* +* Copyright (C) 2022 Advanced Micro Devices, Inc. All Rights Reserved. +* +* Author: Meng Li <[email protected]> +* +* The AMD P-State Unit Test is a test module for testing the amd-pstate +* driver. 1) It can help all users to verify their processor support +* (SBIOS/Firmware or Hardware). 2) Kernel can have a basic function +* test to avoid the kernel regression during the update. 3) We can +* introduce more functional or performance tests to align the result +* together, it will benefit power and performance scale optimization. +* +* At present, it only implements the basic framework and some simple +* test cases. Next, 1) we will add a rst document. 2) we will add more +* test cases to improve the depth and coverage of the test. +*/ + +#define pr_fmt (fmt) KBUILD_MODNAME ": " fmt + +#include "../../kselftest_module.h" + +#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/moduleparam.h> +#include <linux/fs.h> +#include <linux/amd-pstate.h> + +#include <acpi/cppc_acpi.h> + +/* +* Abbreviations: +* aput: used as a shortform for AMD P-State unit test. +* It helps to keep variable names smaller, simpler +*/ + +KSTM_MODULE_GLOBALS (); + +/* +* Kernel module for testing the AMD P-State unit test +*/ +enum aput_result { +APUT_RESULT_PASS , +APUT_RESULT_FAIL , +MAX_APUT_RESULT , +}; + +struct aput_struct { +const char *name; +void (*func)(u32 index); +enum aput_result result; +}; + +static void aput_acpi_cpc (u32 index); +static void aput_check_enabled (u32 index); +static void aput_check_perf (u32 index); +static void aput_check_freq (u32 index); + +static struct aput_struct aput_cases[] = { + {"acpi_cpc_valid" , aput_acpi_cpc }, + {"check_enabled" , aput_check_enabled }, + {"check_perf" , aput_check_perf }, + {"check_freq" , aput_check_freq } +};
tools/testing/selftests/amd-pstate/amd-pstate-ut/amd-pstate-ut.c line 76
Quoted 10 lines
tools/testing/selftests/amd-pstate/amd-pstate-ut/amd-pstate-ut.c new file +10
-0+ +static bool get_shared_mem (void ) +{ +bool result = false; +char buf[5 ] = {0 }; +struct file *filp =NULL ; +loff_t pos =0 ; +ssize_t ret; + + filp =filp_open ("/sys/module/amd_pstate/parameters/shared_mem" ,FMODE_PREAD ,0 );
We need to add a check of read back from X86_FEATURE_CPPC in case somebody set the "shared_mem" parameter on full MSR processors.
Others look good for me, thanks Li!
Thanks,
Ray
Quoted 209 lines
tools/testing/selftests/amd-pstate/amd-pstate-ut/amd-pstate-ut.c new file +199
-0+if (IS_ERR (filp)) +pr_err ("%s Open param file fail!\n" , __func__); +else { + ret =kernel_read (filp, &buf,sizeof (buf), &pos); +if (ret <0 ) +pr_err ("%s ret=%ld unable to read from param file!\n" , __func__, ret); +filp_close (filp,NULL ); + } + +if ('Y' == *buf) + result = true; + +return result; +} + +static void aput_acpi_cpc (u32 index) +{ +if (acpi_cpc_valid ()) + aput_cases[index].result =APUT_RESULT_PASS ; +else + aput_cases[index].result =APUT_RESULT_FAIL ; +} + +static void aput_pstate_enable (u32 index) +{ +int ret =0 ; +u64 cppc_enable =0 ; + + ret =rdmsrl_safe (MSR_AMD_CPPC_ENABLE , &cppc_enable); +if (ret) { + aput_cases[index].result =APUT_RESULT_FAIL ; +pr_err ("%s rdmsrl_safe MSR_AMD_CPPC_ENABLE ret=%d is error!\n" , __func__, ret); +return ; + } +if (cppc_enable) + aput_cases[index].result =APUT_RESULT_PASS ; +else + aput_cases[index].result =APUT_RESULT_FAIL ; +} + +/* +*Check if enabled amd pstate +*/ +static void aput_check_enabled (u32 index) +{ +if (get_shared_mem ()) + aput_cases[index].result =APUT_RESULT_PASS ; +else +aput_pstate_enable (index); +} + +/* +* Check if the each performance values are reasonable. +* highest_perf >= nominal_perf > lowest_nonlinear_perf > lowest_perf > 0 +*/ +static void aput_check_perf (u32 index) +{ +int cpu =0 , ret =0 ; +u32 highest_perf =0 , nominal_perf =0 , lowest_nonlinear_perf =0 , lowest_perf =0 ; +u64 cap1 =0 ; +struct cppc_perf_caps cppc_perf; +struct cpufreq_policy *policy =NULL ; +struct amd_cpudata *cpudata =NULL ; + + highest_perf =amd_get_highest_perf (); + +for_each_possible_cpu (cpu) { + policy =cpufreq_cpu_get (cpu); +if (!policy) +break ; + cpudata = policy->driver_data; + +if (get_shared_mem ()) { + ret =cppc_get_perf_caps (cpu, &cppc_perf); +if (ret) { + aput_cases[index].result =APUT_RESULT_FAIL ; +pr_err ("%s cppc_get_perf_caps ret=%d is error!\n" , __func__, ret); +return ; + } + + nominal_perf = cppc_perf.nominal_perf; + lowest_nonlinear_perf = cppc_perf.lowest_nonlinear_perf; + lowest_perf = cppc_perf.lowest_perf; + }else { + ret =rdmsrl_safe_on_cpu (cpu,MSR_AMD_CPPC_CAP1 , &cap1); +if (ret) { + aput_cases[index].result =APUT_RESULT_FAIL ; +pr_err ("%s read CPPC_CAP1 ret=%d is error!\n" , __func__, ret); +return ; + } + + nominal_perf =AMD_CPPC_NOMINAL_PERF (cap1); + lowest_nonlinear_perf =AMD_CPPC_LOWNONLIN_PERF (cap1); + lowest_perf =AMD_CPPC_LOWEST_PERF (cap1); + } + +if ((highest_perf !=READ_ONCE (cpudata->highest_perf)) || + (nominal_perf !=READ_ONCE (cpudata->nominal_perf)) || + (lowest_nonlinear_perf !=READ_ONCE (cpudata->lowest_nonlinear_perf)) || + (lowest_perf !=READ_ONCE (cpudata->lowest_perf))) { + aput_cases[index].result =APUT_RESULT_FAIL ; +pr_err ("%s cpu%d highest=%d %d nominal=%d %d lowest_nonlinear=%d %d lowest=%d %d are not equal!\n" , + __func__, cpu, highest_perf, cpudata->highest_perf, + nominal_perf, cpudata->nominal_perf, + lowest_nonlinear_perf, cpudata->lowest_nonlinear_perf, + lowest_perf, cpudata->lowest_perf); +return ; + } + +if (!((highest_perf >= nominal_perf) && + (nominal_perf > lowest_nonlinear_perf) && + (lowest_nonlinear_perf > lowest_perf) && + (lowest_perf >0 ))) { + aput_cases[index].result =APUT_RESULT_FAIL ; +pr_err ("%s cpu%d highest=%d nominal=%d lowest_nonlinear=%d lowest=%d have error!\n" , + __func__, cpu, highest_perf, nominal_perf, + lowest_nonlinear_perf, lowest_perf); +return ; + } + } + + aput_cases[index].result =APUT_RESULT_PASS ; +} + +/* +* Check if the each frequency values are reasonable. +* max_freq >= nominal_freq > lowest_nonlinear_freq > min_freq > 0 +* check max freq when set support boost mode. +*/ +static void aput_check_freq (u32 index) +{ +int cpu =0 ; +struct cpufreq_policy *policy =NULL ; +struct amd_cpudata *cpudata =NULL ; + +for_each_possible_cpu (cpu) { + policy =cpufreq_cpu_get (cpu); +if (!policy) +break ; + cpudata = policy->driver_data; + +if (!((cpudata->max_freq >= cpudata->nominal_freq) && + (cpudata->nominal_freq > cpudata->lowest_nonlinear_freq) && + (cpudata->lowest_nonlinear_freq > cpudata->min_freq) && + (cpudata->min_freq >0 ))) { + aput_cases[index].result =APUT_RESULT_FAIL ; +pr_err ("%s cpu%d max=%d nominal=%d lowest_nonlinear=%d min=%d have error!\n" , + __func__, cpu, cpudata->max_freq, cpudata->nominal_freq, + cpudata->lowest_nonlinear_freq, cpudata->min_freq); +return ; + } + +if (cpudata->min_freq != policy->min) { + aput_cases[index].result =APUT_RESULT_FAIL ; +pr_err ("%s cpu%d cpudata_min_freq=%d policy_min=%d have error!\n" , + __func__, cpu, cpudata->min_freq, policy->min); +return ; + } + +if (cpudata->boost_supported) { +if ((policy->max == cpudata->max_freq) || + (policy->max == cpudata->nominal_freq)) + aput_cases[index].result =APUT_RESULT_PASS ; +else { + aput_cases[index].result =APUT_RESULT_FAIL ; +pr_err ("%s cpu%d policy_max=%d cpu_max=%d cpu_nominal=%d have error!\n" , + __func__, cpu, policy->max, cpudata->max_freq, + cpudata->nominal_freq); +return ; + } + }else { + aput_cases[index].result =APUT_RESULT_FAIL ; +pr_err ("%s cpu%d not support boost!\n" , __func__, cpu); +return ; + } + } +} + +static void aput_do_test_case (void ) +{ +u32 i =0 , arr_size =ARRAY_SIZE (aput_cases); + +for (i =0 ; i < arr_size; i++) { +pr_info ("****** Begin %-5d\t %-20s\t ******\n" , i+1 , aput_cases[i].name); + aput_cases[i].func (i); +KSTM_CHECK_ZERO (aput_cases[i].result); +pr_info ("****** End %-5d\t %-20s\t ******\n" , i+1 , aput_cases[i].name); + } +} + +static void __init selftest (void ) +{ +aput_do_test_case (); +} + +KSTM_MODULE_LOADERS (amd_pstate_ut); +MODULE_AUTHOR ("Meng Li <[email protected]>" ); +MODULE_DESCRIPTION ("Unit test for AMD P-state driver" ); +MODULE_LICENSE ("GPL" );tools/testing/selftests/amd-pstate/config new file +1
-0@@ -0,0 +1 @@ +CONFIG_X86_AMD_PSTATE_UT=mSignature · 1 line
2.25.1
PATCH v4 3/3 Documentation: amd-pstate: Add unit test introduction
In reply to Meng LiIntroduce the AMD P-State unit test module design and implementation.
--- Documentation/admin-guide/pm/amd-pstate.rst | 87 +++++++++++++++++++++ 1 file changed, 87 insertions(+)
Documentation/admin-guide/pm/amd-pstate.rst +87 -0
@@ -182,6 +182,7 @@ to the ``struct sugov_cpu`` that the utilization update belongs to. Then, ``amd-pstate`` updates the desired performance according to the CPU scheduler assigned. +.. _processor_support: Processor Support =======================
@@ -282,6 +283,8 @@ efficiency frequency management method on AMD processors. Kernel Module Options for ``amd-pstate`` ========================================= +.. _shared_mem: + ``shared_mem`` Use a module param (shared_mem) to enable related processors manually with **amd_pstate.shared_mem=1**.
@@ -393,6 +396,87 @@ about part of the output. :: CPU_005 712 116384 39 49 166 0.7565 9645075 2214891 38431470 25.1 11.646 469 2.496 kworker/5:0-40 CPU_006 712 116408 39 49 166 0.6769 8950227 1839034 37192089 24.06 11.272 470 2.496 kworker/6:0-1264 +Unit Tests for amd-pstate +------------------------- + +``amd-pstate-ut`` is a test module for testing the ``amd-pstate`` driver. + + * It can help all users to verify their processor support (SBIOS/Firmware or Hardware). + + * Kernel can have a basic function test to avoid the kernel regression during the update. + + * We can introduce more functional or performance tests to align the result together, it will benefit power and performance scale optimization. + +1. Test case decriptions + + +---------+--------------------------------+------------------------------------------------------------------------------------+ + | Index | Functions | Description | + +=========+================================+====================================================================================+ + | 0 | aput_acpi_cpc || Check whether the _CPC object is present in SBIOS. | + | | || | + | | || The detail refer to `Processor Support <processor_support_>`_. | + +---------+--------------------------------+------------------------------------------------------------------------------------+ + | 1 | aput_check_enabled || Check whether AMD P-State is enabled. | + | | || | + | | || AMD P-States and ACPI hardware P-States always can be supported in one processor. | + | | | But AMD P-States has the higher priority and if it is enabled with | + | | | :c:macro:`MSR_AMD_CPPC_ENABLE` or ``cppc_set_enable``, it will respond to the | + | | | request from AMD P-States. | + +---------+--------------------------------+------------------------------------------------------------------------------------+ + | 2 | aput_check_perf || Check if the each performance values are reasonable. | + | | || highest_perf >= nominal_perf > lowest_nonlinear_perf > lowest_perf > 0. | + +---------+--------------------------------+------------------------------------------------------------------------------------+ + | 3 | aput_check_freq || Check if the each frequency values and max freq when set support boost mode | + | | | are reasonable. | + | | || max_freq >= nominal_freq > lowest_nonlinear_freq > min_freq > 0 | + | | || If boost is not active but supported, this maximum frequency will be larger than | + | | | the one in ``cpuinfo``. | + +---------+--------------------------------+------------------------------------------------------------------------------------+ + +#. How to execute the tests + + We use test module in the kselftest frameworks to implement it. + We create amd-pstate-ut module and tie it into kselftest.(for + details refer to Linux Kernel Selftests [4]_). + + 1. Build :: + + jasminemeng@jasmine-meng:~/amd-brahma$ cd linux + jasminemeng@jasmine-meng:~/amd-brahma/linux$ make modules M=tools/testing/selftests/amd-pstate/amd-pstate-ut + CC [M] tools/testing/selftests/amd-pstate/amd-pstate-ut/amd-pstate-ut.o + MODPOST tools/testing/selftests/amd-pstate/amd-pstate-ut/Module.symvers + CC [M] tools/testing/selftests/amd-pstate/amd-pstate-ut/amd-pstate-ut.mod.o + LD [M] tools/testing/selftests/amd-pstate/amd-pstate-ut/amd-pstate-ut.ko + BTF [M] tools/testing/selftests/amd-pstate/amd-pstate-ut/amd-pstate-ut.ko + jasminemeng@jasmine-meng:~/amd-brahma/linux$ make -C tools/testing/selftests + + #. Installation & Steps :: + + jasmine@jasmine-MayanDAP-RMB:~/amd-brahma/linux$ make -C tools/testing/selftests install INSTALL_PATH=~/kselftest + jasmine@jasmine-MayanDAP-RMB:~$ sudo cp amd-pstate-ut.ko /lib/modules/5.18.0-rc2+/ + jasmine@jasmine-MayanDAP-RMB:~$ sudo depmod + jasmine@jasmine-MayanDAP-RMB:~$ sudo ./kselftest/run_kselftest.sh -c amd-pstate + TAP version 13 + 1..1 + # selftests: amd-pstate: amd-pstate-ut.sh + # amd-pstate-ut: ok + ok 1 selftests: amd-pstate: amd-pstate-ut.sh + + #. Results :: + + jasmine@jasmine-MayanDAP-RMB:~$ dmesg | grep "amd-pstate-ut" | tee log.txt + [76697.480217] amd-pstate-ut: loaded. + [76697.480222] amd-pstate-ut: ****** Begin 1 acpi_cpc_valid ****** + [76697.480227] amd-pstate-ut: ****** End 1 acpi_cpc_valid ****** + [76697.480228] amd-pstate-ut: ****** Begin 2 check_enabled ****** + [76697.480253] amd-pstate-ut: ****** End 2 check_enabled ****** + [76697.480255] amd-pstate-ut: ****** Begin 3 check_perf ****** + [76697.480554] amd-pstate-ut: ****** End 3 check_perf ****** + [76697.480556] amd-pstate-ut: ****** Begin 4 check_freq ****** + [76697.480558] amd-pstate-ut: ****** End 4 check_freq ****** + [76697.480559] amd-pstate-ut: all 4 tests passed + [76697.482507] amd-pstate-ut: unloaded. + Reference ===========
@@ -405,3 +489,6 @@ Reference .. [3] Processor Programming Reference (PPR) for AMD Family 19h Model 51h, Revision A1 Processors https://www.amd.com/system/files/TechDocs/56569-A1-PUB.zip + +.. [4] Linux Kernel Selftests, + https://www.kernel.org/doc/html/latest/dev-tools/kselftest.html
Signature · 1 line
2.25.1
Huang Rui
maintainerRe: [PATCH V4 3/3] Documentation: amd-pstate: Add unit test introduction
Quoted 80 lines · Li (Jassmine)
Introduce the AMD P-State unit test module design and implementation.
Signed-off-by Meng Li <[email protected]>--- Documentation/admin-guide/pm/amd-pstate.rst | 87 +++++++++++++++++++++ 1 file changed, 87 insertions(+)Documentation/admin-guide/pm/amd-pstate.rst +51
-0@@ -182,6 +182,7 @@ to the ``struct sugov_cpu`` that the utilization update belongs to. Then, ``amd-pstate`` updates the desired performance according to the CPU scheduler assigned. +.. _processor_support: Processor Support =======================@@ -282,6 +283,8 @@ efficiency frequency management method on AMD processors. Kernel Module Options for ``amd-pstate`` ========================================= +.. _shared_mem: + ``shared_mem`` Use a module param (shared_mem) to enable related processors manually with **amd_pstate.shared_mem=1**.@@ -393,6 +396,87 @@ about part of the output. :: CPU_005 712 116384 39 49 166 0.7565 9645075 2214891 38431470 25.1 11.646 469 2.496 kworker/5:0-40 CPU_006 712 116408 39 49 166 0.6769 8950227 1839034 37192089 24.06 11.272 470 2.496 kworker/6:0-1264 +Unit Tests for amd-pstate +------------------------- + +``amd-pstate-ut`` is a test module for testing the ``amd-pstate`` driver. + + * It can help all users to verify their processor support (SBIOS/Firmware or Hardware). + + * Kernel can have a basic function test to avoid the kernel regression during the update. + + * We can introduce more functional or performance tests to align the result together, it will benefit power and performance scale optimization. + +1. Test case decriptions + + +---------+--------------------------------+------------------------------------------------------------------------------------+ + | Index | Functions | Description | + +=========+================================+====================================================================================+ + | 0 | aput_acpi_cpc || Check whether the _CPC object is present in SBIOS. | + | | || | + | | || The detail refer to `Processor Support <processor_support_>`_. | + +---------+--------------------------------+------------------------------------------------------------------------------------+ + | 1 | aput_check_enabled || Check whether AMD P-State is enabled. | + | | || | + | | || AMD P-States and ACPI hardware P-States always can be supported in one processor. | + | | | But AMD P-States has the higher priority and if it is enabled with | + | | | :c:macro:`MSR_AMD_CPPC_ENABLE` or ``cppc_set_enable``, it will respond to the | + | | | request from AMD P-States. | + +---------+--------------------------------+------------------------------------------------------------------------------------+ + | 2 | aput_check_perf || Check if the each performance values are reasonable. | + | | || highest_perf >= nominal_perf > lowest_nonlinear_perf > lowest_perf > 0. | + +---------+--------------------------------+------------------------------------------------------------------------------------+ + | 3 | aput_check_freq || Check if the each frequency values and max freq when set support boost mode | + | | | are reasonable. | + | | || max_freq >= nominal_freq > lowest_nonlinear_freq > min_freq > 0 | + | | || If boost is not active but supported, this maximum frequency will be larger than | + | | | the one in ``cpuinfo``. | + +---------+--------------------------------+------------------------------------------------------------------------------------+ + +#. How to execute the tests + + We use test module in the kselftest frameworks to implement it. + We create amd-pstate-ut module and tie it into kselftest.(for + details refer to Linux Kernel Selftests [4]_). + + 1. Build :: + + jasminemeng@jasmine-meng:~/amd-brahma$ cd linux + jasminemeng@jasmine-meng:~/amd-brahma/linux$ make modules M=tools/testing/selftests/amd-pstate/amd-pstate-ut + CC [M] tools/testing/selftests/amd-pstate/amd-pstate-ut/amd-pstate-ut.o
Documentation/admin-guide/pm/amd-pstate.rst about part of the output. :: · line 456
Quoted 10 lines
Documentation/admin-guide/pm/amd-pstate.rst +10
-0+ MODPOST tools/testing/selftests/amd-pstate/amd-pstate-ut/Module.symvers + CC [M] tools/testing/selftests/amd-pstate/amd-pstate-ut/amd-pstate-ut.mod.o + LD [M] tools/testing/selftests/amd-pstate/amd-pstate-ut/amd-pstate-ut.ko + BTF [M] tools/testing/selftests/amd-pstate/amd-pstate-ut/amd-pstate-ut.ko + jasminemeng@jasmine-meng:~/amd-brahma/linux$ make -C tools/testing/selftests + + #. Installation & Steps :: + + jasmine@jasmine-MayanDAP-RMB:~/amd-brahma/linux$ make -C tools/testing/selftests install INSTALL_PATH=~/kselftest + jasmine@jasmine-MayanDAP-RMB:~$ sudo cp amd-pstate-ut.ko /lib/modules/5.18.0-rc2+/
We should not mention a specfic kernel version "5.18.0-rc2+" here.
Documentation/admin-guide/pm/amd-pstate.rst about part of the output. :: · line 458
Quoted 2 lines
Documentation/admin-guide/pm/amd-pstate.rst +2
-0+ jasmine@jasmine-MayanDAP-RMB:~$ sudo depmod + jasmine@jasmine-MayanDAP-RMB:~$ sudo ./kselftest/run_kselftest.sh -c amd-pstate
"Can we move "insmod/rmmod amd-pstate-ut.ko" stuff into script amd_pstate_ut.sh?
Thanks,
Ray
Quoted 34 lines
Documentation/admin-guide/pm/amd-pstate.rst +24
-0+ TAP version 13 + 1..1 + # selftests: amd-pstate: amd-pstate-ut.sh + # amd-pstate-ut: ok + ok 1 selftests: amd-pstate: amd-pstate-ut.sh + + #. Results :: + + jasmine@jasmine-MayanDAP-RMB:~$ dmesg | grep "amd-pstate-ut" | tee log.txt + [76697.480217] amd-pstate-ut: loaded. + [76697.480222] amd-pstate-ut: ****** Begin 1 acpi_cpc_valid ****** + [76697.480227] amd-pstate-ut: ****** End 1 acpi_cpc_valid ****** + [76697.480228] amd-pstate-ut: ****** Begin 2 check_enabled ****** + [76697.480253] amd-pstate-ut: ****** End 2 check_enabled ****** + [76697.480255] amd-pstate-ut: ****** Begin 3 check_perf ****** + [76697.480554] amd-pstate-ut: ****** End 3 check_perf ****** + [76697.480556] amd-pstate-ut: ****** Begin 4 check_freq ****** + [76697.480558] amd-pstate-ut: ****** End 4 check_freq ****** + [76697.480559] amd-pstate-ut: all 4 tests passed + [76697.482507] amd-pstate-ut: unloaded. + Reference ===========@@ -405,3 +489,6 @@ Reference .. [3] Processor Programming Reference (PPR) for AMD Family 19h Model 51h, Revision A1 Processors https://www.amd.com/system/files/TechDocs/56569-A1-PUB.zip + +.. [4] Linux Kernel Selftests, + https://www.kernel.org/doc/html/latest/dev-tools/kselftest.htmlSignature · 1 line
2.25.1