Skip to contentSkip to conversation

xfs: fix rmap inefficiencies

GIT PULL Darrick J. Wong 1 participant 1 message Apr 28, 2022

lore
Share & tools
lore
#0 lore raw

The following changes since commit a44a027a8b2a20fec30e0e9c99b0eb41c03e7420:

Merge tag 'large-extent-counters-v9' of https://github.com/chandanr/linux into xfs-5.19-for-next (2022-04-21 16:46:17 +1000)

are available in the Git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git tags/rmap-speedups-5.19_2022-04-28

for you to fetch changes up to 1edf8056131aca6fe7f98873da8297e6fa279d8c:

xfs: speed up write operations by using non-overlapped lookups when possible (2022-04-28 10:24:38 -0700)

----------------------------------------------------------------
xfs: fix rmap inefficiencies

Reduce the performance impact of the reverse mapping btree when reflink is enabled by using the much faster non-overlapped btree lookup functions when we're searching the rmap index with a fully specified key. If we find the exact record we're looking for, great! We don't have to perform the full overlapped scan. For filesystems with high sharing factors this reduces the xfs_scrub runtime by a good 15%%.

This has been shown to reduce the fstests runtime for realtime rmap configurations by 30%%, since the lack of AGs severely limits scalability.

v2: simplify the non-overlapped lookup code per dave comments

----------------------------------------------------------------
Darrick J. Wong (4):
xfs: capture buffer ops in the xfs_buf tracepoints
xfs: simplify xfs_rmap_lookup_le call sites
xfs: speed up rmap lookups by using non-overlapped lookups when possible
xfs: speed up write operations by using non-overlapped lookups when possible

 fs/xfs/libxfs/xfs_rmap.c | 161 ++++++++++++++++++++++++++++-------------------
 fs/xfs/libxfs/xfs_rmap.h |   7 +--
 fs/xfs/scrub/bmap.c      |  24 ++-----
 fs/xfs/xfs_trace.h       |   5 +-
 4 files changed, 106 insertions(+), 91 deletions(-)