led: Drop led_default_state()
PATCH 1/1 led: Drop led_default_state()
This function is empty, drop it.
Signed-off-by Marek Vasut <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>
Cc Sean Anderson <[email protected]>
Cc Simon Glass <[email protected]>
Cc Steven Lawrance <[email protected]>
--- board/aristainetos/aristainetos.c | 1 - board/bosch/guardian/board.c | 3 --- board/dhelectronics/dh_stm32mp1/board.c | 3 --- board/gardena/smart-gateway-at91sam/board.c | 3 --- board/gardena/smart-gateway-mt7688/board.c | 3 --- board/gateworks/venice/venice.c | 2 -- board/k+p/kp_imx6q_tpc/kp_imx6q_tpc.c | 3 --- board/mscc/jr2/jr2.c | 4 ---- board/mscc/luton/luton.c | 4 ---- board/mscc/ocelot/ocelot.c | 4 ---- board/mscc/serval/serval.c | 4 ---- board/mscc/servalt/servalt.c | 4 ---- board/phytec/pcm052/pcm052.c | 3 --- board/sandbox/sandbox.c | 3 --- board/siemens/capricorn/board.c | 4 ---- board/st/stm32mp1/stm32mp1.c | 3 --- drivers/led/led-uclass.c | 6 ------ include/led.h | 9 --------- test/dm/led.c | 3 --- 19 files changed, 69 deletions(-)
board/aristainetos/aristainetos.c +0 -1
@@ -418,7 +418,6 @@ int board_late_init(void)int x, y;int ret; -led_default_state ();splash_get_pos (&x, &y);bmp_display ((ulong)&bmp_logo_bitmap[0 ], x, y);
board/bosch/guardian/board.c +0 -3
@@ -327,9 +327,6 @@ int board_late_init(void)int ret;struct udevice *cdev; -#ifdef CONFIG_LED_GPIO -led_default_state (); -#endif set_bootmode_env (); ret =uclass_get_device (UCLASS_PANEL ,0 , &cdev);
board/dhelectronics/dh_stm32mp1/board.c +0 -3
@@ -607,9 +607,6 @@ int board_init(void)board_init_fmc2 (); -if (CONFIG_IS_ENABLED (LED )) -led_default_state (); -return 0 ; }
board/gardena/smart-gateway-at91sam/board.c +0 -3
@@ -24,9 +24,6 @@ int board_late_init(void) {at91_prepare_cpu_var (); -if (IS_ENABLED (CONFIG_LED )) -led_default_state (); -return 0 ; }
board/gardena/smart-gateway-mt7688/board.c +0 -3
@@ -183,9 +183,6 @@ err_free:int board_late_init (void ) { -if (IS_ENABLED (CONFIG_LED )) -led_default_state (); -factory_data_env_config ();return 0 ;
board/gateworks/venice/venice.c +0 -2
@@ -118,8 +118,6 @@ int board_late_init(void)u8 enetaddr[6 ];char fdt[64 ]; -led_default_state (); -/* Set board serial/model */ if (!env_get ("serial#" ))env_set_ulong ("serial#" ,gsc_get_serial ());
board/k+p/kp_imx6q_tpc/kp_imx6q_tpc.c +0 -3
@@ -137,9 +137,6 @@ int board_late_init(void)add_board_boot_modes (board_boot_modes);#endif -if (IS_ENABLED (CONFIG_LED )) -led_default_state (); -env_set ("boardname" ,"kp-tpc" );env_set ("boardsoc" ,"imx6q" );return 0 ;
board/mscc/jr2/jr2.c +0 -4
@@ -30,10 +30,6 @@ int board_early_init_r(void)/* Address of boot parameters */ gd->bd->bi_boot_params =CONFIG_SYS_SDRAM_BASE ; -/* LED setup */ -if (IS_ENABLED (CONFIG_LED )) -led_default_state (); -return 0 ; }
board/mscc/luton/luton.c +0 -4
@@ -31,10 +31,6 @@ int board_early_init_r(void)/* Address of boot parameters */ gd->bd->bi_boot_params =CONFIG_SYS_SDRAM_BASE ; -/* LED setup */ -if (IS_ENABLED (CONFIG_LED )) -led_default_state (); -return 0 ; }
board/mscc/ocelot/ocelot.c +0 -4
@@ -79,10 +79,6 @@ int board_early_init_r(void)/* Address of boot parameters */ gd->bd->bi_boot_params =CONFIG_SYS_SDRAM_BASE ; -/* LED setup */ -if (IS_ENABLED (CONFIG_LED )) -led_default_state (); -return 0 ; }
board/mscc/serval/serval.c +0 -4
@@ -24,10 +24,6 @@ int board_early_init_r(void)/* Address of boot parameters */ gd->bd->bi_boot_params =CONFIG_SYS_SDRAM_BASE ; -/* LED setup */ -if (IS_ENABLED (CONFIG_LED )) -led_default_state (); -return 0 ; }
board/mscc/servalt/servalt.c +0 -4
@@ -24,10 +24,6 @@ int board_early_init_r(void)/* Address of boot parameters */ gd->bd->bi_boot_params =CONFIG_SYS_SDRAM_BASE ; -/* LED setup */ -if (IS_ENABLED (CONFIG_LED )) -led_default_state (); -return 0 ; }
board/phytec/pcm052/pcm052.c +0 -3
@@ -360,9 +360,6 @@ int board_late_init(void)struct src *psrc = (struct src *)SRC_BASE_ADDR ;u32 reg; -if (IS_ENABLED (CONFIG_LED )) -led_default_state (); -/* * BK4r1 handle emergency/service SD card boot * Checking the SBMR1 register BOOTCFG1 byte:
board/sandbox/sandbox.c +0 -3
@@ -107,9 +107,6 @@ int dram_init(void)int board_init (void ) { -if (IS_ENABLED (CONFIG_LED )) -led_default_state (); -return 0 ; }
board/siemens/capricorn/board.c +0 -4
@@ -244,10 +244,6 @@ static int board_led_init(void)u8 pca_led[2 ] = {0x00 ,0x00 };int ret; -/* init all GPIO LED's */ -if (IS_ENABLED (CONFIG_LED )) -led_default_state (); -/* enable all leds on PCA9552 */ ret =uclass_get_device_by_seq (UCLASS_I2C ,PCA9552_1_I2C_BUS , &bus);if (ret) {
board/st/stm32mp1/stm32mp1.c +0 -3
@@ -666,9 +666,6 @@ int board_init(void)if (IS_ENABLED (CONFIG_ARMV7_NONSEC ))sysconf_init (); -if (CONFIG_IS_ENABLED (LED )) -led_default_state (); -setup_led (LEDST_ON );return 0 ;
drivers/led/led-uclass.c +0 -6
@@ -66,12 +66,6 @@ int led_set_period(struct udevice *dev, int period_ms) }#endif -/* This is superseded by led_post_bind()/led_post_probe() below. */ -int led_default_state (void ) -{ -return 0 ; -} -static int led_post_bind (struct udevice *dev) {struct led_uc_plat *uc_plat =dev_get_uclass_plat (dev);
include/led.h +0 -9
@@ -110,13 +110,4 @@ enum led_state_t led_get_state(struct udevice *dev);*/ int led_set_period (struct udevice *dev,int period_ms); -/** -* led_default_state() - set the default state for all the LED -* -* This enables all leds which have default state. -* see Documentation/devicetree/bindings/leds/common.txt -* -*/ -int led_default_state (void ); -#endif
test/dm/led.c +0 -3
@@ -33,9 +33,6 @@ static int dm_test_led_default_state(struct unit_test_state *uts) {struct udevice *dev; -/* configure the default state (auto-probe) */ -led_default_state (); -/* Check that we handle the default-state property correctly. */ ut_assertok (led_get_by_label ("sandbox:default_on" , &dev));ut_asserteq (LEDST_ON ,led_get_state (dev));
Signature · 1 line
2.35.1
Hi Marek
Quoted 297 lines · Marek Vasut
This function is empty, drop it.
Signed-off-by Marek Vasut <[email protected]>Cc Patrice Chotard <[email protected]>Cc Patrick Delaunay <[email protected]>Cc Sean Anderson <[email protected]>Cc Simon Glass <[email protected]>Cc Steven Lawrance <[email protected]>--- board/aristainetos/aristainetos.c | 1 - board/bosch/guardian/board.c | 3 --- board/dhelectronics/dh_stm32mp1/board.c | 3 --- board/gardena/smart-gateway-at91sam/board.c | 3 --- board/gardena/smart-gateway-mt7688/board.c | 3 --- board/gateworks/venice/venice.c | 2 -- board/k+p/kp_imx6q_tpc/kp_imx6q_tpc.c | 3 --- board/mscc/jr2/jr2.c | 4 ---- board/mscc/luton/luton.c | 4 ---- board/mscc/ocelot/ocelot.c | 4 ---- board/mscc/serval/serval.c | 4 ---- board/mscc/servalt/servalt.c | 4 ---- board/phytec/pcm052/pcm052.c | 3 --- board/sandbox/sandbox.c | 3 --- board/siemens/capricorn/board.c | 4 ---- board/st/stm32mp1/stm32mp1.c | 3 --- drivers/led/led-uclass.c | 6 ------ include/led.h | 9 --------- test/dm/led.c | 3 --- 19 files changed, 69 deletions(-)board/aristainetos/aristainetos.c +0
-1@@ -418,7 +418,6 @@ int board_late_init(void)int x, y;int ret; -led_default_state ();splash_get_pos (&x, &y);bmp_display ((ulong)&bmp_logo_bitmap[0 ], x, y);board/bosch/guardian/board.c +0
-3@@ -327,9 +327,6 @@ int board_late_init(void)int ret;struct udevice *cdev; -#ifdef CONFIG_LED_GPIO -led_default_state (); -#endif set_bootmode_env (); ret =uclass_get_device (UCLASS_PANEL ,0 , &cdev);board/dhelectronics/dh_stm32mp1/board.c +0
-3@@ -607,9 +607,6 @@ int board_init(void)board_init_fmc2 (); -if (CONFIG_IS_ENABLED (LED )) -led_default_state (); -return 0 ; }board/gardena/smart-gateway-at91sam/board.c +0
-3@@ -24,9 +24,6 @@ int board_late_init(void) {at91_prepare_cpu_var (); -if (IS_ENABLED (CONFIG_LED )) -led_default_state (); -return 0 ; }board/gardena/smart-gateway-mt7688/board.c +0
-3@@ -183,9 +183,6 @@ err_free:int board_late_init (void ) { -if (IS_ENABLED (CONFIG_LED )) -led_default_state (); -factory_data_env_config ();return 0 ;board/gateworks/venice/venice.c +0
-2@@ -118,8 +118,6 @@ int board_late_init(void)u8 enetaddr[6 ];char fdt[64 ]; -led_default_state (); -/* Set board serial/model */ if (!env_get ("serial#" ))env_set_ulong ("serial#" ,gsc_get_serial ());board/k+p/kp_imx6q_tpc/kp_imx6q_tpc.c +0
-3@@ -137,9 +137,6 @@ int board_late_init(void)add_board_boot_modes (board_boot_modes);#endif -if (IS_ENABLED (CONFIG_LED )) -led_default_state (); -env_set ("boardname" ,"kp-tpc" );env_set ("boardsoc" ,"imx6q" );return 0 ;board/mscc/jr2/jr2.c +0
-4@@ -30,10 +30,6 @@ int board_early_init_r(void)/* Address of boot parameters */ gd->bd->bi_boot_params =CONFIG_SYS_SDRAM_BASE ; -/* LED setup */ -if (IS_ENABLED (CONFIG_LED )) -led_default_state (); -return 0 ; }board/mscc/luton/luton.c +0
-4@@ -31,10 +31,6 @@ int board_early_init_r(void)/* Address of boot parameters */ gd->bd->bi_boot_params =CONFIG_SYS_SDRAM_BASE ; -/* LED setup */ -if (IS_ENABLED (CONFIG_LED )) -led_default_state (); -return 0 ; }board/mscc/ocelot/ocelot.c +0
-4@@ -79,10 +79,6 @@ int board_early_init_r(void)/* Address of boot parameters */ gd->bd->bi_boot_params =CONFIG_SYS_SDRAM_BASE ; -/* LED setup */ -if (IS_ENABLED (CONFIG_LED )) -led_default_state (); -return 0 ; }board/mscc/serval/serval.c +0
-4@@ -24,10 +24,6 @@ int board_early_init_r(void)/* Address of boot parameters */ gd->bd->bi_boot_params =CONFIG_SYS_SDRAM_BASE ; -/* LED setup */ -if (IS_ENABLED (CONFIG_LED )) -led_default_state (); -return 0 ; }board/mscc/servalt/servalt.c +0
-4@@ -24,10 +24,6 @@ int board_early_init_r(void)/* Address of boot parameters */ gd->bd->bi_boot_params =CONFIG_SYS_SDRAM_BASE ; -/* LED setup */ -if (IS_ENABLED (CONFIG_LED )) -led_default_state (); -return 0 ; }board/phytec/pcm052/pcm052.c +0
-3@@ -360,9 +360,6 @@ int board_late_init(void)struct src *psrc = (struct src *)SRC_BASE_ADDR ;u32 reg; -if (IS_ENABLED (CONFIG_LED )) -led_default_state (); -/* * BK4r1 handle emergency/service SD card boot * Checking the SBMR1 register BOOTCFG1 byte: board/sandbox/sandbox.c +0
-3@@ -107,9 +107,6 @@ int dram_init(void)int board_init (void ) { -if (IS_ENABLED (CONFIG_LED )) -led_default_state (); -return 0 ; }board/siemens/capricorn/board.c +0
-4@@ -244,10 +244,6 @@ static int board_led_init(void)u8 pca_led[2 ] = {0x00 ,0x00 };int ret; -/* init all GPIO LED's */ -if (IS_ENABLED (CONFIG_LED )) -led_default_state (); -/* enable all leds on PCA9552 */ ret =uclass_get_device_by_seq (UCLASS_I2C ,PCA9552_1_I2C_BUS , &bus);if (ret) {board/st/stm32mp1/stm32mp1.c +0
-3@@ -666,9 +666,6 @@ int board_init(void)if (IS_ENABLED (CONFIG_ARMV7_NONSEC ))sysconf_init (); -if (CONFIG_IS_ENABLED (LED )) -led_default_state (); -setup_led (LEDST_ON );return 0 ;drivers/led/led-uclass.c +0
-6@@ -66,12 +66,6 @@ int led_set_period(struct udevice *dev, int period_ms) }#endif -/* This is superseded by led_post_bind()/led_post_probe() below. */ -int led_default_state (void ) -{ -return 0 ; -} -static int led_post_bind (struct udevice *dev) {struct led_uc_plat *uc_plat =dev_get_uclass_plat (dev);include/led.h +0
-9@@ -110,13 +110,4 @@ enum led_state_t led_get_state(struct udevice *dev);*/ int led_set_period (struct udevice *dev,int period_ms); -/** -* led_default_state() - set the default state for all the LED -* -* This enables all leds which have default state. -* see Documentation/devicetree/bindings/leds/common.txt -* -*/ -int led_default_state (void ); -#endif test/dm/led.c +0
-0
test/dm/led.c static int dm_test_led_default_state(struct unit_test_state *uts) · line 38
Quoted 9 lines
test/dm/led.c +0
-3@@ -33,9 +33,6 @@ static int dm_test_led_default_state(struct unit_test_state *uts) {struct udevice *dev; -/* configure the default state (auto-probe) */ -led_default_state (); -/* Check that we handle the default-state property correctly. */ ut_assertok (led_get_by_label ("sandbox:default_on" , &dev));ut_asserteq (LEDST_ON ,led_get_state (dev));
For stm32mp1
Reviewed-by Patrice Chotard <[email protected]>
Thanks
Patrice
Quoted 9 lines · Marek Vasut
This function is empty, drop it.
Signed-off-by Marek Vasut <[email protected]>Cc Patrice Chotard <[email protected]>Cc Patrick Delaunay <[email protected]>Cc Sean Anderson <[email protected]>Cc Simon Glass <[email protected]>Cc Steven Lawrance <[email protected]>Reviewed-by Patrice Chotard <[email protected]>
Applied to u-boot/master, thanks!
Signature · 1 line
Tom