drm/bridge: tc358767: Fix (e)DP bridge endpoint parsing in dedicated function
Subsystems (3)
PATCH v4 1/1 drm/bridge: tc358767: Fix (e)DP bridge endpoint parsing in dedicated function
Per toshiba,tc358767.yaml DT binding document, port@2 the output (e)DP port is optional. In case this port is not described in DT, the bridge driver operates in DPI-to-DP mode. The drm_of_find_panel_or_bridge() call in tc_probe_edp_bridge_endpoint() returns -ENODEV in case port@2 is not present in DT and this specific return value is incorrectly propagated outside of tc_probe_edp_bridge_endpoint() function. All other error values must be propagated and are propagated correctly.
Return 0 in case the port@2 is missing instead, that reinstates the original behavior before the commit this patch fixes.
--- drivers/gpu/drm/bridge/tc358767.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/bridge/tc358767.c +1 -1
@@ -1955,7 +1955,7 @@ static int tc_probe_edp_bridge_endpoint(struct tc_data *tc) tc->bridge.ops |=DRM_BRIDGE_OP_DETECT ; tc->bridge.ops |=DRM_BRIDGE_OP_EDID ; -return ret; +return 0 ; }static int tc_probe_bridge_endpoint (struct tc_data *tc)
Signature · 1 line
2.35.1
Quoted 11 lines · Marek Vasut
Per toshiba,tc358767.yaml DT binding document, port@2 the output (e)DP port is optional. In case this port is not described in DT, the bridge driver operates in DPI-to-DP mode. The
drm_of_find_panel_or_bridge()call intc_probe_edp_bridge_endpoint()returns-ENODEVin case port@2 is not present in DT and this specific return value is incorrectly propagated outside oftc_probe_edp_bridge_endpoint()function. All other error values must be propagated and are propagated correctly.Return 0 in case the port@2 is missing instead, that reinstates the original behavior before the commit this patch fixes.
Quoted 10 lines
Fixes 8478095a8c4b ("drm/bridge: tc358767: Move (e)DP bridge endpoint parsing into dedicated function")Signed-off-by Marek Vasut <[email protected]>Cc Jonas Karlman <[email protected]>Cc Laurent Pinchart <[email protected]>Cc Lucas Stach <[email protected]>Cc Marek Vasut <[email protected]>Cc Maxime Ripard <[email protected]>Cc Neil Armstrong <[email protected]>Cc Robert Foss <[email protected]>Cc Sam Ravnborg <[email protected]>
This is a V1, sigh ... the fix stands however.
Am Donnerstag, dem 28.04.2022 um 23:31 +0200 schrieb Marek Vasut:
Quoted 8 lines
Per toshiba,tc358767.yaml DT binding document, port@2 the output (e)DP port is optional. In case this port is not described in DT, the bridge driver operates in DPI-to-DP mode. The
drm_of_find_panel_or_bridge()call intc_probe_edp_bridge_endpoint()returns-ENODEVin case port@2 is not present in DT and this specific return value is incorrectly propagated outside oftc_probe_edp_bridge_endpoint()function. All other error values must be propagated and are propagated correctly.
Quoted 5 lines
Return 0 in case the port@2 is missing instead, that reinstates the original behavior before the commit this patch fixes.
Fixes 8478095a8c4b ("drm/bridge: tc358767: Move (e)DP bridge endpoint parsing into dedicated function")Signed-off-by Marek Vasut <[email protected]>
Quoted 25 lines
Cc Jonas Karlman <[email protected]>Cc Laurent Pinchart <[email protected]>Cc Lucas Stach <[email protected]>Cc Marek Vasut <[email protected]>Cc Maxime Ripard <[email protected]>Cc Neil Armstrong <[email protected]>Cc Robert Foss <[email protected]>Cc Sam Ravnborg <[email protected]>--- drivers/gpu/drm/bridge/tc358767.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/bridge/tc358767.c +1
-1@@ -1955,7 +1955,7 @@ static int tc_probe_edp_bridge_endpoint(struct tc_data *tc) tc->bridge.ops |=DRM_BRIDGE_OP_DETECT ; tc->bridge.ops |=DRM_BRIDGE_OP_EDID ; -return ret; +return 0 ; }static int tc_probe_bridge_endpoint (struct tc_data *tc)