mm/vmscan: filter empty page_list at the beginning
Subsystems (3)
PATCH 1/2 mm/vmscan: filter empty page_list at the beginning
node_page_list would always be !empty on finishing the loop, except page_list is empty.
Let's handle empty page_list before doing any real work including touching PF_MEMALLOC flag.
Signed-off-by Wei Yang <[email protected]>
--- mm/vmscan.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)
mm/vmscan.c +6 -4
@@ -2549,9 +2549,12 @@ unsigned long reclaim_pages(struct list_head *page_list)struct page *page;unsigned int noreclaim_flag; +if (list_empty (page_list)) +return nr_reclaimed; + noreclaim_flag =memalloc_noreclaim_save (); -while (!list_empty (page_list)) { + do { page = lru_to_page(page_list); if (nid == NUMA_NO_NODE) nid = page_to_nid(page);
@@ -2564,10 +2567,9 @@ unsigned long reclaim_pages(struct list_head *page_list) nr_reclaimed +=reclaim_page_list (&node_page_list,NODE_DATA (nid)); nid =NUMA_NO_NODE ; - } + }while (!list_empty (page_list)); -if (!list_empty (&node_page_list)) - nr_reclaimed +=reclaim_page_list (&node_page_list,NODE_DATA (nid)); + nr_reclaimed +=reclaim_page_list (&node_page_list,NODE_DATA (nid));memalloc_noreclaim_restore (noreclaim_flag);
Signature · 1 line
2.33.1
PATCH 2/2 mm/vmscan: not use NUMA_NO_NODE as indicator of page on different node
Now we are sure there is at lease one page on page_list, so it is safe to get the nid of it. This means it is not necessary to use NUMA_NO_NODE as an indicator for the beginning of iteration or a page on different node.
Signed-off-by Wei Yang <[email protected]>
--- mm/vmscan.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
mm/vmscan.c +3 -4
@@ -2543,7 +2543,7 @@ static unsigned int reclaim_page_list(struct list_head *page_list,unsigned long reclaim_pages (struct list_head *page_list) { -int nid =NUMA_NO_NODE ; +int nid;unsigned int nr_reclaimed =0 ;LIST_HEAD (node_page_list);struct page *page;
@@ -2554,10 +2554,9 @@ unsigned long reclaim_pages(struct list_head *page_list) noreclaim_flag =memalloc_noreclaim_save (); + nid =page_to_nid (lru_to_page (page_list)); do { page = lru_to_page(page_list); - if (nid == NUMA_NO_NODE) - nid = page_to_nid(page); if (nid == page_to_nid(page)) { ClearPageActive(page);
@@ -2566,7 +2565,7 @@ unsigned long reclaim_pages(struct list_head *page_list) } nr_reclaimed +=reclaim_page_list (&node_page_list,NODE_DATA (nid)); - nid =NUMA_NO_NODE ; + nid =page_to_nid (lru_to_page (page_list)); }while (!list_empty (page_list)); nr_reclaimed +=reclaim_page_list (&node_page_list,NODE_DATA (nid));
Signature · 1 line
2.33.1