Skip to contentSkip to conversation

hw/nvme: deprecate the use-intel-id compatibility parameter

PATCH In review Klaus Jensen 2 participants 3 messages Apr 29, 2022 – May 30, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hw/nvme: deprecate the use-intel-id compatibility parameter

From: Klaus Jensen <[email protected]>

Since version 5.2 commit 6eb7a071292a ("hw/block/nvme: change controller pci id"), the emulated NVMe controller has defaulted to a non-Intel PCI identifier.

Deprecate the compatibility parameter so we can get rid of it once and for all.

---
 docs/about/deprecated.rst | 8 ++++++++
 1 file changed, 8 insertions(+)
docs/about/deprecated.rst +8 -0
index 896e5a97abbd..450f945ac25f 100644
@@ -356,6 +356,14 @@ contains native support for this feature and thus use of the option
 ROM approach is obsolete. The native SeaBIOS support can be activated
 by using ``-machine graphics=off``.
 
+``-device nvme,use-intel-id=on|off`` (since 7.1)
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+The ``nvme`` device originally used a PCI Vendor/Device Identifier combination
+from Intel that was not properly allocated. Since version 5.2, the controller
+has used a properly allocated identifier. Deprecate the ``use-intel-id``
+machine compatibility parameter.
+
 
 Block device options
 ''''''''''''''''''''
Signature · 1 line
2.35.1
Reviewed-by Philippe Mathieu-Daudé on v1 1/1
#1 lore raw
Quoted 23 lines · Klaus Jensen

From: Klaus Jensen <[email protected]>

Since version 5.2 commit 6eb7a071292a ("hw/block/nvme: change controller pci id"), the emulated NVMe controller has defaulted to a non-Intel PCI identifier.

Deprecate the compatibility parameter so we can get rid of it once and for all.

---
  docs/about/deprecated.rst | 8 ++++++++
  1 file changed, 8 insertions(+)
docs/about/deprecated.rst +1 -0
index 896e5a97abbd..450f945ac25f 100644
@@ -356,6 +356,14 @@ contains native support for this feature and thus use of the option
  ROM approach is obsolete. The native SeaBIOS support can be activated
  by using ``-machine graphics=off``.
 
+``-device nvme,use-intel-id=on|off`` (since 7.1)

docs/about/deprecated.rst contains native support for this feature and thus use of the option · line 369

Quoted 10 lines
docs/about/deprecated.rst +7 -0
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+The ``nvme`` device originally used a PCI Vendor/Device Identifier combination
+from Intel that was not properly allocated. Since version 5.2, the controller
+has used a properly allocated identifier. Deprecate the ``use-intel-id``
+machine compatibility parameter.
+
 
  Block device options
  ''''''''''''''''''''
author Applied
#2 lore raw
Quoted 26 lines · Philippe Mathieu-Daudé
Quoted 25 lines · Klaus Jensen

From: Klaus Jensen <[email protected]>

Since version 5.2 commit 6eb7a071292a ("hw/block/nvme: change controller pci id"), the emulated NVMe controller has defaulted to a non-Intel PCI identifier.

Deprecate the compatibility parameter so we can get rid of it once and for all.

---
  docs/about/deprecated.rst | 8 ++++++++
  1 file changed, 8 insertions(+)
docs/about/deprecated.rst +4 -0
index 896e5a97abbd..450f945ac25f 100644
@@ -356,6 +356,14 @@ contains native support for this feature and thus use of the option
  ROM approach is obsolete. The native SeaBIOS support can be activated
  by using ``-machine graphics=off``.
+``-device nvme,use-intel-id=on|off`` (since 7.1)
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+The ``nvme`` device originally used a PCI Vendor/Device Identifier combination
Quoted 8 lines

docs/about/deprecated.rst contains native support for this feature and thus use of the option · line 369

Quoted 6 lines
docs/about/deprecated.rst +4 -0
+from Intel that was not properly allocated. Since version 5.2, the controller
+has used a properly allocated identifier. Deprecate the ``use-intel-id``
+machine compatibility parameter.
+
  Block device options
  ''''''''''''''''''''

Thanks!

Applied to nvme-next.