KVM: selftests: Use TAP interface in the kvm_binary_stats_test
PATCH 1/1 KVM: selftests: Use TAP interface in the kvm_binary_stats_test
The kvm_binary_stats_test test currently does not have any output (unless one of the TEST_ASSERT statement fails), so it's hard to say for a user how far it did proceed already. Thus let's make this a little bit more user-friendly and include some TAP output via the kselftest.h interface.
Signed-off-by Thomas Huth <[email protected]>
--- .../testing/selftests/kvm/kvm_binary_stats_test.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-)
tools/testing/selftests/kvm/kvm_binary_stats_test.c +10 -4
@@ -19,6 +19,7 @@#include "kvm_util.h" #include "asm/kvm.h" #include "linux/kvm.h" +#include "kselftest.h" static void stats_test (int stats_fd) {
@@ -52,7 +53,7 @@ static void stats_test(int stats_fd)/* Sanity check for other fields in header */ if (header->num_desc ==0 ) { -printf ("No KVM stats defined!" ); +ksft_print_msg ("No KVM stats defined!\n" );return ; }/* Check overlap */
@@ -219,12 +220,15 @@ int main(int argc, char *argv[]) max_vcpu =DEFAULT_NUM_VCPU ; } +ksft_print_header (); +/* Check the extension for binary stats */ if (kvm_check_cap (KVM_CAP_BINARY_STATS_FD ) <=0 ) { -print_skip ("Binary form statistics interface is not supported" ); -exit (KSFT_SKIP ); +ksft_exit_skip ("Binary form statistics interface is not supported\n" ); } +ksft_set_plan (max_vm); +/* Create VMs and VCPUs */ vms =malloc (sizeof (vms[0 ]) * max_vm);TEST_ASSERT (vms,"Allocate memory for storing VM pointers" );
@@ -240,10 +244,12 @@ int main(int argc, char *argv[])vm_stats_test (vms[i]);for (j =0 ; j < max_vcpu; ++j)vcpu_stats_test (vms[i], j); +ksft_test_result_pass ("vm%i\n" , i); }for (i =0 ; i < max_vm; ++i)kvm_vm_free (vms[i]);free (vms); -return 0 ; + +ksft_finished ();/* Print results and exit() accordingly */ }
Signature · 1 line
2.27.0