Skip to contentSkip to conversation

volatile-binds: Change DefaultDependencies from false to no

PATCH In review Portia 2 participants 5 messages Apr 29, 2022

lore
Share & tools
lore

Portia

author
#0 lore raw

PATCH 1/2 volatile-binds: Change DefaultDependencies from false to no

The systemd-unit parameter DefaultDependencies changed from true/false to yes/no. This changed in systemd in v242.

---
 .../recipes-core/volatile-binds/files/volatile-binds.service.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/volatile-binds/files/volatile-binds.service.in +1 -1
index 6612d2aae0..8fe7d8d4f9 100644
@@ -1,6 +1,6 @@
 [Unit]
 Description=Bind mount volatile @where@
-DefaultDependencies=false
+DefaultDependencies=no
 Before=local-fs.target
 RequiresMountsFor=@whatparent@ @whereparent@
 ConditionPathIsReadWrite=@whatparent@
Signature · 1 line
2.25.1
author
#1 lore raw

PATCH 2/2 volatile-binds: Remove TimeoutSec and allow DefaultTimeoutSec to be used

Remove setting TimeoutSec and allow the DefaultTimeSec to be set for the volatile-binds services.

---
 meta/recipes-core/volatile-binds/files/volatile-binds.service.in | 1 -
 1 file changed, 1 deletion(-)
meta/recipes-core/volatile-binds/files/volatile-binds.service.in +0 -1
index 8fe7d8d4f9..52384c8264 100644
@@ -10,7 +10,6 @@ ConditionPathIsReadWrite=!@where@
 [Service]
 Type=oneshot
 RemainAfterExit=Yes
-TimeoutSec=0
 Environment=MOUNT_COPYBIND_AVOID_OVERLAYFS=@avoid_overlayfs@
 ExecStart=/sbin/mount-copybind @what@ @where@
 ExecStop=/bin/umount @where@
Signature · 1 line
2.25.1
#2 lore raw

Re: [OE-core] [PATCH 2/2] volatile-binds: Remove TimeoutSec and allow DefaultTimeoutSec to be used

Quoted 3 lines · Portia

Remove setting TimeoutSec and allow the DefaultTimeSec to be set for the volatile-binds services.

Whats the default value? I hope it does not go into infinite loop in case the service gets stuck

Quoted 28 lines
---
  meta/recipes-core/volatile-binds/files/volatile-binds.service.in | 1 -
  1 file changed, 1 deletion(-)
meta/recipes-core/volatile-binds/files/volatile-binds.service.in +0 -2
index 8fe7d8d4f9..52384c8264 100644
@@ -10,7 +10,6 @@ ConditionPathIsReadWrite=!@where@
  [Service]
  Type=oneshot
  RemainAfterExit=Yes
-TimeoutSec=0
  Environment=MOUNT_COPYBIND_AVOID_OVERLAYFS=@avoid_overlayfs@
  ExecStart=/sbin/mount-copybind @what@ @where@
  ExecStop=/bin/umount @where@
 
 
 
-=-=-=-=-=-=-=-=-=-=-=-

Links: You receive all messages sent to this group.
View/Reply Online (#164998): https://lists.openembedded.org/g/openembedded-core/message/164998
Mute This Topic: https://lists.openembedded.org/mt/90771601/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#3 lore raw

Re: [OE-core] [PATCH 2/2] volatile-binds: Remove TimeoutSec and allow DefaultTimeoutSec to be used

Quoted 11 lines · Khem Raj
Quoted 3 lines · Portia

Remove setting TimeoutSec and allow the DefaultTimeSec to be set for the volatile-binds services.

Whats the default value? I hope it does not go into infinite loop in case the service gets stuck

Timeout=0 sets the Timeout to infinity, so the current behavior is that if the service gets stuck
it never gets killed. DefaultTimeout will depend on what is set in the /etc/systemd/system.conf.

Quoted 28 lines
Quoted 28 lines
---
  meta/recipes-core/volatile-binds/files/volatile-binds.service.in | 1 -
  1 file changed, 1 deletion(-)
meta/recipes-core/volatile-binds/files/volatile-binds.service.in +0 -2
index 8fe7d8d4f9..52384c8264 100644
@@ -10,7 +10,6 @@ ConditionPathIsReadWrite=!@where@
  [Service]
  Type=oneshot
  RemainAfterExit=Yes
-TimeoutSec=0
  Environment=MOUNT_COPYBIND_AVOID_OVERLAYFS=@avoid_overlayfs@
  ExecStart=/sbin/mount-copybind @what@ @where@
  ExecStop=/bin/umount @where@
 
 
 
-=-=-=-=-=-=-=-=-=-=-=-

Links: You receive all messages sent to this group.
View/Reply Online (#164998): https://lists.openembedded.org/g/openembedded-core/message/164998
Mute This Topic: https://lists.openembedded.org/mt/90771601/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#4 lore raw

Re: [OE-core] [PATCH 2/2] volatile-binds: Remove TimeoutSec and allow DefaultTimeoutSec to be used

Quoted 10 lines · Portia Stephens
Quoted 5 lines · Khem Raj
Quoted 1 line · Portia

Remove setting TimeoutSec and allow the DefaultTimeSec to be set for

the

Quoted 3 lines
Quoted 2 lines

volatile-binds services.

Quoted 8 lines
Quoted 3 lines

Whats the default value? I hope it does not go into infinite loop in case the service gets stuck

Timeout=0 sets the Timeout to infinity, so the current behavior is that if the service gets stuck
it never gets killed. DefaultTimeout will depend on what is set in the /etc/systemd/system.conf.

Right reading it from system default is fine I guess defaults are perhaps around 90s which is enough for the service to load normally

Quoted 35 lines
Quoted 4 lines
Quoted 4 lines

---
meta/recipes-core/volatile-binds/files/volatile-binds.service.in |

1 -

Quoted 3 lines

Review

Quoted 3 lines
  1 file changed, 1 deletion(-)
(quoted diff) +0 -0

volatile-binds.service.in b/meta/recipes-core/volatile-binds/files/ volatile-binds.service.in

Quoted 14 lines
Quoted 14 lines

index 8fe7d8d4f9..52384c8264 100644

meta/recipes-core/volatile-binds/files/volatile-binds.service.in +0 -1
@@ -10,7 +10,6 @@ ConditionPathIsReadWrite=!@where@
  [Service]
  Type=oneshot
  RemainAfterExit=Yes
-TimeoutSec=0
  Environment=MOUNT_COPYBIND_AVOID_OVERLAYFS=@avoid_overlayfs@
  ExecStart=/sbin/mount-copybind @what@ @where@
  ExecStop=/bin/umount @where@
Quoted 3 lines
Quoted 3 lines

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#164998):

https://lists.openembedded.org/g/openembedded-core/message/164998

Quoted 3 lines
Quoted 3 lines

Mute This Topic: https://lists.openembedded.org/mt/90771601/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub

[[email protected]]

Quoted 2 lines
Quoted 2 lines

-=-=-=-=-=-=-=-=-=-=-=-