linkage: Fix issue with missing symbol size
PATCH 1/1 linkage: Fix issue with missing symbol size
Occasionally, typically when a function doesn't end with 'ret', an alias on that function will have 0 size.
The difference between what GCC generates and our linkage magic, is that GCC doesn't appear to provide .size for the alias'ed symbol at all. And indeed, removing this directive cures the issue.
Additionally, GCC also doesn't emit .type for alias symbols either, so also omit that.
--- include/linux/linkage.h | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-)
include/linux/linkage.h +6 -9
@@ -171,12 +171,9 @@/* SYM_ALIAS -- use only if you have to */ #ifndef SYM_ALIAS -#define SYM_ALIAS (alias, name, sym_type, linkage) \ - linkage(alias) ASM_NL \ - .set alias, name ASM_NL \ - .type alias sym_type ASM_NL \ - .set .L__sym_size_##alias, .L__sym_size_##name ASM_NL \ - .size alias, .L__sym_size_##alias +#define SYM_ALIAS (alias, name, linkage) \ + linkage(alias) ASM_NL \ + .set alias, name ASM_NL#endif /* === code annotations === */
@@ -261,7 +258,7 @@*/ #ifndef SYM_FUNC_ALIAS #define SYM_FUNC_ALIAS (alias, name) \ - SYM_ALIAS(alias, name, SYM_T_FUNC, SYM_L_GLOBAL) + SYM_ALIAS(alias, name, SYM_L_GLOBAL)#endif /*
@@ -269,7 +266,7 @@*/ #ifndef SYM_FUNC_ALIAS_LOCAL #define SYM_FUNC_ALIAS_LOCAL (alias, name) \ - SYM_ALIAS(alias, name, SYM_T_FUNC, SYM_L_LOCAL) + SYM_ALIAS(alias, name, SYM_L_LOCAL)#endif /*
@@ -277,7 +274,7 @@*/ #ifndef SYM_FUNC_ALIAS_WEAK #define SYM_FUNC_ALIAS_WEAK (alias, name) \ - SYM_ALIAS(alias, name, SYM_T_FUNC, SYM_L_WEAK) + SYM_ALIAS(alias, name, SYM_L_WEAK)#endif /* SYM_CODE_START -- use for non-C (special) functions */
Quoted 8 lines · Peter Zijlstra
Occasionally, typically when a function doesn't end with 'ret', an alias on that function will have 0 size.
The difference between what GCC generates and our linkage magic, is that GCC doesn't appear to provide .size for the alias'ed symbol at all. And indeed, removing this directive cures the issue.
Quoted 6 lines
Additionally, GCC also doesn't emit .type for alias symbols either, so also omit that.
Fixes e0891269a8c2 ("linkage: add SYM_FUNC_ALIAS{,_LOCAL,_WEAK}()")Suggested-by Mark Rutland <[email protected]>Signed-off-by Peter Zijlstra (Intel) <[email protected]>
Signature · 1 line
Josh
Quoted 13 lines · Josh Poimboeuf
Quoted 11 lines · Peter Zijlstra
Occasionally, typically when a function doesn't end with 'ret', an alias on that function will have 0 size.
The difference between what GCC generates and our linkage magic, is that GCC doesn't appear to provide .size for the alias'ed symbol at all. And indeed, removing this directive cures the issue.
Additionally, GCC also doesn't emit .type for alias symbols either, so also omit that.
Quoted 9 lines
Quoted 3 lines
Fixes e0891269a8c2 ("linkage: add SYM_FUNC_ALIAS{,_LOCAL,_WEAK}()")Suggested-by Mark Rutland <[email protected]>Signed-off-by Peter Zijlstra (Intel) <[email protected]>Acked-by Josh Poimboeuf <[email protected]>--
Josh
Yeah, an alias inherits the original symbol's st_size. In case you are interested in the internals, see
https://sourceware.org/bugzilla/show_bug.cgi?id=29012 ("gas: .set should copy st_size only if src's st_size is unset")
Quoted 8 lines · Peter Zijlstra
Occasionally, typically when a function doesn't end with 'ret', an alias on that function will have 0 size.
The difference between what GCC generates and our linkage magic, is that GCC doesn't appear to provide .size for the alias'ed symbol at all. And indeed, removing this directive cures the issue.
Quoted 6 lines
Additionally, GCC also doesn't emit .type for alias symbols either, so also omit that.
Fixes e0891269a8c2 ("linkage: add SYM_FUNC_ALIAS{,_LOCAL,_WEAK}()")Suggested-by Mark Rutland <[email protected]>Signed-off-by Peter Zijlstra (Intel) <[email protected]>
Sorry about this!
FWIW:
Thanks,
Mark.
Quoted 50 lines
--- include/linux/linkage.h | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-)include/linux/linkage.h +6
-9@@ -171,12 +171,9 @@/* SYM_ALIAS -- use only if you have to */ #ifndef SYM_ALIAS -#define SYM_ALIAS (alias, name, sym_type, linkage) \ - linkage(alias) ASM_NL \ - .set alias, name ASM_NL \ - .type alias sym_type ASM_NL \ - .set .L__sym_size_##alias, .L__sym_size_##name ASM_NL \ - .size alias, .L__sym_size_##alias +#define SYM_ALIAS (alias, name, linkage) \ + linkage(alias) ASM_NL \ + .set alias, name ASM_NL#endif /* === code annotations === */ @@ -261,7 +258,7 @@*/ #ifndef SYM_FUNC_ALIAS #define SYM_FUNC_ALIAS (alias, name) \ - SYM_ALIAS(alias, name, SYM_T_FUNC, SYM_L_GLOBAL) + SYM_ALIAS(alias, name, SYM_L_GLOBAL)#endif /* @@ -269,7 +266,7 @@*/ #ifndef SYM_FUNC_ALIAS_LOCAL #define SYM_FUNC_ALIAS_LOCAL (alias, name) \ - SYM_ALIAS(alias, name, SYM_T_FUNC, SYM_L_LOCAL) + SYM_ALIAS(alias, name, SYM_L_LOCAL)#endif /* @@ -277,7 +274,7 @@*/ #ifndef SYM_FUNC_ALIAS_WEAK #define SYM_FUNC_ALIAS_WEAK (alias, name) \ - SYM_ALIAS(alias, name, SYM_T_FUNC, SYM_L_WEAK) + SYM_ALIAS(alias, name, SYM_L_WEAK)#endif /* SYM_CODE_START -- use for non-C (special) functions */