Skip to contentSkip to conversation

dt-bindings: regulator: Add bindings for Silicon Mitus SM5703 regulators

PATCH In review Markuss Broks 2 participants 4 messages Apr 29, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v6 2/5 dt-bindings: regulator: Add bindings for Silicon Mitus SM5703 regulators

This patch adds device-tree bindings for regulators on Silicon Mitus SM5703 MFD.

---
 .../siliconmitus,sm5703-regulator.yaml        | 49 +++++++++++++++++++
 1 file changed, 49 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/regulator/siliconmitus,sm5703-regulator.yaml
Documentation/devicetree/bindings/regulator/siliconmitus,sm5703-regulator.yaml new file +49 -0
new file mode 100644
index 000000000000..9d84117530ca
@@ -0,0 +1,49 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/regulator/siliconmitus,sm5703-regulator.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Silicon Mitus SM5703 multi function device regulators
+
+maintainers:
+  - Markuss Broks <[email protected]>
+
+description: |
+  SM5703 regulators node should be a sub node of the SM5703 MFD node. See SM5703 MFD
+  bindings at Documentation/devicetree/bindings/mfd/siliconmitus,sm5703.yaml
+  Regulator nodes should be named as USBLDO_<number>, BUCK, VBUS, LDO_<number>.
+  The definition for each of these nodes is defined using the standard
+  binding for regulators at Documentation/devicetree/bindings/regulator/regulator.txt.
+
+properties:
+  buck:
+    type: object
+    $ref: regulator.yaml#
+    unevaluatedProperties: false
+    description:
+      Properties for the BUCK regulator.
+
+  vbus:
+    type: object
+    $ref: regulator.yaml#
+    unevaluatedProperties: false
+    description:
+      Properties for the VBUS regulator.
+
+patternProperties:
+  "^ldo[1-3]$":
+    type: object
+    $ref: regulator.yaml#
+    unevaluatedProperties: false
+    description:
+      Properties for single LDO regulator.
+
+  "^usbldo[1-2]$":
+    type: object
+    $ref: regulator.yaml#
+    unevaluatedProperties: false
+    description:
+      Properties for a single USBLDO regulator.
+
+additionalProperties: false
Signature · 1 line
2.35.1
maintainer
#1 lore raw
Quoted 8 lines · Markuss Broks

This patch adds device-tree bindings for regulators on Silicon Mitus SM5703 MFD.

---
 .../siliconmitus,sm5703-regulator.yaml        | 49 +++++++++++++++++++
 1 file changed, 49 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/regulator/siliconmitus,sm5703-regulator.yaml

As Rob said please send an incremental patch with any fixes needed.

#2 lore raw

Hi Mark,

Quoted 10 lines · Mark Brown
Quoted 8 lines · Markuss Broks

This patch adds device-tree bindings for regulators on Silicon Mitus SM5703 MFD.

---
  .../siliconmitus,sm5703-regulator.yaml        | 49 +++++++++++++++++++
  1 file changed, 49 insertions(+)

create mode 100644 Documentation/devicetree/bindings/regulator/siliconmitus,sm5703-regulator.yaml

As Rob said please send an incremental patch with any fixes needed.

I'm sorry, I didn't understand it correctly. Does "incremental patch" mean I should send a separate follow-up patch with those fixes?
- Markuss

maintainer
#3 lore raw
Quoted 6 lines · Markuss Broks
Quoted 1 line · Mark Brown

As Rob said please send an incremental patch with any fixes needed.

I'm sorry, I didn't understand it correctly. Does "incremental patch" mean I should send a separate follow-up patch with those fixes?

Yes. It means on top of what's already applied.

Please also don't label patches that aren't part of a patch series as though they were in a series, it just creates confusion.