misc: i2c_eeprom: add support for microchip 24aa025e48
Subsystems (2)
PATCH 1/2 misc: i2c_eeprom: add support for microchip 24aa025e48
24aa025e48 is a variant of 24aa02e48 that has a page size of 16 bytes.
--- drivers/misc/i2c_eeprom.c | 8 ++++++++ 1 file changed, 8 insertions(+)
drivers/misc/i2c_eeprom.c +8 -0
@@ -176,6 +176,13 @@ static const struct i2c_eeprom_drv_data mc24aa02e48_data = { .offset_len = 1, }; +static const struct i2c_eeprom_drv_data mc24aa025e48_data = { + .size =256 , + .pagesize =16 , + .addr_offset_mask =0 , + .offset_len =1 , +}; +static const struct i2c_eeprom_drv_data atmel24c01a_data = { .size =128 , .pagesize =8 ,
@@ -264,6 +271,7 @@ static const struct i2c_eeprom_drv_data atmel24c512_data = {static const struct udevice_id i2c_eeprom_std_ids[] = { { .compatible ="i2c-eeprom" , (ulong)&eeprom_data }, { .compatible ="microchip,24aa02e48" , (ulong)&mc24aa02e48_data }, + { .compatible ="microchip,24aa025e48" , (ulong)&mc24aa025e48_data }, { .compatible ="atmel,24c01" , (ulong)&atmel24c01a_data }, { .compatible ="atmel,24c01a" , (ulong)&atmel24c01a_data }, { .compatible ="atmel,24c02" , (ulong)&atmel24c02_data },
Signature · 1 line
2.25.1
PATCH 2/2 ARM: dts: at91: sam9x60ek: fix eeprom compatible
The correct compatible for the eeprom is microchip,24aa025e48 as this is the populated memory on this board.
--- arch/arm/dts/sam9x60ek.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/dts/sam9x60ek.dts +1 -1
@@ -72,7 +72,7 @@ status = "okay"; eeprom@53 { - compatible = "atmel,24c32"; + compatible = "microchip,24aa025e48"; reg = <0x53>; pagesize = <16>; };
Signature · 1 line
2.25.1
Hello Eugen,
Quoted 6 lines · Eugen Hristev
24aa025e48is a variant of24aa02e48that has a page size of 16 bytes.Signed-off-by Eugen Hristev <[email protected]>--- drivers/misc/i2c_eeprom.c | 8 ++++++++ 1 file changed, 8 insertions(+)
bye,
Heiko
Signature · 3 lines
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: [email protected]
Quoted 26 lines
24aa025e48is a variant of24aa02e48that has a page size of 16 bytes.Signed-off-by Eugen Hristev <[email protected]>--- drivers/misc/i2c_eeprom.c | 8 ++++++++ 1 file changed, 8 insertions(+)drivers/misc/i2c_eeprom.c +7
-0@@ -176,6 +176,13 @@ static const struct i2c_eeprom_drv_data mc24aa02e48_data = { .offset_len = 1, }; +static const struct i2c_eeprom_drv_data mc24aa025e48_data = { + .size =256 , + .pagesize =16 , + .addr_offset_mask =0 , + .offset_len =1 , +}; +static const struct i2c_eeprom_drv_data atmel24c01a_data = { .size =128 , .pagesize =8 ,
drivers/misc/i2c_eeprom.c static const struct i2c_eeprom_drv_data atmel24c512_data = { · line 274
Quoted 4 lines
drivers/misc/i2c_eeprom.c +1
-0@@ -264,6 +271,7 @@ static const struct i2c_eeprom_drv_data atmel24c512_data = {static const struct udevice_id i2c_eeprom_std_ids[] = { { .compatible ="i2c-eeprom" , (ulong)&eeprom_data }, { .compatible ="microchip,24aa02e48" , (ulong)&mc24aa02e48_data }, + { .compatible ="microchip,24aa025e48" , (ulong)&mc24aa025e48_data },
As far as I can see, this is not a documented compatible string in the device tree bindings, which means u-boot is diverting again from its linux counterpart. (The same goes for the 24aa02e48).
-michael
Quoted 3 lines
drivers/misc/i2c_eeprom.c +0
-0{ .compatible = "atmel,24c01", (ulong)&atmel24c01a_data }, { .compatible = "atmel,24c01a", (ulong)&atmel24c01a_data }, { .compatible = "atmel,24c02", (ulong)&atmel24c02_data },
Quoted 26 lines · Michael Walle
Quoted 26 lines
24aa025e48is a variant of24aa02e48that has a page size of 16 bytes.Signed-off-by Eugen Hristev <[email protected]>--- drivers/misc/i2c_eeprom.c | 8 ++++++++ 1 file changed, 8 insertions(+)drivers/misc/i2c_eeprom.c +7
-0@@ -176,6 +176,13 @@ static const struct i2c_eeprom_drv_data mc24aa02e48_data = { .offset_len = 1, }; +static const struct i2c_eeprom_drv_data mc24aa025e48_data = { + .size =256 , + .pagesize =16 , + .addr_offset_mask =0 , + .offset_len =1 , +}; +static const struct i2c_eeprom_drv_data atmel24c01a_data = { .size =128 , .pagesize =8 ,@@ -264,6 +271,7 @@ static const struct i2c_eeprom_drv_data atmel24c512_data = {
Quoted 8 lines
drivers/misc/i2c_eeprom.c static const struct i2c_eeprom_drv_data atmel24c512_data = { · line 274
Quoted 4 lines
drivers/misc/i2c_eeprom.c +1
-0static const struct udevice_id i2c_eeprom_std_ids[] = { { .compatible ="i2c-eeprom" , (ulong)&eeprom_data }, { .compatible ="microchip,24aa02e48" , (ulong)&mc24aa02e48_data }, + { .compatible ="microchip,24aa025e48" , (ulong)&mc24aa025e48_data },As far as I can see, this is not a documented compatible string in the device tree bindings, which means u-boot is diverting again from its linux counterpart. (The same goes for the
24aa02e48).
Hello Michael,
I know. But I thought it was the best way rather than reusing one existing compatible and forcing the page size. I can do that if you feel it's better.
I have to check how Linux is handling this eeprom as it's using the at24c32 compatible which is incorrect. It may be that the at24c32 compatible with additional properties makes the driver behaving as if it's a mc23aa025e48 . Which is not really right... (as the idea above)
Heiko, your thoughts ?
Eugen
Quoted 6 lines
-michael
Quoted 3 lines
drivers/misc/i2c_eeprom.c +0
-0{ .compatible = "atmel,24c01", (ulong)&atmel24c01a_data }, { .compatible = "atmel,24c01a", (ulong)&atmel24c01a_data }, { .compatible = "atmel,24c02", (ulong)&atmel24c02_data },
Hello Eugen,
Quoted 42 lines · On 10.05.22 09:44, [email protected] wrote:
Quoted 26 lines · Michael Walle
Quoted 26 lines
24aa025e48is a variant of24aa02e48that has a page size of 16 bytes.Signed-off-by Eugen Hristev <[email protected]>--- drivers/misc/i2c_eeprom.c | 8 ++++++++ 1 file changed, 8 insertions(+)drivers/misc/i2c_eeprom.c +7
-0@@ -176,6 +176,13 @@ static const struct i2c_eeprom_drv_data mc24aa02e48_data = { .offset_len = 1, }; +static const struct i2c_eeprom_drv_data mc24aa025e48_data = { + .size =256 , + .pagesize =16 , + .addr_offset_mask =0 , + .offset_len =1 , +}; +static const struct i2c_eeprom_drv_data atmel24c01a_data = { .size =128 , .pagesize =8 ,@@ -264,6 +271,7 @@ static const struct i2c_eeprom_drv_data atmel24c512_data = {Quoted 8 lines
drivers/misc/i2c_eeprom.c static const struct i2c_eeprom_drv_data atmel24c512_data = { · line 274
Quoted 4 lines
drivers/misc/i2c_eeprom.c +1
-0static const struct udevice_id i2c_eeprom_std_ids[] = { { .compatible ="i2c-eeprom" , (ulong)&eeprom_data }, { .compatible ="microchip,24aa02e48" , (ulong)&mc24aa02e48_data }, + { .compatible ="microchip,24aa025e48" , (ulong)&mc24aa025e48_data },As far as I can see, this is not a documented compatible string in the device tree bindings, which means u-boot is diverting again from its linux counterpart. (The same goes for the
24aa02e48).Hello Michael,
I know. But I thought it was the best way rather than reusing one existing compatible and forcing the page size. I can do that if you feel it's better.
Quoted 6 lines
I have to check how Linux is handling this eeprom as it's using the at24c32 compatible which is incorrect. It may be that the at24c32 compatible with additional properties makes the driver behaving as if it's a mc23aa025e48 . Which is not really right... (as the idea above)
Heiko, your thoughts ?
Best would be to find out, what linux do.
I think, you should have the same problem with linux?
So I think, best would be to introduce this 2 compatible strings also in linux and add of course the correct settings for "24aa025e48".
bye,
Heiko
Signature · 3 lines
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: [email protected]