Skip to contentSkip to conversation

arm: mvebu: clearfog_defconfig: enable setexpr command

PATCH In review Josef Schlehofer 2 participants 3 messages Apr 29, 2022 – May 2, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: mvebu: clearfog_defconfig: enable setexpr command

This command is useful in U-boot scripts and it is being used by OpenWrt bootscript for this board [1]. Otherwise shell scripting commands are enabled by default in cmd/Kconfig.

[1] https://github.com/openwrt/openwrt/blob/852126680e21edc71c0c66561ae5a6d7479dcc67/target/linux/mvebu/image/clearfog.bootscript#L7

[2] https://source.denx.de/u-boot/u-boot/-/blob/e95afa56753cebcd20a5114b6d121f281b789006/cmd/Kconfig#L1504

Fixes 0299c90f396c5b2971a4bac596339f4b03661c27 ("arm: mvebu: Add

SolidRun ClearFog Armada 38x initial support")

---
 configs/clearfog_defconfig | 1 -
 1 file changed, 1 deletion(-)
configs/clearfog_defconfig +0 -1
index 880f16a6e0..1e9c389deb 100644
@@ -34,7 +34,6 @@ CONFIG_CMD_MMC=y
 CONFIG_CMD_PCI=y
 CONFIG_CMD_SPI=y
 CONFIG_CMD_USB=y
-# CONFIG_CMD_SETEXPR is not set
 CONFIG_CMD_TFTPPUT=y
 CONFIG_CMD_CACHE=y
 CONFIG_CMD_TIME=y
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Josef Schlehofer

This command is useful in U-boot scripts and it is being used by OpenWrt bootscript for this board [1]. Otherwise shell scripting commands are enabled by default in cmd/Kconfig.

Quoted 8 lines

[1] https://github.com/openwrt/openwrt/blob/852126680e21edc71c0c66561ae5a6d7479dcc67/target/linux/mvebu/image/clearfog.bootscript#L7

[2] https://source.denx.de/u-boot/u-boot/-/blob/e95afa56753cebcd20a5114b6d121f281b789006/cmd/Kconfig#L1504

Fixes 0299c90f396c5b2971a4bac596339f4b03661c27 ("arm: mvebu: Add

SolidRun ClearFog Armada 38x initial support")

Thanks,
Stefan

Quoted 9 lines
---
  configs/clearfog_defconfig | 1 -
  1 file changed, 1 deletion(-)
configs/clearfog_defconfig +0 -0
index 880f16a6e0..1e9c389deb 100644

configs/clearfog_defconfig CONFIG_CMD_MMC=y · line 39

Quoted 7 lines
configs/clearfog_defconfig +0 -1
@@ -34,7 +34,6 @@ CONFIG_CMD_MMC=y
  CONFIG_CMD_PCI=y
  CONFIG_CMD_SPI=y
  CONFIG_CMD_USB=y
-# CONFIG_CMD_SETEXPR is not set
  CONFIG_CMD_TFTPPUT=y
  CONFIG_CMD_CACHE=y
  CONFIG_CMD_TIME=y

Viele Grüße,
Stefan Roese

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]
#2 lore raw
In reply to Josef Schlehofer
Quoted 4 lines · Josef Schlehofer

This command is useful in U-boot scripts and it is being used by OpenWrt bootscript for this board [1]. Otherwise shell scripting commands are enabled by default in cmd/Kconfig.

Quoted 8 lines

[1] https://github.com/openwrt/openwrt/blob/852126680e21edc71c0c66561ae5a6d7479dcc67/target/linux/mvebu/image/clearfog.bootscript#L7

[2] https://source.denx.de/u-boot/u-boot/-/blob/e95afa56753cebcd20a5114b6d121f281b789006/cmd/Kconfig#L1504

Fixes 0299c90f396c5b2971a4bac596339f4b03661c27 ("arm: mvebu: Add

SolidRun ClearFog Armada 38x initial support")

Applied to u-boot-marvell/master

Thanks,
Stefan

Quoted 9 lines
---
  configs/clearfog_defconfig | 1 -
  1 file changed, 1 deletion(-)
configs/clearfog_defconfig +0 -0
index 880f16a6e0..1e9c389deb 100644

configs/clearfog_defconfig CONFIG_CMD_MMC=y · line 39

Quoted 7 lines
configs/clearfog_defconfig +0 -1
@@ -34,7 +34,6 @@ CONFIG_CMD_MMC=y
  CONFIG_CMD_PCI=y
  CONFIG_CMD_SPI=y
  CONFIG_CMD_USB=y
-# CONFIG_CMD_SETEXPR is not set
  CONFIG_CMD_TFTPPUT=y
  CONFIG_CMD_CACHE=y
  CONFIG_CMD_TIME=y

Viele Grüße,
Stefan Roese

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]