arm64: dts: imx8mm-venice-gw7902: fix pcie bindings
Subsystems (2)
PATCH v2 1/1 arm64: dts: imx8mm-venice-gw7902: fix pcie bindings
Update the pcie bindings to the correct dt bindings:
pcie_phy:
- use pcie0_refclk
- add required clock-names
pcie:
- remove pcie_phy clock as it comes from phy driver
---
v2:
- update commit log
- add required clock-names to pcie_phy node
--- arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts +4 -3
@@ -595,7 +595,8 @@ &pcie_phy { fsl,refclk-pad-mode = <IMX8_PCIE_REFCLK_PAD_INPUT>; fsl,clkreq-unsupported; - clocks = <&clk IMX8MM_CLK_DUMMY>; + clocks = <&pcie0_refclk>; + clock-names = "ref"; status = "okay"; };
@@ -604,8 +605,8 @@ pinctrl-0 = <&pinctrl_pcie0>; reset-gpio = <&gpio4 5 GPIO_ACTIVE_LOW>; clocks = <&clk IMX8MM_CLK_PCIE1_ROOT>, <&clk IMX8MM_CLK_PCIE1_AUX>, - <&clk IMX8MM_CLK_DUMMY>, <&pcie0_refclk>; - clock-names = "pcie", "pcie_aux", "pcie_phy", "pcie_bus"; + <&pcie0_refclk>; + clock-names = "pcie", "pcie_aux", "pcie_bus"; assigned-clocks = <&clk IMX8MM_CLK_PCIE1_AUX>, <&clk IMX8MM_CLK_PCIE1_CTRL>; assigned-clock-rates = <10000000>, <250000000>;
Signature · 1 line
2.17.1
Hi Tim,
Quoted 9 lines · Tim Harvey
Update the pcie bindings to the correct dt bindings:
pcie_phy:
- usepcie0_refclk
- add required clock-names
pcie:
- removepcie_phyclock as it comes from phy driverSigned-off-by Tim Harvey <[email protected]>
It seems you missed the Fixes tag.
Quoted 12 lines · Fabio Estevam
Hi Tim,
Quoted 8 lines · Tim Harvey
Update the pcie bindings to the correct dt bindings:
pcie_phy:
- usepcie0_refclk
- add required clock-names
pcie:
- removepcie_phyclock as it comes from phy driver
Quoted 5 lines
Quoted 1 line
Signed-off-by Tim Harvey <[email protected]>It seems you missed the Fixes tag.
Reviewed-by Fabio Estevam <[email protected]>
Fabio,
it didn't really 'fix' anything but dt syntax. PCIe works without this patch.
Best Regards,
Tim
Shawn Guo
AppliedQuoted 8 lines · Tim Harvey
Update the pcie bindings to the correct dt bindings:
pcie_phy:
- usepcie0_refclk
- add required clock-names
pcie:
- removepcie_phyclock as it comes from phy driverSigned-off-by Tim Harvey <[email protected]>
Applied, thanks!