Krait Documentation conversion

PATCH Superseded Ansuel Smith 4 participants 12 messages Apr 30, 2022 – Jun 27, 2022

Subsystems (4)

Device tree bindings Arm Qualcomm mailing list Common clk Qualcomm clock drivers

lore

Share & tools

lore

Ansuel Smith

author

2022-04-30 13:09 UTC #0 lore raw

v2 cover Krait Documentation conversion

This series convert the krait-cc and the kpps-acc/gcc Documentation to yaml.

This series comes form a split of a bigger series that got too big and now hard to review.

While they are still more or less wrong and doesn't really reflect real driver implementation, they are converted to prepare for a fixup later when dts and driver are finally fixed. For now make a 1:1 conversion. The only change is an additional binding for the kpss-gcc Documentation that require the #clock-cells when clock-output-names is used.

v2:
- Fix bot error by adding missing #clock-cells

Changelog for previous series "Modernize rest of the krait drivers" that was split to smaller series (only Documentation changes):
v7:
- Rework kpss-gcc Documentation (split patch for pure conversion and tweaks)
v6:
- Address comments from Rob
- Fix warning from make dtbs_check
v5:
- Address comments from Krzysztof
v4:
- Fix more dt-bindings bug errors
v3:
- Split Documentation files for kpss and krait-cc
v2:
- fix missing new line on patch 16 (krait-cc patch)

Ansuel Smith (3):
dt-bindings: clock: Convert qcom,krait-cc to yaml
dt-bindings: arm: msm: Convert kpss-acc driver Documentation to yaml
dt-bindings: arm: msm: Convert kpss-gcc driver Documentation to yaml

 .../bindings/arm/msm/qcom,kpss-acc.txt        | 49 ----------
 .../bindings/arm/msm/qcom,kpss-acc.yaml       | 94 +++++++++++++++++++
 .../bindings/arm/msm/qcom,kpss-gcc.txt        | 44 ---------
 .../bindings/arm/msm/qcom,kpss-gcc.yaml       | 68 ++++++++++++++
 .../bindings/clock/qcom,krait-cc.txt          | 34 -------
 .../bindings/clock/qcom,krait-cc.yaml         | 59 ++++++++++++
 6 files changed, 221 insertions(+), 127 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.txt
 create mode 100644 Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.yaml
 delete mode 100644 Documentation/devicetree/bindings/arm/msm/qcom,kpss-gcc.txt
 create mode 100644 Documentation/devicetree/bindings/arm/msm/qcom,kpss-gcc.yaml
 delete mode 100644 Documentation/devicetree/bindings/clock/qcom,krait-cc.txt
 create mode 100644 Documentation/devicetree/bindings/clock/qcom,krait-cc.yaml

Signature · 1 line

2.34.1

Ansuel Smith

author

2022-04-30 13:09 UTC #1 lore raw

PATCH v2 1/3 dt-bindings: clock: Convert qcom,krait-cc to yaml

Convert qcom,krait-cc to yaml Documentation.

Signed-off-by Ansuel Smith <[email protected]>

Reviewed-by Krzysztof Kozlowski <[email protected]>

Acked-by Rob Herring <[email protected]>

---
 .../bindings/clock/qcom,krait-cc.txt          | 34 -----------
 .../bindings/clock/qcom,krait-cc.yaml         | 59 +++++++++++++++++++
 2 files changed, 59 insertions(+), 34 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/clock/qcom,krait-cc.txt
 create mode 100644 Documentation/devicetree/bindings/clock/qcom,krait-cc.yaml

Documentation/devicetree/bindings/clock/qcom,krait-cc.txt deleted +0 ~~-34~~

deleted file mode 100644
index 030ba60dab08..000000000000
@@ -1,34 +0,0 @@
-Krait Clock Controller
-
-PROPERTIES
-
-- compatible:
-	Usage: required
-	Value type: <string>
-	Definition: must be one of:
-			"qcom,krait-cc-v1"
-			"qcom,krait-cc-v2"
-
-- #clock-cells:
-	Usage: required
-	Value type: <u32>
-	Definition: must be 1
-
-- clocks:
-	Usage: required
-	Value type: <prop-encoded-array>
-	Definition: reference to the clock parents of hfpll, secondary muxes.
-
-- clock-names:
-	Usage: required
-	Value type: <stringlist>
-	Definition: must be "hfpll0", "hfpll1", "acpu0_aux", "acpu1_aux", "qsb".
-
-Example:
-
-	kraitcc: clock-controller {
-		compatible = "qcom,krait-cc-v1";
-		clocks = <&hfpll0>, <&hfpll1>, <&acpu0_aux>, <&acpu1_aux>, <qsb>;
-		clock-names = "hfpll0", "hfpll1", "acpu0_aux", "acpu1_aux", "qsb";
-		#clock-cells = <1>;
-	};

Documentation/devicetree/bindings/clock/qcom,krait-cc.yaml new file +59 -0

59 lines not on this page · raw message

Signature · 1 line

2.34.1

Ansuel Smith

author

2022-04-30 13:09 UTC #2 lore raw

PATCH v2 2/3 dt-bindings: arm: msm: Convert kpss-acc driver Documentation to yaml

In reply to Ansuel Smith

Convert kpss-acc driver Documentation to yaml.
The original Documentation was wrong all along. Fix it while we are converting it.
The example was wrong as kpss-acc-v2 should only expose the regs but we don't have any driver that expose additional clocks. The kpss-acc driver is only specific to v1. For this exact reason, limit all the additional bindings (clocks, clock-names, clock-output-names and #clock-cells) to v1 and also flag that these bindings should NOT be used for v2.

Signed-off-by Ansuel Smith <[email protected]>

Reviewed-by Krzysztof Kozlowski <[email protected]>

---
 .../bindings/arm/msm/qcom,kpss-acc.txt        | 49 ----------
 .../bindings/arm/msm/qcom,kpss-acc.yaml       | 94 +++++++++++++++++++
 2 files changed, 94 insertions(+), 49 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.txt
 create mode 100644 Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.yaml

Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.txt deleted +0 ~~-49~~

deleted file mode 100644
index 7f696362a4a1..000000000000
@@ -1,49 +0,0 @@
-Krait Processor Sub-system (KPSS) Application Clock Controller (ACC)
-
-The KPSS ACC provides clock, power domain, and reset control to a Krait CPU.
-There is one ACC register region per CPU within the KPSS remapped region as
-well as an alias register region that remaps accesses to the ACC associated
-with the CPU accessing the region.
-
-PROPERTIES
-
-- compatible:
-	Usage: required
-	Value type: <string>
-	Definition: should be one of:
-			"qcom,kpss-acc-v1"
-			"qcom,kpss-acc-v2"
-
-- reg:
-	Usage: required
-	Value type: <prop-encoded-array>
-	Definition: the first element specifies the base address and size of
-		    the register region. An optional second element specifies
-		    the base address and size of the alias register region.
-
-- clocks:
-        Usage: required
-        Value type: <prop-encoded-array>
-        Definition: reference to the pll parents.
-
-- clock-names:
-        Usage: required
-        Value type: <stringlist>
-        Definition: must be "pll8_vote", "pxo".
-
-- clock-output-names:
-	Usage: optional
-	Value type: <string>
-	Definition: Name of the output clock. Typically acpuX_aux where X is a
-		    CPU number starting at 0.
-
-Example:
-
-	clock-controller@2088000 {
-		compatible = "qcom,kpss-acc-v2";
-		reg = <0x02088000 0x1000>,
-		      <0x02008000 0x1000>;
-		clocks = <&gcc PLL8_VOTE>, <&gcc PXO_SRC>;
-		clock-names = "pll8_vote", "pxo";
-		clock-output-names = "acpu0_aux";
-	};

Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.yaml new file +94 -0

94 lines not on this page · raw message

Signature · 1 line

2.34.1

Ansuel Smith

author

2022-04-30 13:09 UTC #3 lore raw

PATCH v2 3/3 dt-bindings: arm: msm: Convert kpss-gcc driver Documentation to yaml

In reply to Ansuel Smith

Convert kpss-gcc driver Documentation to yaml.
Add #clock-cells additional binding to required bindings and example as it's a required binding for clock-output-names.

Signed-off-by Ansuel Smith <[email protected]>

---
 .../bindings/arm/msm/qcom,kpss-gcc.txt        | 44 ------------
 .../bindings/arm/msm/qcom,kpss-gcc.yaml       | 68 +++++++++++++++++++
 2 files changed, 68 insertions(+), 44 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/arm/msm/qcom,kpss-gcc.txt
 create mode 100644 Documentation/devicetree/bindings/arm/msm/qcom,kpss-gcc.yaml

Documentation/devicetree/bindings/arm/msm/qcom,kpss-gcc.txt deleted +0 ~~-44~~

deleted file mode 100644
index e628758950e1..000000000000
@@ -1,44 +0,0 @@
-Krait Processor Sub-system (KPSS) Global Clock Controller (GCC)
-
-PROPERTIES
-
-- compatible:
-	Usage: required
-	Value type: <string>
-	Definition: should be one of the following. The generic compatible
-			"qcom,kpss-gcc" should also be included.
-			"qcom,kpss-gcc-ipq8064", "qcom,kpss-gcc"
-			"qcom,kpss-gcc-apq8064", "qcom,kpss-gcc"
-			"qcom,kpss-gcc-msm8974", "qcom,kpss-gcc"
-			"qcom,kpss-gcc-msm8960", "qcom,kpss-gcc"
-
-- reg:
-	Usage: required
-	Value type: <prop-encoded-array>
-	Definition: base address and size of the register region
-
-- clocks:
-	Usage: required
-	Value type: <prop-encoded-array>
-	Definition: reference to the pll parents.
-
-- clock-names:
-	Usage: required
-	Value type: <stringlist>
-	Definition: must be "pll8_vote", "pxo".
-
-- clock-output-names:
-	Usage: required
-	Value type: <string>
-	Definition: Name of the output clock. Typically acpu_l2_aux indicating
-		    an L2 cache auxiliary clock.
-
-Example:
-
-	l2cc: clock-controller@2011000 {
-		compatible = "qcom,kpss-gcc-ipq8064", "qcom,kpss-gcc";
-		reg = <0x2011000 0x1000>;
-		clocks = <&gcc PLL8_VOTE>, <&gcc PXO_SRC>;
-		clock-names = "pll8_vote", "pxo";
-		clock-output-names = "acpu_l2_aux";
-	};

Documentation/devicetree/bindings/arm/msm/qcom,kpss-gcc.yaml new file +68 -0

68 lines not on this page · raw message

Signature · 1 line

2.34.1

Krzysztof Kozlowski

2022-04-30 14:40 UTC #4 lore raw

Re: [PATCH v2 3/3] dt-bindings: arm: msm: Convert kpss-gcc driver Documentation to yaml

Quoted 5 lines · Ansuel Smith

Convert kpss-gcc driver Documentation to yaml.
Add #clock-cells additional binding to required bindings and example as it's a required binding for clock-output-names.
Signed-off-by Ansuel Smith <[email protected]>

(...)

Quoted 15 lines

Documentation/devicetree/bindings/arm/msm/qcom,kpss-gcc.yaml new file +15 -0

+properties:
+  compatible:
+    items:
+      - enum:
+          - qcom,kpss-gcc-ipq8064
+          - qcom,kpss-gcc-apq8064
+          - qcom,kpss-gcc-msm8974
+          - qcom,kpss-gcc-msm8960
+      - const: qcom,kpss-gcc
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    items:

Documentation/devicetree/bindings/arm/msm/qcom,kpss-gcc.yaml line 40

Quoted 10 lines

Documentation/devicetree/bindings/arm/msm/qcom,kpss-gcc.yaml new file +10 -0

+      - description: phandle to pll8_vote
+      - description: phandle to pxo_board
+
+  clock-names:
+    items:
+      - const: pll8_vote
+      - const: pxo
+
+  clock-output-names:
+    const: acpu_l2_aux

It does not make sense having a constant output name. What is the meaning this property in such case? The original binding did not enforce it.

Best regards,
Krzysztof

Ansuel Smith

author

2022-04-30 14:50 UTC #5 lore raw

Re: [PATCH v2 3/3] dt-bindings: arm: msm: Convert kpss-gcc driver Documentation to yaml

Quoted 41 lines · Krzysztof Kozlowski

Quoted 5 lines · Ansuel Smith
Convert kpss-gcc driver Documentation to yaml.
Add #clock-cells additional binding to required bindings and example as it's a required binding for clock-output-names.
Signed-off-by Ansuel Smith <[email protected]>
(...)
Quoted 15 lines
Documentation/devicetree/bindings/arm/msm/qcom,kpss-gcc.yaml new file +15 -0
+properties:
+  compatible:
+    items:
+      - enum:
+          - qcom,kpss-gcc-ipq8064
+          - qcom,kpss-gcc-apq8064
+          - qcom,kpss-gcc-msm8974
+          - qcom,kpss-gcc-msm8960
+      - const: qcom,kpss-gcc
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    items:
Documentation/devicetree/bindings/arm/msm/qcom,kpss-gcc.yaml line 40
Quoted 10 lines
Documentation/devicetree/bindings/arm/msm/qcom,kpss-gcc.yaml new file +10 -0
+      - description: phandle to pll8_vote
+      - description: phandle to pxo_board
+
+  clock-names:
+    items:
+      - const: pll8_vote
+      - const: pxo
+
+  clock-output-names:
+    const: acpu_l2_aux
It does not make sense having a constant output name. What is the meaning this property in such case? The original binding did not enforce it.

Quoted 2 lines

Best regards,
Krzysztof

Mh. Should I just drop the const and put a description referring to an advised name? The driver with the kpss-gcc hardcode the name to acpu_l2_aux that's why I thought it was a correct conversion using a const but I assume this is another problem of not making a correct 1:1 conversion and adding fixes on pure conversion.
Think I should drop it and put a description to it. (and then later fix it when I will push the other series with all the tweaks)

What do you think?

Signature · 1 line

	Ansuel

Krzysztof Kozlowski

2022-05-01 08:26 UTC #6 lore raw

Re: [PATCH v2 3/3] dt-bindings: arm: msm: Convert kpss-gcc driver Documentation to yaml

Quoted 42 lines · Ansuel Smith

Quoted 41 lines · Krzysztof Kozlowski
Quoted 5 lines · Ansuel Smith
Convert kpss-gcc driver Documentation to yaml.
Add #clock-cells additional binding to required bindings and example as it's a required binding for clock-output-names.
Signed-off-by Ansuel Smith <[email protected]>
(...)
Quoted 15 lines
Documentation/devicetree/bindings/arm/msm/qcom,kpss-gcc.yaml new file +15 -0
+properties:
+  compatible:
+    items:
+      - enum:
+          - qcom,kpss-gcc-ipq8064
+          - qcom,kpss-gcc-apq8064
+          - qcom,kpss-gcc-msm8974
+          - qcom,kpss-gcc-msm8960
+      - const: qcom,kpss-gcc
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    items:
Documentation/devicetree/bindings/arm/msm/qcom,kpss-gcc.yaml line 40
Quoted 10 lines
Documentation/devicetree/bindings/arm/msm/qcom,kpss-gcc.yaml new file +10 -0
+      - description: phandle to pll8_vote
+      - description: phandle to pxo_board
+
+  clock-names:
+    items:
+      - const: pll8_vote
+      - const: pxo
+
+  clock-output-names:
+    const: acpu_l2_aux
It does not make sense having a constant output name. What is the meaning this property in such case? The original binding did not enforce it.

Quoted 8 lines

Quoted 2 lines
Best regards,
Krzysztof
Mh. Should I just drop the const and put a description referring to an advised name? The driver with the kpss-gcc hardcode the name to acpu_l2_aux that's why I thought it was a correct conversion using a const but I assume this is another problem of not making a correct 1:1 conversion and adding fixes on pure conversion.

Hard-coding a name by implementation is not a reason to put that name in DTS. DTS is not a place for values stored in the driver.

Quoted 2 lines

Think I should drop it and put a description to it. (and then later fix it when I will push the other series with all the tweaks)

The driver kpss-gcc does not use this property at all, so I am not sure if there is a point to even keep it. Any other user of bindings makes use of the property?

Best regards,
Krzysztof

Ansuel Smith

author

2022-05-02 10:59 UTC #7 lore raw

Re: [PATCH v2 3/3] dt-bindings: arm: msm: Convert kpss-gcc driver Documentation to yaml

Quoted 58 lines · Krzysztof Kozlowski

Quoted 42 lines · Ansuel Smith
Quoted 41 lines · Krzysztof Kozlowski
Quoted 5 lines · Ansuel Smith
Convert kpss-gcc driver Documentation to yaml.
Add #clock-cells additional binding to required bindings and example as it's a required binding for clock-output-names.
Signed-off-by Ansuel Smith <[email protected]>
(...)
Quoted 15 lines
Documentation/devicetree/bindings/arm/msm/qcom,kpss-gcc.yaml new file +15 -0
+properties:
+  compatible:
+    items:
+      - enum:
+          - qcom,kpss-gcc-ipq8064
+          - qcom,kpss-gcc-apq8064
+          - qcom,kpss-gcc-msm8974
+          - qcom,kpss-gcc-msm8960
+      - const: qcom,kpss-gcc
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    items:
Documentation/devicetree/bindings/arm/msm/qcom,kpss-gcc.yaml line 40
Quoted 10 lines
Documentation/devicetree/bindings/arm/msm/qcom,kpss-gcc.yaml new file +10 -0
+      - description: phandle to pll8_vote
+      - description: phandle to pxo_board
+
+  clock-names:
+    items:
+      - const: pll8_vote
+      - const: pxo
+
+  clock-output-names:
+    const: acpu_l2_aux
It does not make sense having a constant output name. What is the meaning this property in such case? The original binding did not enforce it.
Quoted 8 lines
Quoted 2 lines
Best regards,
Krzysztof
Mh. Should I just drop the const and put a description referring to an advised name? The driver with the kpss-gcc hardcode the name to acpu_l2_aux that's why I thought it was a correct conversion using a const but I assume this is another problem of not making a correct 1:1 conversion and adding fixes on pure conversion.
Hard-coding a name by implementation is not a reason to put that name in DTS. DTS is not a place for values stored in the driver.
Quoted 2 lines
Think I should drop it and put a description to it. (and then later fix it when I will push the other series with all the tweaks)

Quoted 7 lines

The driver kpss-gcc does not use this property at all, so I am not sure if there is a point to even keep it. Any other user of bindings makes use of the property?
Best regards,
Krzysztof

The idea is that you put the clk name in 'clock-output-names' and the driver needs to have support for it (and set the clk name based on the name defined in the dts)

This driver doesn't have support for it and is actually hardcoded. So you are right and I should just drop it.

But now another question... Since #clock-cells was added as a requirement for clock-output-names, should I drop also that?

In theory #clock-cells should always be declared for clock providers, is it right to add it in the conversion commit or I should put this change in another commit? (since it's now an addition and now something required to fix a bot warning)

Signature · 1 line

	Ansuel

Krzysztof Kozlowski

2022-05-02 20:18 UTC #8 lore raw

Re: [PATCH v2 3/3] dt-bindings: arm: msm: Convert kpss-gcc driver Documentation to yaml

Quoted 8 lines · Ansuel Smith

The idea is that you put the clk name in 'clock-output-names' and the driver needs to have support for it (and set the clk name based on the name defined in the dts)
This driver doesn't have support for it and is actually hardcoded. So you are right and I should just drop it.

Quoted 7 lines

But now another question... Since #clock-cells was added as a requirement for clock-output-names, should I drop also that?
In theory #clock-cells should always be declared for clock providers, is it right to add it in the conversion commit or I should put this change in another commit? (since it's now an addition and now something required to fix a bot warning)

These are not the best bindings to convert, if you are not into the qcom DTS and drivers. :)

It looks like the bindings were added to match current Linux implementation and in this implementation the device is not used in DTS as a clock provider (even though it registers a clock) but as a syscon. I am not even sure if it is used as a clock provider outside of DTS (through using a fixed clock name in some clock consumer).

Probably this should be made either a proper clock controller or something stripped down to the point matching current usage (accepting the fact that bindings are incomplete). Anyway your choice should be made according to how this device and its driver fit to entire system. IOW, it's not a simple binding conversion and you should not just convert it to make dtbs_check happy.

Best regards,
Krzysztof

Ansuel Smith

author

2022-05-02 20:27 UTC #9 lore raw

Re: [PATCH v2 3/3] dt-bindings: arm: msm: Convert kpss-gcc driver Documentation to yaml

Quoted 12 lines · Krzysztof Kozlowski

Quoted 11 lines · Ansuel Smith
The idea is that you put the clk name in 'clock-output-names' and the driver needs to have support for it (and set the clk name based on the name defined in the dts)
This driver doesn't have support for it and is actually hardcoded. So you are right and I should just drop it.
But now another question... Since #clock-cells was added as a requirement for clock-output-names, should I drop also that?

Quoted 8 lines

Quoted 4 lines
In theory #clock-cells should always be declared for clock providers, is it right to add it in the conversion commit or I should put this change in another commit? (since it's now an addition and now something required to fix a bot warning)
These are not the best bindings to convert, if you are not into the qcom DTS and drivers. :)

As I said some times ago main problem of these thing is that they are ancient and they were not in a good state from the start. So it's hard to fix this in a sane way. (i'm trying tho so sorry for any mess i'm making in the process)

Quoted 6 lines

It looks like the bindings were added to match current Linux implementation and in this implementation the device is not used in DTS as a clock provider (even though it registers a clock) but as a syscon. I am not even sure if it is used as a clock provider outside of DTS (through using a fixed clock name in some clock consumer).

Quoted 6 lines

Probably this should be made either a proper clock controller or something stripped down to the point matching current usage (accepting the fact that bindings are incomplete). Anyway your choice should be made according to how this device and its driver fit to entire system. IOW, it's not a simple binding conversion and you should not just convert it to make dtbs_check happy.

I wonder if I should just drop this patch from the series and push it later in another series as a rework directly (with also the other relevant changes to fix the current problem we have with all the dts).

The intention of this series was to try to push small changes that could be merged in a short time.

Quoted 3 lines

Best regards,
Krzysztof

Signature · 1 line

	Ansuel

Bjorn Andersson

2022-06-27 20:55 UTC #10 lore raw

Re: [PATCH v2 3/3] dt-bindings: arm: msm: Convert kpss-gcc driver Documentation to yaml

In reply to Ansuel Smith

Quoted 53 lines · Ansuel Smith

Quoted 41 lines · Krzysztof Kozlowski
Quoted 5 lines · Ansuel Smith
Convert kpss-gcc driver Documentation to yaml.
Add #clock-cells additional binding to required bindings and example as it's a required binding for clock-output-names.
Signed-off-by Ansuel Smith <[email protected]>
(...)
Quoted 15 lines
Documentation/devicetree/bindings/arm/msm/qcom,kpss-gcc.yaml new file +15 -0
+properties:
+  compatible:
+    items:
+      - enum:
+          - qcom,kpss-gcc-ipq8064
+          - qcom,kpss-gcc-apq8064
+          - qcom,kpss-gcc-msm8974
+          - qcom,kpss-gcc-msm8960
+      - const: qcom,kpss-gcc
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    items:
Documentation/devicetree/bindings/arm/msm/qcom,kpss-gcc.yaml line 40
Quoted 10 lines
Documentation/devicetree/bindings/arm/msm/qcom,kpss-gcc.yaml new file +10 -0
+      - description: phandle to pll8_vote
+      - description: phandle to pxo_board
+
+  clock-names:
+    items:
+      - const: pll8_vote
+      - const: pxo
+
+  clock-output-names:
+    const: acpu_l2_aux
It does not make sense having a constant output name. What is the meaning this property in such case? The original binding did not enforce it.
Quoted 2 lines
Best regards,
Krzysztof
Mh. Should I just drop the const and put a description referring to an advised name? The driver with the kpss-gcc hardcode the name to acpu_l2_aux that's why I thought it was a correct conversion using a const but I assume this is another problem of not making a correct 1:1 conversion and adding fixes on pure conversion.
Think I should drop it and put a description to it. (and then later fix it when I will push the other series with all the tweaks)

Quoted 2 lines

What do you think?

The typical reason for using clock-output-names is that we have some consumer that finds the clock based on global name lookup. Over time we've been moving these to use .fw_name or .index based lookup, which removes this problem.

But I don't see that being the case here. So my suggestion is that you just drop clock-output-names from the binding, which will solve Krzysztof's objection.

From there we can review what needs to be done in the Linux driver to work with the improved binding.

Regards,
Bjorn

Rob Herring

maintainer

2022-05-02 15:33 UTC #11 lore raw

Re: [PATCH v2 3/3] dt-bindings: arm: msm: Convert kpss-gcc driver Documentation to yaml

In reply to Ansuel Smith

Quoted 4 lines · Ansuel Smith

Convert kpss-gcc driver Documentation to yaml.
Add #clock-cells additional binding to required bindings and example as it's a required binding for clock-output-names.

Quoted 8 lines

Signed-off-by Ansuel Smith <[email protected]>

---
 .../bindings/arm/msm/qcom,kpss-gcc.txt        | 44 ------------
 .../bindings/arm/msm/qcom,kpss-gcc.yaml       | 68 +++++++++++++++++++
 2 files changed, 68 insertions(+), 44 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/arm/msm/qcom,kpss-gcc.txt
 create mode 100644 Documentation/devicetree/bindings/arm/msm/qcom,kpss-gcc.yaml

Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings.

Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future.

Full log is available here: https://patchwork.ozlabs.org/patch/

clock-controller@2011000: '#clock-cells' is a required property

	arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
	arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
	arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
	arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dtb
	arch/arm/boot/dts/qcom-ipq8064-ap148.dtb
	arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb
	arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dtb
	arch/arm/boot/dts/qcom-msm8960-cdp.dtb

clock-controller@2011000: 'clock-names' is a required property

	arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
	arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
	arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
	arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dtb
	arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dtb
	arch/arm/boot/dts/qcom-msm8960-cdp.dtb

clock-controller@2011000: 'clock-output-names' is a required property

	arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
	arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
	arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
	arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dtb
	arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dtb
	arch/arm/boot/dts/qcom-msm8960-cdp.dtb

clock-controller@2011000: 'clocks' is a required property

	arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
	arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
	arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
	arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dtb
	arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dtb
	arch/arm/boot/dts/qcom-msm8960-cdp.dtb

clock-controller@2011000: compatible:0: 'qcom,kpss-gcc' is not one of ['qcom,kpss-gcc-ipq8064', 'qcom,kpss-gcc-apq8064', 'qcom,kpss-gcc-msm8974', 'qcom,kpss-gcc-msm8960']

	arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
	arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
	arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
	arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dtb
	arch/arm/boot/dts/qcom-ipq8064-ap148.dtb
	arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb
	arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dtb
	arch/arm/boot/dts/qcom-msm8960-cdp.dtb

clock-controller@2011000: compatible:1: 'qcom,kpss-gcc' was expected

	arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
	arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
	arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
	arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dtb
	arch/arm/boot/dts/qcom-ipq8064-ap148.dtb
	arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb
	arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dtb
	arch/arm/boot/dts/qcom-msm8960-cdp.dtb

clock-controller@2082000: '#clock-cells' is a required property

	arch/arm/boot/dts/qcom-apq8060-dragonboard.dtb
	arch/arm/boot/dts/qcom-msm8660-surf.dtb

clock-controller@2082000: 'clock-names' is a required property

	arch/arm/boot/dts/qcom-apq8060-dragonboard.dtb
	arch/arm/boot/dts/qcom-msm8660-surf.dtb

clock-controller@2082000: 'clock-output-names' is a required property

	arch/arm/boot/dts/qcom-apq8060-dragonboard.dtb
	arch/arm/boot/dts/qcom-msm8660-surf.dtb

clock-controller@2082000: 'clocks' is a required property

	arch/arm/boot/dts/qcom-apq8060-dragonboard.dtb
	arch/arm/boot/dts/qcom-msm8660-surf.dtb

clock-controller@2082000: compatible:0: 'qcom,kpss-gcc' is not one of ['qcom,kpss-gcc-ipq8064', 'qcom,kpss-gcc-apq8064', 'qcom,kpss-gcc-msm8974', 'qcom,kpss-gcc-msm8960']

	arch/arm/boot/dts/qcom-apq8060-dragonboard.dtb
	arch/arm/boot/dts/qcom-msm8660-surf.dtb

clock-controller@2082000: compatible:1: 'qcom,kpss-gcc' was expected

	arch/arm/boot/dts/qcom-apq8060-dragonboard.dtb
	arch/arm/boot/dts/qcom-msm8660-surf.dtb