Skip to contentSkip to conversation

arm64: dts: rockchip: enable otg/drd operation of usb_host0_xhci in rk3568

PATCH In review Michael Riesch 2 participants 3 messages May 2, 2022 – May 9, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 arm64: dts: rockchip: enable otg/drd operation of usb_host0_xhci in rk3568

This USB 3.0 controller of the Rockchip RK3568 is capable of OTG/DRD operation. Enable it in the device tree.

---
v2:
- As pointed out by Nicolas, this is RK3568 specific. Moved change to rk3568.dtsi.

 arch/arm64/boot/dts/rockchip/rk3568.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/rockchip/rk3568.dtsi +1 -0
index 5eafddf62edc..bbfe8f3d68b7 100644
@@ -134,6 +134,7 @@ power-domain@RK3568_PD_PIPE {
 };
 
 &usb_host0_xhci {
+	dr_mode = "otg";
 	phys = <&usb2phy0_otg>, <&combphy0 PHY_TYPE_USB3>;
 	phy-names = "usb2-phy", "usb3-phy";
 };

--
2.30.2

#1 lore raw
Quoted 3 lines · Michael Riesch

This USB 3.0 controller of the Rockchip RK3568 is capable of OTG/DRD operation. Enable it in the device tree.

I think I missed a conversation here, the xhci0 controller is the otg port for both rk3566 and rk3568. The only difference is on rk3566 it is a usb2 only controller, where on rk3568 it is also a usb3 controller. It was set to host only because my original phy patches didn't support otg mode. Since then Samuel's series fixed that.

Your original patch was correct.

Always,
Peter

Quoted 23 lines

---
v2:
- As pointed out by Nicolas, this is RK3568 specific. Moved change to rk3568.dtsi.

 arch/arm64/boot/dts/rockchip/rk3568.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/rockchip/rk3568.dtsi +1 -1
index 5eafddf62edc..bbfe8f3d68b7 100644
@@ -134,6 +134,7 @@ power-domain@RK3568_PD_PIPE {
 };
 
 &usb_host0_xhci {
+       dr_mode = "otg";
        phys = <&usb2phy0_otg>, <&combphy0 PHY_TYPE_USB3>;
        phy-names = "usb2-phy", "usb3-phy";
 };
--
Quoted 1 line

2.30.2

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip

#2 lore raw

Hello Peter,

Quoted 6 lines · Peter Geis
Quoted 3 lines · Michael Riesch

This USB 3.0 controller of the Rockchip RK3568 is capable of OTG/DRD operation. Enable it in the device tree.

Quoted 7 lines

I think I missed a conversation here, the xhci0 controller is the otg port for both rk3566 and rk3568. The only difference is on rk3566 it is a usb2 only controller, where on rk3568 it is also a usb3 controller. It was set to host only because my original phy patches didn't support otg mode. Since then Samuel's series fixed that.

Your original patch was correct.

I have already replied to v1, but at this point I would like to
- thank you for pointing this out
- and send a friendly reminder to Heiko: please apply v1 of this patch :-)

Thanks and best regards,
Michael

Quoted 21 lines

Always,
Peter

Quoted 17 lines

---
v2:
- As pointed out by Nicolas, this is RK3568 specific. Moved change to rk3568.dtsi.

 arch/arm64/boot/dts/rockchip/rk3568.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/rockchip/rk3568.dtsi +0 -0
index 5eafddf62edc..bbfe8f3d68b7 100644
@@ -134,6 +134,7 @@ power-domain@RK3568_PD_PIPE {
 };
 
Quoted 7 lines
Quoted 7 lines
arch/arm64/boot/dts/rockchip/rk3568.dtsi +1 -1
 &usb_host0_xhci {
+       dr_mode = "otg";
        phys = <&usb2phy0_otg>, <&combphy0 PHY_TYPE_USB3>;
        phy-names = "usb2-phy", "usb3-phy";
 };
--

2.30.2

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip