Skip to contentSkip to conversation

tools/xenstore: don't let special watches be children of /

PATCH In review Juergen Gross 2 participants 2 messages May 2, 2022 – May 5, 2022

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 tools/xenstore: don't let special watches be children of /

When firing special watches (e.g. "@releaseDomain"), they will be regarded to be valid children of the "/" node. So a domain having registered a watch for "/" and having the privilege to receive the special watches will receive those special watch events for the registered "/" watch.

Fix that by calling the related fire_watches() with the "exact" parameter set to true, causing a mismatch for the "/" node.

---
V2:
- use Rapahael's amazon mail address

---
 tools/xenstore/xenstored_domain.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
tools/xenstore/xenstored_domain.c +3 -3
index ae065fcbee..80ba1d627b 100644
@@ -231,7 +231,7 @@ static int destroy_domain(void *_domain)
 			unmap_interface(domain->interface);
 	}
 
-	fire_watches(NULL, domain, "@releaseDomain", NULL, false, NULL);
+	fire_watches(NULL, domain, "@releaseDomain", NULL, true, NULL);
 
 	wrl_domain_destroy(domain);
 
@@ -282,7 +282,7 @@ void check_domains(void)
 	}
 
 	if (notify)
-		fire_watches(NULL, NULL, "@releaseDomain", NULL, false, NULL);
+		fire_watches(NULL, NULL, "@releaseDomain", NULL, true, NULL);
 }
 
 /* We scan all domains rather than use the information given here. */
@@ -495,7 +495,7 @@ static struct domain *introduce_domain(const void *ctx,
 
 		if (!is_master_domain && !restore)
 			fire_watches(NULL, ctx, "@introduceDomain", NULL,
-				     false, NULL);
+				     true, NULL);
 	} else {
 		/* Use XS_INTRODUCE for recreating the xenbus event-channel. */
 		if (domain->port)
Signature · 1 line
2.34.1
Reviewed-by on v2 1/1
#1 lore raw

Hi Juergen,

Quoted 6 lines · Juergen Gross

When firing special watches (e.g. "@releaseDomain"), they will be regarded to be valid children of the "/" node. So a domain having registered a watch for "/" and having the privilege to receive the special watches will receive those special watch events for the registered "/" watch.

Quoted 6 lines

Fix that by calling the related fire_watches() with the "exact" parameter set to true, causing a mismatch for the "/" node.

And commited it.

Cheers,

Signature · 1 line
Julien Grall