Mediatek SCP dt-binding tweaks
Subsystems (3)
v2 cover Mediatek SCP dt-binding tweaks
Two simple patches for the Mediatek SCP dt-binding. The first fixes the reg/reg-names property while the second adds a new optional memory-region property.
v1: https://lore.kernel.org/all/[email protected]
Changes in v2:
- Dropped type and description from memory-region since it's a well-known property
- Set memory-region maxItems to 1
Nícolas F. R. A. Prado (2):
dt-bindings: remoteproc: mediatek: Fix optional reg-names for mtk,scp
dt-bindings: remoteproc: mediatek: Add optional memory-region to
mtk,scp
.../devicetree/bindings/remoteproc/mtk,scp.yaml | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-)
Signature · 1 line
2.36.0
PATCH v2 1/2 dt-bindings: remoteproc: mediatek: Fix optional reg-names for mtk,scp
The SCP has three memory regions: sram, l1tcm and cfg. Only sram is required, the other two are optional. Fix the dt-binding so that the optional regions can be omitted and passed in any order.
Also add the missing minItems to the reg property and update the description.
---
(no changes since v1)
.../devicetree/bindings/remoteproc/mtk,scp.yaml | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml +9 -3
@@ -24,14 +24,20 @@ properties: reg: description: Should contain the address ranges for memory regions SRAM, CFG, and - L1TCM. + L1TCM. Only SRAM is required, while CFG and L1TCM are optional. + minItems: 1 maxItems: 3 reg-names: + minItems: 1 items: - const: sram - - const: cfg - - const: l1tcm + - enum: + - l1tcm + - cfg + - enum: + - l1tcm + - cfg clocks: description:
Signature · 1 line
2.36.0
Re: [PATCH v2 1/2] dt-bindings: remoteproc: mediatek: Fix optional reg-names for mtk,scp
Quoted 3 lines · Nícolas F. R. A. Prado
The SCP has three memory regions: sram, l1tcm and cfg. Only sram is required, the other two are optional. Fix the dt-binding so that the optional regions can be omitted and passed in any order.
I commented for v1 - order is strict, so no for this change.
Quoted 28 lines
Also add the missing minItems to the reg property and update the description.
Signed-off-by Nícolas F. R. A. Prado <[email protected]>---
(no changes since v1)
.../devicetree/bindings/remoteproc/mtk,scp.yaml | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-)Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml +3
-1@@ -24,14 +24,20 @@ properties: reg: description: Should contain the address ranges for memory regions SRAM, CFG, and - L1TCM. + L1TCM. Only SRAM is required, while CFG and L1TCM are optional. + minItems: 1 maxItems: 3 reg-names: + minItems: 1
Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml properties: · line 40
Quoted 10 lines
Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml +6
-2items: - const: sram - - const: cfg - - const: l1tcm + - enum: + - l1tcm + - cfg + - enum: + - l1tcm + - cfg
Nope.
Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml properties: · line 43
Quoted 3 lines
Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml +0
-0clocks: description:
Best regards,
Krzysztof
PATCH v2 2/2 dt-bindings: remoteproc: mediatek: Add optional memory-region to mtk,scp
In reply to Nícolas F. R. A. PradoThe SCP co-processor can optionally be passed a reserved memory region to use. Add this property in the dt-binding.
---
I left out Angelo's R-b since of the 3 lines in the patch from v1, only 1 is left.
Changes in v2:
- Dropped type and description since it's a well-known property
- Set maxItems to 1
Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 3 +++ 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml +3 -0
@@ -51,6 +51,9 @@ properties: interrupts: maxItems: 1 + memory-region: + maxItems: 1 + required: - compatible - reg
Signature · 1 line
2.36.0
Re: [PATCH v2 2/2] dt-bindings: remoteproc: mediatek: Add optional memory-region to mtk,scp
Quoted 9 lines · Nícolas F. R. A. Prado
The SCP co-processor can optionally be passed a reserved memory region to use. Add this property in the dt-binding.
Signed-off-by Nícolas F. R. A. Prado <[email protected]>---
I left out Angelo's R-b since of the 3 lines in the patch from v1, only 1 is left.
Quoted 7 lines
Changes in v2:
- Dropped type and description since it's a well-known property
- Set maxItems to 1Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 3 +++ 1 file changed, 3 insertions(+)
Re: [PATCH v2 2/2] dt-bindings: remoteproc: mediatek: Add optional memory-region to mtk,scp
Il 03/05/22 16:16, Rob Herring ha scritto:
Quoted 14 lines · Nícolas F. R. A. Prado
Quoted 13 lines
The SCP co-processor can optionally be passed a reserved memory region to use. Add this property in the dt-binding.
Signed-off-by Nícolas F. R. A. Prado <[email protected]>---
I left out Angelo's R-b since of the 3 lines in the patch from v1, only 1 is left.Changes in v2:
- Dropped type and description since it's a well-known property
- Set maxItems to 1
Quoted 5 lines
Quoted 3 lines
Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 3 +++ 1 file changed, 3 insertions(+)Acked-by Rob Herring <[email protected]>