Skip to contentSkip to conversation

vhost-user: Use correct macro name TARGET_PPC64

PATCH In review Murilo Opsfelder Araujo 4 participants 6 messages May 3, 2022 – May 4, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 vhost-user: Use correct macro name TARGET_PPC64

The correct name of the macro is TARGET_PPC64.

Fixes 27598393a232 ("Lift max memory slots limit imposed by vhost-user")
Cc Raphael Norwitz <[email protected]>
Cc Peter Turschmid <[email protected]>
---
 hw/virtio/vhost-user.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/virtio/vhost-user.c +1 -1
index 9c4f84f35f..e356c72c81 100644
@@ -51,7 +51,7 @@
 #include "hw/acpi/acpi.h"
 #define VHOST_USER_MAX_RAM_SLOTS ACPI_MAX_RAM_SLOTS
 
-#elif defined(TARGET_PPC) || defined(TARGET_PPC_64)
+#elif defined(TARGET_PPC) || defined(TARGET_PPC64)
 #include "hw/ppc/spapr.h"
 #define VHOST_USER_MAX_RAM_SLOTS SPAPR_MAX_RAM_SLOTS
 
Signature · 1 line
2.35.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Murilo Opsfelder Araujo

The correct name of the macro is TARGET_PPC64.

Fixes 27598393a232 ("Lift max memory slots limit imposed by vhost-user")
Cc Raphael Norwitz <[email protected]>
Cc Peter Turschmid <[email protected]>

---

Quoted 16 lines
  hw/virtio/vhost-user.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
hw/virtio/vhost-user.c +1 -1
index 9c4f84f35f..e356c72c81 100644
@@ -51,7 +51,7 @@
  #include "hw/acpi/acpi.h"
  #define VHOST_USER_MAX_RAM_SLOTS ACPI_MAX_RAM_SLOTS
 
-#elif defined(TARGET_PPC) || defined(TARGET_PPC_64)
+#elif defined(TARGET_PPC) || defined(TARGET_PPC64)
  #include "hw/ppc/spapr.h"
  #define VHOST_USER_MAX_RAM_SLOTS SPAPR_MAX_RAM_SLOTS
 
#2 lore raw
In reply to Murilo Opsfelder Araujo

Michael,

I'll send a PR in the next few days. This change seems trivial enough to me to push via the PPC64 tree.

Let me know if you're ok with that or if you want to pick it via the vhost tree.

Thanks,

Daniel

Quoted 24 lines · Murilo Opsfelder Araujo

The correct name of the macro is TARGET_PPC64.

Fixes 27598393a232 ("Lift max memory slots limit imposed by vhost-user")
Cc Raphael Norwitz <[email protected]>
Cc Peter Turschmid <[email protected]>
---
  hw/virtio/vhost-user.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
hw/virtio/vhost-user.c +1 -1
index 9c4f84f35f..e356c72c81 100644
@@ -51,7 +51,7 @@
  #include "hw/acpi/acpi.h"
  #define VHOST_USER_MAX_RAM_SLOTS ACPI_MAX_RAM_SLOTS
 
-#elif defined(TARGET_PPC) || defined(TARGET_PPC_64)
+#elif defined(TARGET_PPC) || defined(TARGET_PPC64)
  #include "hw/ppc/spapr.h"
  #define VHOST_USER_MAX_RAM_SLOTS SPAPR_MAX_RAM_SLOTS
 
Reviewed-by on v1 1/1
#3 lore raw
In reply to Murilo Opsfelder Araujo
Quoted 7 lines · Murilo Opsfelder Araujo

The correct name of the macro is TARGET_PPC64.

Fixes 27598393a232 ("Lift max memory slots limit imposed by vhost-user")
Cc Raphael Norwitz <[email protected]>
Cc Peter Turschmid <[email protected]>

ok to merge through the ppc tree

Quoted 19 lines
---
 hw/virtio/vhost-user.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/virtio/vhost-user.c +1 -1
index 9c4f84f35f..e356c72c81 100644
@@ -51,7 +51,7 @@
 #include "hw/acpi/acpi.h"
 #define VHOST_USER_MAX_RAM_SLOTS ACPI_MAX_RAM_SLOTS
 
-#elif defined(TARGET_PPC) || defined(TARGET_PPC_64)
+#elif defined(TARGET_PPC) || defined(TARGET_PPC64)
 #include "hw/ppc/spapr.h"
 #define VHOST_USER_MAX_RAM_SLOTS SPAPR_MAX_RAM_SLOTS
 
Signature · 1 line
2.35.1
#4 lore raw
Quoted 9 lines · Michael S. Tsirkin
Quoted 7 lines · Murilo Opsfelder Araujo

The correct name of the macro is TARGET_PPC64.

Fixes 27598393a232 ("Lift max memory slots limit imposed by vhost-user")
Cc Raphael Norwitz <[email protected]>
Cc Peter Turschmid <[email protected]>
Quoted 3 lines

ok to merge through the ppc tree

Thanks for the r-b. Queued in gitlab.com/danielhb/qemu/tree/ppc-next.

Daniel

Quoted 22 lines
Quoted 20 lines
---
  hw/virtio/vhost-user.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
hw/virtio/vhost-user.c +1 -1
index 9c4f84f35f..e356c72c81 100644
@@ -51,7 +51,7 @@
  #include "hw/acpi/acpi.h"
  #define VHOST_USER_MAX_RAM_SLOTS ACPI_MAX_RAM_SLOTS
 
-#elif defined(TARGET_PPC) || defined(TARGET_PPC_64)
+#elif defined(TARGET_PPC) || defined(TARGET_PPC64)
  #include "hw/ppc/spapr.h"
  #define VHOST_USER_MAX_RAM_SLOTS SPAPR_MAX_RAM_SLOTS
 
Signature · 1 line
2.35.1
Reviewed-by on v1 1/1
#5 lore raw

Re: [PATCH] vhost-user: Use correct macro name TARGET_PPC64g

In reply to Murilo Opsfelder Araujo
Quoted 7 lines · Murilo Opsfelder Araujo

The correct name of the macro is TARGET_PPC64.

Fixes 27598393a232 ("Lift max memory slots limit imposed by vhost-user")
Cc Raphael Norwitz <[email protected]>
Cc Peter Turschmid <[email protected]>
Quoted 20 lines
---
 hw/virtio/vhost-user.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/virtio/vhost-user.c +1 -1
index 9c4f84f35f..e356c72c81 100644
@@ -51,7 +51,7 @@
 #include "hw/acpi/acpi.h"
 #define VHOST_USER_MAX_RAM_SLOTS ACPI_MAX_RAM_SLOTS
 
-#elif defined(TARGET_PPC) || defined(TARGET_PPC_64)
+#elif defined(TARGET_PPC) || defined(TARGET_PPC64)
 #include "hw/ppc/spapr.h"
 #define VHOST_USER_MAX_RAM_SLOTS SPAPR_MAX_RAM_SLOTS
 
Signature · 1 line
2.35.1