Skip to contentSkip to conversation

Mediatek SCP dt-binding tweaks

PATCH Superseded Nícolas F. R. A. Prado 3 participants 5 messages May 3, 2022 – May 5, 2022

Subsystems (3)

v3 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

v3 cover Mediatek SCP dt-binding tweaks

Two simple patches for the Mediatek SCP dt-binding. The first fixes the reg/reg-names property while the second adds a new optional memory-region property.

v2: https://lore.kernel.org/all/[email protected]
v1: https://lore.kernel.org/all/[email protected]

Changes in v3:
- Made the cfg reg required again. After looking again into the mtk-scp driver, only l1tcm is optional.

Changes in v2:
- Dropped type and description from memory-region since it's a well-known property
- Set memory-region maxItems to 1

Nícolas F. R. A. Prado (2):
dt-bindings: remoteproc: mediatek: Make l1tcm reg optional for mtk,scp
dt-bindings: remoteproc: mediatek: Add optional memory-region to
mtk,scp

 .../devicetree/bindings/remoteproc/mtk,scp.yaml          | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
Signature · 1 line
2.36.0
#1 lore raw

PATCH v3 1/2 dt-bindings: remoteproc: mediatek: Make l1tcm reg optional for mtk,scp

The SCP has three memory regions: sram, cfg and l1tcm. While the first two are required, l1tcm is optional. Fix the dt-binding so that it can be omitted and update the description. This gets rid of dtbs_check warnings for devicetrees where the l1tcm reg is missing like mt8183.

---

Changes in v3:
- Made the cfg reg required again. After looking again into the mtk-scp driver, only l1tcm is optional.
- Added mention that a dtbs_check warning gets fixed by patch in commit message.

 Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml +4 -2
index 823a236242de..eeea84379a1e 100644
@@ -23,11 +23,13 @@ properties:
 
   reg:
     description:
-      Should contain the address ranges for memory regions SRAM, CFG, and
-      L1TCM.
+      Should contain the address ranges for memory regions SRAM, CFG, and,
+      optionally, L1TCM.
+    minItems: 2
     maxItems: 3
 
   reg-names:
+    minItems: 2
     items:
       - const: sram
       - const: cfg
Signature · 1 line
2.36.0
maintainer Reviewed-by on v3 1/2
#2 lore raw

Re: [PATCH v3 1/2] dt-bindings: remoteproc: mediatek: Make l1tcm reg optional for mtk,scp

Il 03/05/22 23:11, Nícolas F. R. A. Prado ha scritto:

Quoted 6 lines

The SCP has three memory regions: sram, cfg and l1tcm. While the first two are required, l1tcm is optional. Fix the dt-binding so that it can be omitted and update the description. This gets rid of dtbs_check warnings for devicetrees where the l1tcm reg is missing like mt8183.

Quoted 32 lines

---

Changes in v3:
- Made the cfg reg required again. After looking again into the mtk-scp driver, only l1tcm is optional.
- Added mention that a dtbs_check warning gets fixed by patch in commit message.

  Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 6 ++++--
  1 file changed, 4 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml +4 -2
index 823a236242de..eeea84379a1e 100644
@@ -23,11 +23,13 @@ properties:
 
    reg:
      description:
-      Should contain the address ranges for memory regions SRAM, CFG, and
-      L1TCM.
+      Should contain the address ranges for memory regions SRAM, CFG, and,
+      optionally, L1TCM.
+    minItems: 2
      maxItems: 3
 
    reg-names:
+    minItems: 2
      items:
        - const: sram
        - const: cfg
#3 lore raw

Re: [PATCH v3 1/2] dt-bindings: remoteproc: mediatek: Make l1tcm reg optional for mtk,scp

In reply to Nícolas F. R. A. Prado
Quoted 4 lines · Nícolas F. R. A. Prado

The SCP has three memory regions: sram, cfg and l1tcm. While the first two are required, l1tcm is optional. Fix the dt-binding so that it can be omitted and update the description. This gets rid of dtbs_check warnings for devicetrees where the l1tcm reg is missing like mt8183.

Please add "if:then:" for this case (need to put all ifs in allOf). I understand that l1tcm is optional *only* on mt8183.

Best regards,
Krzysztof

#4 lore raw

PATCH v3 2/2 dt-bindings: remoteproc: mediatek: Add optional memory-region to mtk,scp

In reply to Nícolas F. R. A. Prado

The SCP co-processor can optionally be passed a reserved memory region to use. Add this property in the dt-binding.

---

(no changes since v2)

Changes in v2:
- Dropped type and description since it's a well-known property
- Set maxItems to 1

 Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml +3 -0
index eeea84379a1e..395c80bce713 100644
@@ -47,6 +47,9 @@ properties:
   interrupts:
     maxItems: 1
 
+  memory-region:
+    maxItems: 1
+
 required:
   - compatible
   - reg
Signature · 1 line
2.36.0