Skip to contentSkip to conversation

tools/edid: Only include the .data section in the raw binary output

PATCH New Forest Crossman 1 participant 1 message May 4, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tools/edid: Only include the .data section in the raw binary output

I don't know at what point this changed, but with gcc 11.2.0 and binutils 2.38, if we don't restrict what sections are output to the raw binary, the ".note.gnu.property" section in the object file will be written into the first 48 bytes of the EDID, rendering it unusable.

To fix this, limit the binary output to the ".data" section.

---
 tools/edid/Makefile | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
tools/edid/Makefile +3 -3
index 85a927dfab02..b62bfd925348 100644
@@ -16,7 +16,7 @@ clean:
 	@cc -c $^
 
 %.bin.nocrc:	%.o
-	@objcopy -Obinary $^ $@
+	@objcopy -j.data -Obinary $^ $@
 
 %.crc:	%.bin.nocrc
 	@list=$$(for i in `seq 1 127`; do head -c$$i $^ | tail -c1 \
@@ -27,10 +27,10 @@ clean:
 	@cc -c -DCRC="$$(cat $*.crc)" -o $@ $*.S
 
 %.bin:	%.p
-	@objcopy -Obinary $^ $@
+	@objcopy -j.data -Obinary $^ $@
 
 %.bin.ihex:	%.p
-	@objcopy -Oihex $^ $@
+	@objcopy -j.data -Oihex $^ $@
 	@dos2unix $@ 2>/dev/null
 
 %.c:	%.bin
Signature · 1 line
2.36.0