Skip to contentSkip to conversation

bcma: gpio: Switch to use fwnode instead of of_node

PATCH New Andy Shevchenko 2 participants 2 messages May 3, 2022 Broadcom specific amba driver (bcma)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bcma: gpio: Switch to use fwnode instead of of_node

GPIO library now accepts fwnode as a firmware node, so switch the driver to use it.

---
 drivers/bcma/driver_gpio.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/bcma/driver_gpio.c +4 -3
index 1e74ec1c7f23..2ee9804e9d51 100644
@@ -11,6 +11,8 @@
 #include <linux/gpio/driver.h>
 #include <linux/interrupt.h>
 #include <linux/export.h>
+#include <linux/poperty.h>
+
 #include <linux/bcma/bcma.h>
 
 #include "bcma_private.h"
@@ -182,9 +184,8 @@ int bcma_gpio_init(struct bcma_drv_cc *cc)
 	chip->direction_input	= bcma_gpio_direction_input;
 	chip->direction_output	= bcma_gpio_direction_output;
 	chip->parent		= bus->dev;
-#if IS_BUILTIN(CONFIG_OF)
-	chip->of_node		= cc->core->dev.of_node;
-#endif
+	chip->fwnode		= dev_fwnode(&cc->core->dev);
+
 	switch (bus->chipinfo.id) {
 	case BCMA_CHIP_ID_BCM4707:
 	case BCMA_CHIP_ID_BCM5357:
Signature · 1 line
2.35.1
#1 lore raw
I love your patch! Yet something to improve:

Hi Andy,

I love your patch! Yet something to improve:

[auto build test ERROR on wireless/main]
[also build test ERROR on wireless-next/main linus/master linux/master v5.18-rc5 next-20220503] [If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/bcma-gpio-Switch-to-use-fwnode-instead-of-of_node/20220503-231650
base:   https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless.git main
config: hexagon-randconfig-r045-20220501 (https://download.01.org/0day-ci/archive/20220504/[email protected]/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 363b3a645a1e30011cc8da624f13dac5fd915628)

reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/46c0f361f2b8880eb16d176051b977c31978920a
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Andy-Shevchenko/bcma-gpio-Switch-to-use-fwnode-instead-of-of_node/20220503-231650 git checkout 46c0f361f2b8880eb16d176051b977c31978920a
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/bcma/

If you fix the issue, kindly add following tag as appropriate

All errors (new ones prefixed by >>):

>> drivers/bcma/driver_gpio.c:14:10: fatal error: 'linux/poperty.h' file not found
   #include <linux/poperty.h>
            ^~~~~~~~~~~~~~~~~

1 error generated.

vim +14 drivers/bcma/driver_gpio.c

  > 14	#include <linux/poperty.h>
    15	
Signature · 2 lines
0-DAY CI Kernel Test Service
https://01.org/lkp