Skip to contentSkip to conversation

dt-bindings: regulator: Add regulator-external-output property

PATCH In review Zev Weiss 3 participants 15 messages May 4, 2022 – May 5, 2022

Subsystems (2)
lore
Share & tools
lore

Zev Weiss

author
#0 lore raw

PATCH 1/6 dt-bindings: regulator: Add regulator-external-output property

Some regulators do not provide power to anything within the system described by a device tree, and simply supply an external output. The regulator-external-output property can now be used to mark such regulators.

---
 Documentation/devicetree/bindings/regulator/regulator.yaml | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/regulator/regulator.yaml +6 -0
index a9b66ececccf..0e418e68b0e6 100644
@@ -226,6 +226,12 @@ properties:
     description: Maximum difference between current and target voltages
       that can be changed safely in a single step.
 
+  regulator-external-output:
+    description: The regulator's output is external to the system
+      described by the device-tree; no devices within the system are
+      downstream of it.
+    type: boolean
+
 patternProperties:
   ".*-supply$":
     description: Input supply phandle(s) for this node
Signature · 1 line
2.36.0
author
#1 lore raw

PATCH 2/6 dt-bindings: regulator: Add reg-external-output binding

This describes an external output supplied by a regulator, such as a power outlet on a power distribution unit (PDU).

---
 .../regulator/reg-external-output.yaml        | 37 +++++++++++++++++++
 1 file changed, 37 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/regulator/reg-external-output.yaml
Documentation/devicetree/bindings/regulator/reg-external-output.yaml new file +37 -0
new file mode 100644
index 000000000000..c00bee5bd9f2
@@ -0,0 +1,37 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+
+$id: http://devicetree.org/schemas/regulator/reg-external-output.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Regulator external output
+
+maintainers:
+  - Zev Weiss <[email protected]>
+
+description: |
+  This describes an external output supplied by a regulator, such as
+  a power outlet on a power distribution unit (PDU).
+
+properties:
+  compatible:
+    const: reg-external-output
+
+  vout-supply:
+    description:
+      Phandle of the regulator supplying the output, which should have
+      the regulator-external-output property.
+
+required:
+  - compatible
+  - vout-supply
+
+additionalProperties: false
+
+examples:
+  - |
+      output {
+          compatible = "reg-external-output";
+          vout-supply = <&output_reg>;
+      };
Signature · 1 line
2.36.0
maintainer
#2 lore raw

Re: [PATCH 2/6] dt-bindings: regulator: Add reg-external-output binding

Quoted 2 lines · Zev Weiss

This describes an external output supplied by a regulator, such as a power outlet on a power distribution unit (PDU).

OK, so this is that represnetation of the connection - which raises the question about why the regulator needs a property?

Quoted 4 lines
Documentation/devicetree/bindings/regulator/reg-external-output.yaml new file +4 -0
+description: |
+  This describes an external output supplied by a regulator, such as
+  a power outlet on a power distribution unit (PDU).
+

Documentation/devicetree/bindings/regulator/reg-external-output.yaml line 26

Quoted 10 lines
Documentation/devicetree/bindings/regulator/reg-external-output.yaml new file +10 -0
+properties:
+  compatible:
+    const: reg-external-output
+
+  vout-supply:
+    description:
+      Phandle of the regulator supplying the output, which should have
+      the regulator-external-output property.
+
+required:

I think at a minimum anything like this would need some sort of representation of how the output physically appears so that people can work out how outputs are mapped to the hardware they see. However we already have a subsystem for external connectors - extcon. Perhaps this should be a regulator client in the extcon API? It's common for connectors to include some sort of power provision so it seems like this would fit right in.

author
#3 lore raw

Re: [PATCH 2/6] dt-bindings: regulator: Add reg-external-output binding

Quoted 17 lines · Mark Brown
Quoted 2 lines · Zev Weiss

This describes an external output supplied by a regulator, such as a power outlet on a power distribution unit (PDU).

OK, so this is that represnetation of the connection - which raises the question about why the regulator needs a property?

Quoted 10 lines
Documentation/devicetree/bindings/regulator/reg-external-output.yaml new file +10 -0
+description: |
+  This describes an external output supplied by a regulator, such as
+  a power outlet on a power distribution unit (PDU).
+
+properties:
+  compatible:
+    const: reg-external-output
+
+  vout-supply:
+    description:
Quoted 8 lines

Documentation/devicetree/bindings/regulator/reg-external-output.yaml line 26

Quoted 4 lines
Documentation/devicetree/bindings/regulator/reg-external-output.yaml new file +4 -0
+      Phandle of the regulator supplying the output, which should have
+      the regulator-external-output property.
+
+required:

I think at a minimum anything like this would need some sort of representation of how the output physically appears so that people can work out how outputs are mapped to the hardware they see.

I don't quite understand what you're describing here -- could you elaborate on what you mean by "how the output physically appears", and what that might look like in a DT binding?

Quoted 5 lines

However we
already have a subsystem for external connectors - extcon. Perhaps this should be a regulator client in the extcon API? It's common for connectors to include some sort of power provision so it seems like this would fit right in.

Interesting -- I wasn't previously aware of the extcon subsystem, thanks for the pointer. However, after looking at it a bit, I'm not sure I see how it'd be applicable here, since it looks like it's built to handle hardware that's at least sophisticated enough for software to tell whether or not something's plugged in, which isn't the case here. The connector is just a ground pin and +12VDC pin, no presence-detection mechanism or anything else. Outside of the regulator itself there's really no "device" there for software to talk to or otherwise interact with at all.

Thanks,
Zev

maintainer
#4 lore raw

Re: [PATCH 2/6] dt-bindings: regulator: Add reg-external-output binding

Quoted 9 lines · Zev Weiss
Quoted 3 lines · Mark Brown

I think at a minimum anything like this would need some sort of representation of how the output physically appears so that people can work out how outputs are mapped to the hardware they see.

I don't quite understand what you're describing here -- could you elaborate on what you mean by "how the output physically appears", and what that might look like in a DT binding?

For example if the output comes out on a socket then that socket should be described.

Quoted 6 lines
Quoted 5 lines

However we
already have a subsystem for external connectors - extcon. Perhaps this should be a regulator client in the extcon API? It's common for connectors to include some sort of power provision so it seems like this would fit right in.

Quoted 8 lines

Interesting -- I wasn't previously aware of the extcon subsystem, thanks for the pointer. However, after looking at it a bit, I'm not sure I see how it'd be applicable here, since it looks like it's built to handle hardware that's at least sophisticated enough for software to tell whether or not something's plugged in, which isn't the case here. The connector is just a ground pin and +12VDC pin, no presence-detection mechanism or anything else. Outside of the regulator itself there's really no "device" there for software to talk to or otherwise interact with at all.

Sure, but there's no reason why it can't scale down to something simpler. It's easier to support something simpler than have to extend to support something more complicated.

author
#5 lore raw

Re: [PATCH 2/6] dt-bindings: regulator: Add reg-external-output binding

[Adding extcon maintainers...]

Quoted 7 lines · Mark Brown
Quoted 5 lines · Zev Weiss
Quoted 3 lines · Mark Brown

I think at a minimum anything like this would need some sort of representation of how the output physically appears so that people can work out how outputs are mapped to the hardware they see.

Quoted 7 lines
Quoted 3 lines

I don't quite understand what you're describing here -- could you elaborate on what you mean by "how the output physically appears", and what that might look like in a DT binding?

For example if the output comes out on a socket then that socket should be described.

Okay -- in the case of an Open19 power shelf like the ahe-50dc, there are 50 instances of this, 48 of which are in four ganged connectors each with 12 pairs of pins, but two of which have their own dedicated little individual sockets. The connectors are physically different, but they're all identical as far as software is concerned, so I'm not clear on why it would need to be expressed in any DT properties or the like. Or did you just mean explanatory free-form text in the description field?

Quoted 15 lines
Quoted 6 lines
Quoted 5 lines

However we
already have a subsystem for external connectors - extcon. Perhaps this should be a regulator client in the extcon API? It's common for connectors to include some sort of power provision so it seems like this would fit right in.

Quoted 8 lines

Interesting -- I wasn't previously aware of the extcon subsystem, thanks for the pointer. However, after looking at it a bit, I'm not sure I see how it'd be applicable here, since it looks like it's built to handle hardware that's at least sophisticated enough for software to tell whether or not something's plugged in, which isn't the case here. The connector is just a ground pin and +12VDC pin, no presence-detection mechanism or anything else. Outside of the regulator itself there's really no "device" there for software to talk to or otherwise interact with at all.

Quoted 3 lines

Sure, but there's no reason why it can't scale down to something simpler. It's easier to support something simpler than have to extend to support something more complicated.

Alright, so would you suggest creating something like drivers/extcon/extcon-regulator-output.c, and just having its extcon functionality be something of a stub for now?

Thanks,
Zev

maintainer
#6 lore raw

Re: [PATCH 2/6] dt-bindings: regulator: Add reg-external-output binding

Quoted 5 lines · Zev Weiss
Quoted 2 lines · Mark Brown

For example if the output comes out on a socket then that socket should be described.

Quoted 7 lines

Okay -- in the case of an Open19 power shelf like the ahe-50dc, there are 50 instances of this, 48 of which are in four ganged connectors each with 12 pairs of pins, but two of which have their own dedicated little individual sockets. The connectors are physically different, but they're all identical as far as software is concerned, so I'm not clear on why it would need to be expressed in any DT properties or the like. Or did you just mean explanatory free-form text in the description field?

Explanatory description would be one example of something that should be described, yes - if there is control for switching the supplies on and off the user is going to need to be able to figure out which software control corresponds to which physical connection. Other devices may have more things that need autoamtion (eg, jack detection).

Quoted 7 lines
Quoted 3 lines

Sure, but there's no reason why it can't scale down to something simpler. It's easier to support something simpler than have to extend to support something more complicated.

Alright, so would you suggest creating something like drivers/extcon/extcon-regulator-output.c, and just having its extcon functionality be something of a stub for now?

I'm not super familiar with extcon but that seems plausible.

#7 lore raw

Re: [PATCH 2/6] dt-bindings: regulator: Add reg-external-output binding

In reply to Zev Weiss
Quoted 7 lines · Zev Weiss
Quoted 6 lines · Mark Brown
Quoted 2 lines · Zev Weiss

This describes an external output supplied by a regulator, such as a power outlet on a power distribution unit (PDU).

OK, so this is that represnetation of the connection - which raises the question about why the regulator needs a property?

This remained unanswered... the binding looks like approach the problem from wrong side. It's like defining consumers of clock inside clock controller. It does not scale, it's not in Devicetree style/intentions.

You should have a dedicated port or connector which takes a regulator as a supply (and for supply we already have bindings).

We already have only one connector:
git grep connector -- Documentation/devicetree/

(extcon is not the best choice for bindings, it's tied to Linux implementation, not to hardware)

Best regards,
Krzysztof

author
#8 lore raw

PATCH 3/6 regulator: core: Add error flags to sysfs attributes

In reply to Zev Weiss

If a regulator provides a get_error_flags() operation, its sysfs attributes will now include an entry for each defined REGULATOR_ERROR_* flag.

---
 .../ABI/testing/sysfs-class-regulator         | 81 +++++++++++++++++++
 drivers/regulator/core.c                      | 45 +++++++++++
 2 files changed, 126 insertions(+)
Documentation/ABI/testing/sysfs-class-regulator +81 -0
index 8516f08806dd..475b9a372657 100644
@@ -370,3 +370,84 @@ Description:
 
 		'unknown' means software cannot determine the state, or
 		the reported state is invalid.
+
+What:		/sys/class/regulator/.../under_voltage
+Date:		April 2022
+KernelVersion:	5.18
+Contact:	Zev Weiss <[email protected]>
+Description:
+		Some regulator directories will contain a field called
+		under_voltage.  This indicates if the device reports an
+		under-voltage fault (1) or not (0).
+
+What:		/sys/class/regulator/.../over_current
+Date:		April 2022
+KernelVersion:	5.18
+Contact:	Zev Weiss <[email protected]>
+Description:
+		Some regulator directories will contain a field called
+		over_current.  This indicates if the device reports an
+		over-current fault (1) or not (0).
+
+What:		/sys/class/regulator/.../regulation_out
+Date:		April 2022
+KernelVersion:	5.18
+Contact:	Zev Weiss <[email protected]>
+Description:
+		Some regulator directories will contain a field called
+		regulation_out.  This indicates if the device reports an
+		out-of-regulation fault (1) or not (0).
+
+What:		/sys/class/regulator/.../fail
+Date:		April 2022
+KernelVersion:	5.18
+Contact:	Zev Weiss <[email protected]>
+Description:
+		Some regulator directories will contain a field called
+		fail.  This indicates if the device reports an output failure
+		(1) or not (0).
+
+What:		/sys/class/regulator/.../over_temp
+Date:		April 2022
+KernelVersion:	5.18
+Contact:	Zev Weiss <[email protected]>
+Description:
+		Some regulator directories will contain a field called
+		over_temp.  This indicates if the device reports an
+		over-temperature fault (1) or not (0).
+
+What:		/sys/class/regulator/.../under_voltage_warn
+Date:		April 2022
+KernelVersion:	5.18
+Contact:	Zev Weiss <[email protected]>
+Description:
+		Some regulator directories will contain a field called
+		under_voltage_warn.  This indicates if the device reports an
+		under-voltage warning (1) or not (0).
+
+What:		/sys/class/regulator/.../over_current_warn
+Date:		April 2022
+KernelVersion:	5.18
+Contact:	Zev Weiss <[email protected]>
+Description:
+		Some regulator directories will contain a field called
+		over_current_warn.  This indicates if the device reports an
+		over-current warning (1) or not (0).
+
+What:		/sys/class/regulator/.../over_voltage_warn
+Date:		April 2022
+KernelVersion:	5.18
+Contact:	Zev Weiss <[email protected]>
+Description:
+		Some regulator directories will contain a field called
+		over_voltage_warn.  This indicates if the device reports an
+		over-voltage warning (1) or not (0).
+
+What:		/sys/class/regulator/.../over_temp_warn
+Date:		April 2022
+KernelVersion:	5.18
+Contact:	Zev Weiss <[email protected]>
+Description:
+		Some regulator directories will contain a field called
+		over_temp_warn.  This indicates if the device reports an
+		over-temperature warning (1) or not (0).
drivers/regulator/core.c +45 -0

69 lines not on this page · raw message

Signature · 1 line
2.36.0
author
#9 lore raw

PATCH 4/6 regulator: core: Add external-output support

In reply to Zev Weiss

Regulators feeding external outputs (i.e. supplying devices we don't control) can be switched on and off by userspace via the 'state' sysfs attribute, which is now (conditionally) writable. They are also not automatically disabled in regulator_late_cleanup(), since we have no way of knowing that they're not actually in use.

---
 .../ABI/testing/sysfs-class-regulator         |  4 ++
 drivers/regulator/core.c                      | 41 ++++++++++++++++---
 drivers/regulator/of_regulator.c              |  2 +
 include/linux/regulator/machine.h             |  1 +
 4 files changed, 43 insertions(+), 5 deletions(-)
Documentation/ABI/testing/sysfs-class-regulator +4 -0
index 475b9a372657..1c0451730df2 100644
@@ -23,6 +23,10 @@ Description:
 		'unknown' means software cannot determine the state, or
 		the reported state is invalid.
 
+		For regulators supplying external outputs, 'enabled'
+		or 'disabled' can be written to this file to turn the
+		regulator on and off.
+
 		NOTE: this field can be used in conjunction with microvolts
 		or microamps to determine configured regulator output levels.
 
drivers/regulator/core.c +36 -5

72 lines not on this page · raw message

drivers/regulator/of_regulator.c +2 -0
index f54d4f176882..f48e6ea2b97e 100644
@@ -96,6 +96,8 @@ static int of_get_regulation_constraints(struct device *dev,
 
 	constraints->name = of_get_property(np, "regulator-name", NULL);
 
+	constraints->external_output = of_property_read_bool(np, "regulator-external-output");
+
 	if (!of_property_read_u32(np, "regulator-min-microvolt", &pval))
 		constraints->min_uV = pval;
 
include/linux/regulator/machine.h +1 -0
index 621b7f4a3639..a38e7db9f82e 100644
@@ -219,6 +219,7 @@ struct regulation_constraints {
 	unsigned over_voltage_detection:1; /* notify on over voltage */
 	unsigned under_voltage_detection:1; /* notify on under voltage */
 	unsigned over_temp_detection:1; /* notify on over temperature */
+	unsigned external_output:1; /* output supplies only external devices */
 };
 
 /**
Signature · 1 line
2.36.0
maintainer
#10 lore raw

Re: [PATCH 4/6] regulator: core: Add external-output support

Quoted 5 lines · Zev Weiss

Regulators feeding external outputs (i.e. supplying devices we don't control) can be switched on and off by userspace via the 'state' sysfs attribute, which is now (conditionally) writable. They are also not automatically disabled in regulator_late_cleanup(), since we have no way of knowing that they're not actually in use.

No, this is an abstraction failure. Enabling and disabling a regulator is something that should be handled in consumer drivers, just as with every other use case there's no reason why the regulator should be offering direct control to userspace. Putting this directly in the regulator will cause problems as soon as you for example have multiple outputs supplied from a single regulator and can't be integrated with any other control mechanisms.

author
#11 lore raw

PATCH 5/6 regulator: core: Add external get type

In reply to Zev Weiss

EXTERNAL_GET is similar to EXCLUSIVE_GET, but requires opt-in agreement from the supply (whose constraints must designate it as external_output). It is intended for use only within the regulator subsystem, and hence is not exposed in the public headers.

---
 drivers/regulator/core.c     | 16 +++++++++++++---
 drivers/regulator/devres.c   |  7 +++++++
 drivers/regulator/internal.h |  3 +++
 3 files changed, 23 insertions(+), 3 deletions(-)
drivers/regulator/core.c +13 -3
index b7617926336f..d873606eb41f 100644
@@ -2087,6 +2087,7 @@ struct regulator *_regulator_get(struct device *dev, const char *id,
 	struct regulator_dev *rdev;
 	struct regulator *regulator;
 	struct device_link *link;
+	bool is_external;
 	int ret;
 
 	if (get_type >= MAX_GET_TYPE) {
@@ -2129,8 +2130,9 @@ struct regulator *_regulator_get(struct device *dev, const char *id,
 			break;
 
 		case EXCLUSIVE_GET:
+		case EXTERNAL_GET:
 			dev_warn(dev,
-				 "dummy supplies not allowed for exclusive requests\n");
+				 "dummy supplies not allowed for exclusive or external requests\n");
 			fallthrough;
 
 		default:
@@ -2144,12 +2146,20 @@ struct regulator *_regulator_get(struct device *dev, const char *id,
 		return regulator;
 	}
 
-	if (get_type == EXCLUSIVE_GET && rdev->open_count) {
+	if ((get_type == EXCLUSIVE_GET || get_type == EXTERNAL_GET) && rdev->open_count) {
 		regulator = ERR_PTR(-EBUSY);
 		put_device(&rdev->dev);
 		return regulator;
 	}
 
+	/* EXTERNAL_GET is valid if and only if the regulator is designated for external output */
+	is_external = rdev->constraints && rdev->constraints->external_output;
+	if ((get_type == EXTERNAL_GET) != is_external) {
+		regulator = ERR_PTR(-EINVAL);
+		put_device(&rdev->dev);
+		return regulator;
+	}
+
 	mutex_lock(&regulator_list_mutex);
 	ret = (rdev->coupling_desc.n_resolved != rdev->coupling_desc.n_coupled);
 	mutex_unlock(&regulator_list_mutex);
@@ -2182,7 +2192,7 @@ struct regulator *_regulator_get(struct device *dev, const char *id,
 	}
 
 	rdev->open_count++;
-	if (get_type == EXCLUSIVE_GET) {
+	if (get_type == EXCLUSIVE_GET || get_type == EXTERNAL_GET) {
 		rdev->exclusive = 1;
 
 		ret = _regulator_is_enabled(rdev);
drivers/regulator/devres.c +7 -0
index 9113233f41cd..36df9e9ff175 100644
@@ -70,6 +70,13 @@ struct regulator *devm_regulator_get_exclusive(struct device *dev,
 }
 EXPORT_SYMBOL_GPL(devm_regulator_get_exclusive);
 
+/* For regulator-core internal use only */
+struct regulator *devm_regulator_get_external(struct device *dev,
+					      const char *id)
+{
+	return _devm_regulator_get(dev, id, EXTERNAL_GET);
+}
+
 /**
  * devm_regulator_get_optional - Resource managed regulator_get_optional()
  * @dev: device to supply
drivers/regulator/internal.h +3 -0
index 1e9c71642143..c176a416c571 100644
@@ -116,10 +116,13 @@ static inline bool of_check_coupling_data(struct regulator_dev *rdev)
 enum regulator_get_type {
 	NORMAL_GET,
 	EXCLUSIVE_GET,
+	EXTERNAL_GET,
 	OPTIONAL_GET,
 	MAX_GET_TYPE
 };
 
 struct regulator *_regulator_get(struct device *dev, const char *id,
 				 enum regulator_get_type get_type);
+struct regulator *devm_regulator_get_external(struct device *dev,
+					      const char *id);
 #endif
Signature · 1 line
2.36.0
author
#12 lore raw

PATCH 6/6 regulator: core: Add external-consumer driver

In reply to Zev Weiss

An external consumer is a dummy device representing a device external to the system that is supplied by a regulator designated for external output. It is purely a virtual placeholder to instantiate a regulator by calling regulator_get() on it from its probe function.

---
 drivers/regulator/Kconfig |  9 +++++++++
 drivers/regulator/core.c  | 28 ++++++++++++++++++++++++++++
 2 files changed, 37 insertions(+)
drivers/regulator/Kconfig +9 -0
index 5ef2306fce04..5ec390687a81 100644
@@ -56,6 +56,15 @@ config REGULATOR_USERSPACE_CONSUMER
 
 	  If unsure, say no.
 
+config REGULATOR_EXTERNAL_CONSUMER
+	bool "External regulator consumer support"
+	help
+	  Some regulators supply devices that are entirely external to
+	  the system.  This driver provides a placeholder consumer
+	  representing such devices.
+
+	  If unsure, say no.
+
 config REGULATOR_88PG86X
 	tristate "Marvell 88PG86X voltage regulators"
 	depends on I2C
drivers/regulator/core.c +28 -0
index d873606eb41f..4f348b3d5290 100644
@@ -19,6 +19,7 @@
 #include <linux/delay.h>
 #include <linux/gpio/consumer.h>
 #include <linux/of.h>
+#include <linux/platform_device.h>
 #include <linux/regmap.h>
 #include <linux/regulator/of_regulator.h>
 #include <linux/regulator/consumer.h>
@@ -6070,6 +6071,33 @@ static int regulator_summary_show(struct seq_file *s, void *data)
 DEFINE_SHOW_ATTRIBUTE(regulator_summary);
 #endif /* CONFIG_DEBUG_FS */
 
+#ifdef CONFIG_REGULATOR_EXTERNAL_CONSUMER
+static int regulator_external_output_probe(struct platform_device *pdev)
+{
+	struct regulator *reg;
+
+	reg = devm_regulator_get_external(&pdev->dev, "vout");
+	if (IS_ERR(reg))
+		return PTR_ERR(reg);
+
+	return 0;
+}
+
+static const struct of_device_id reg_external_consumer_of_match_table[] = {
+	{ .compatible = "regulator-external-output" },
+	{ },
+};
+
+static struct platform_driver reg_external_consumer_driver = {
+	.driver = {
+		.name = "reg-external-consumer",
+		.of_match_table = reg_external_consumer_of_match_table,
+	},
+	.probe = regulator_external_output_probe,
+};
+builtin_platform_driver(reg_external_consumer_driver);
+#endif /* CONFIG_REGULATOR_EXTERNAL_CONSUMER */
+
 static int __init regulator_init(void)
 {
 	int ret;
Signature · 1 line
2.36.0
maintainer
#13 lore raw
In reply to Zev Weiss
Quoted 4 lines · Zev Weiss

Some regulators do not provide power to anything within the system described by a device tree, and simply supply an external output. The regulator-external-output property can now be used to mark such regulators.

Why not just add a device representing this output? Presumably it has some other properties (eg, labelling for a connector) and may need some integration with some form of control mechanism.

maintainer
#14 lore raw

Re: (subset) [PATCH 1/6] dt-bindings: regulator: Add regulator-external-output property

In reply to Zev Weiss
Quoted 6 lines · Zev Weiss

Some regulators do not provide power to anything within the system described by a device tree, and simply supply an external output. The regulator-external-output property can now be used to mark such regulators.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[3/6] regulator: core: Add error flags to sysfs attributes

      commit: 0f2d636e7d1fd76f704dd3ea5089ce29a8aee049

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark