Skip to contentSkip to conversation

kernel/crash_core.c : Remove redundant checks for ck_cmdline is NULL

PATCH In review lizhe 2 participants 2 messages May 4, 2022 – May 5, 2022

Subsystems (3)
lore
Share & tools
lore

lizhe

author
#0 lore raw

PATCH 1/1 kernel/crash_core.c : Remove redundant checks for ck_cmdline is NULL

When ck_cmdline is NULL. The last three lines of this function(get_last_crashkernel()) are equivalent to :

	if (!NULL)
		return NULL;

	return NULL;

This is obviously a redundant check

---
 kernel/crash_core.c | 3 ---
 1 file changed, 3 deletions(-)
kernel/crash_core.c +0 -3
index 256cf6db573c..c232f01a2c54 100644
@@ -222,9 +222,6 @@ static __init char *get_last_crashkernel(char *cmdline,
 		p = strstr(p+1, name);
 	}
 
-	if (!ck_cmdline)
-		return NULL;
-
 	return ck_cmdline;
 }
 
Signature · 1 line
2.25.1
Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · lizhe

When ck_cmdline is NULL. The last three lines of this function(get_last_crashkernel()) are equivalent to :

	if (!NULL)
		return NULL;

	return NULL;

This is obviously a redundant check

Now the patch log correctly reflects the code change, even though the log is a little redundant. While it's far far better than a wrong log which will definitely confuse, even mislead people. I would go with:

======
kernel/crash_core.c : remove redundant check of ck_cmdline

At the end of get_last_crashkernel(), the judgement of ck_cmdline is obviously unnecessary and causes redundance, let's clean it up.
======

And the patch version is missing. If you agree on the above log rephrasing, please post v4 with the updated log, and can add my ack:

Thanks
Baoquan

Quoted 23 lines
---
 kernel/crash_core.c | 3 ---
 1 file changed, 3 deletions(-)
kernel/crash_core.c +0 -3
index 256cf6db573c..c232f01a2c54 100644
@@ -222,9 +222,6 @@ static __init char *get_last_crashkernel(char *cmdline,
 		p = strstr(p+1, name);
 	}
 
-	if (!ck_cmdline)
-		return NULL;
-
 	return ck_cmdline;
 }
 
Signature · 1 line
2.25.1