Skip to contentSkip to conversation

gpio: max77620: Make the irqchip immutable

PATCH Applied Jon Hunter 3 participants 5 messages May 4, 2022 – May 5, 2022

Subsystems (2)
GPIO Tegra architecture support
lore
Share & tools
lore

Jon Hunter

author maintainer
#0 lore raw

PATCH v2 1/1 gpio: max77620: Make the irqchip immutable

Commit 6c846d026d49 ("gpio: Don't fiddle with irqchips marked as immutable") added a warning to indicate if the gpiolib is altering the internals of irqchips. Following this change the following warning is now observed for the max77620 gpio driver ...

WARNING KERN gpio gpiochip0: (max77620-gpio): not an immutable chip,
please consider fixing it!

Fix the above warning by making the max77620 gpio driver immutable.

Signed-off-by Jon Hunter <[email protected]>

---
Changes since V1:
- Dropped irq_print_chip callback
- Fixed up the irq_mask/unmask callbacks

 drivers/gpio/gpio-max77620.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
drivers/gpio/gpio-max77620.c +6 -3
index ebf9dea6546b..c18b60e39a94 100644
@@ -54,6 +54,7 @@ static void max77620_gpio_irq_mask(struct irq_data *data)
 	struct max77620_gpio *gpio = gpiochip_get_data(chip);
 
 	gpio->irq_enabled[data->hwirq] = false;
+	gpiochip_disable_irq(chip, data->hwirq);
 }
 
 static void max77620_gpio_irq_unmask(struct irq_data *data)

@@ -61,6 +62,7 @@ static void max77620_gpio_irq_unmask(struct irq_data *data)
 	struct gpio_chip *chip = irq_data_get_irq_chip_data(data);
 	struct max77620_gpio *gpio = gpiochip_get_data(chip);
 
+	gpiochip_enable_irq(chip, data->hwirq);
 	gpio->irq_enabled[data->hwirq] = true;
 }
 

@@ -119,14 +121,15 @@ static void max77620_gpio_bus_sync_unlock(struct irq_data *data)
 	mutex_unlock(&gpio->buslock);
 }
 
-static struct irq_chip max77620_gpio_irqchip = {
+static const struct irq_chip max77620_gpio_irqchip = {
 	.name		= "max77620-gpio",
 	.irq_mask	= max77620_gpio_irq_mask,
 	.irq_unmask	= max77620_gpio_irq_unmask,
 	.irq_set_type	= max77620_gpio_set_irq_type,
 	.irq_bus_lock	= max77620_gpio_bus_lock,
 	.irq_bus_sync_unlock = max77620_gpio_bus_sync_unlock,
-	.flags		= IRQCHIP_MASK_ON_SUSPEND,
+	.flags		= IRQCHIP_IMMUTABLE | IRQCHIP_MASK_ON_SUSPEND,
+	GPIOCHIP_IRQ_RESOURCE_HELPERS,
 };
 
 static int max77620_gpio_dir_input(struct gpio_chip *gc, unsigned int offset)

@@ -318,7 +321,7 @@ static int max77620_gpio_probe(struct platform_device *pdev)
 	mgpio->gpio_chip.base = -1;
 
 	girq = &mgpio->gpio_chip.irq;
-	girq->chip = &max77620_gpio_irqchip;
+	gpio_irq_chip_set_chip(girq, &max77620_gpio_irqchip);
 	/* This will let us handle the parent IRQ in the driver */
 	girq->parent_handler = NULL;
 	girq->num_parents = 0;
Signature · 1 line
2.25.1
Reviewed-by on v2 1/1
#1 lore raw
Quoted 6 lines · Jon Hunter

Commit 6c846d026d49 ("gpio: Don't fiddle with irqchips marked as immutable") added a warning to indicate if the gpiolib is altering the internals of irqchips. Following this change the following warning is now observed for the max77620 gpio driver ...

Quoted 6 lines

WARNING KERN gpio gpiochip0: (max77620-gpio): not an immutable chip,
please consider fixing it!

Fix the above warning by making the max77620 gpio driver immutable.

Signed-off-by Jon Hunter <[email protected]>
Reviewed-by Marc Zyngier <[email protected]>
	M.
Signature · 1 line
Without deviation from the norm, progress is not possible.
Applied
#2 lore raw
In reply to Jon Hunter
Quoted 6 lines · Jon Hunter

Commit 6c846d026d49 ("gpio: Don't fiddle with irqchips marked as immutable") added a warning to indicate if the gpiolib is altering the internals of irqchips. Following this change the following warning is now observed for the max77620 gpio driver ...

Quoted 7 lines

WARNING KERN gpio gpiochip0: (max77620-gpio): not an immutable chip,
please consider fixing it!

Fix the above warning by making the max77620 gpio driver immutable.

Signed-off-by Jon Hunter <[email protected]>

---

Queued for fixes, thanks!

Bart

#3 lore raw
Quoted 10 lines · Bartosz Golaszewski
Quoted 9 lines · Jon Hunter

Commit 6c846d026d49 ("gpio: Don't fiddle with irqchips marked as immutable") added a warning to indicate if the gpiolib is altering the internals of irqchips. Following this change the following warning is now observed for the max77620 gpio driver ...

WARNING KERN gpio gpiochip0: (max77620-gpio): not an immutable chip,
please consider fixing it!

Quoted 6 lines
Quoted 4 lines

Fix the above warning by making the max77620 gpio driver immutable.

Signed-off-by Jon Hunter <[email protected]>

---

Queued for fixes, thanks!

You mean fixes for *5.19*, right?

Thanks,

        M.
Signature · 1 line
Jazz is not dead. It just smells funny...
#4 lore raw
Quoted 12 lines · Marc Zyngier
Quoted 10 lines · Bartosz Golaszewski
Quoted 9 lines · Jon Hunter

Commit 6c846d026d49 ("gpio: Don't fiddle with irqchips marked as immutable") added a warning to indicate if the gpiolib is altering the internals of irqchips. Following this change the following warning is now observed for the max77620 gpio driver ...

WARNING KERN gpio gpiochip0: (max77620-gpio): not an immutable chip,
please consider fixing it!

Quoted 9 lines
Quoted 6 lines
Quoted 4 lines

Fix the above warning by making the max77620 gpio driver immutable.

Signed-off-by Jon Hunter <[email protected]>

---

Queued for fixes, thanks!

You mean fixes for *5.19*, right?

Of course I did. 100%. And I'll stick to this version. :)

(Thanks for the heads-up!)

Bart