Skip to contentSkip to conversation

drm/i915: Remove duplicated include in intel_sseu.c

PATCH In review Yang Li 2 participants 3 messages May 4, 2022 – May 5, 2022

Subsystems (2)
lore
Share & tools
lore

Yang Li

author
#0 lore raw

PATCH 1/2 drm/i915: Remove duplicated include in intel_sseu.c

Fix following includecheck warning:
./drivers/gpu/drm/i915/gt/intel_sseu.c: linux/string_helpers.h is included more than once.

---
 drivers/gpu/drm/i915/gt/intel_sseu.c | 2 --
 1 file changed, 2 deletions(-)
drivers/gpu/drm/i915/gt/intel_sseu.c +0 -2
index 9881a6790574..fdd25691beda 100644
@@ -10,8 +10,6 @@
 #include "intel_gt_regs.h"
 #include "intel_sseu.h"
 
-#include "linux/string_helpers.h"
-
 void intel_sseu_set_info(struct sseu_dev_info *sseu, u8 max_slices,
 			 u8 max_subslices, u8 max_eus_per_subslice)
 {
Signature · 1 line
2.20.1.7.g153144c
author
#1 lore raw

PATCH 2/2 drm/i915/migrate: remove unneeded semicolon

Eliminate the following coccicheck warning:
./drivers/gpu/drm/i915/gt/intel_migrate.c:643:2-3: Unneeded semicolon

---
 drivers/gpu/drm/i915/gt/intel_migrate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/gt/intel_migrate.c +1 -1
index 9d552f30b627..31da0bfe311c 100644
@@ -640,7 +640,7 @@ static int scatter_list_length(struct scatterlist *sg)
 	while (sg && sg_dma_len(sg)) {
 		len += sg_dma_len(sg);
 		sg = sg_next(sg);
-	};
+	}
 
 	return len;
 }
Signature · 1 line
2.20.1.7.g153144c
maintainer
#2 lore raw
In reply to Yang Li
Quoted 6 lines · Yang Li

Fix following includecheck warning:
./drivers/gpu/drm/i915/gt/intel_sseu.c: linux/string_helpers.h is included more than once.

Already fixed by commit 10dcf783f7e9 ("drm/i915: remove superfluous string helper include").

BR,
Jani.

Quoted 17 lines
---
 drivers/gpu/drm/i915/gt/intel_sseu.c | 2 --
 1 file changed, 2 deletions(-)
drivers/gpu/drm/i915/gt/intel_sseu.c +0 -2
index 9881a6790574..fdd25691beda 100644
@@ -10,8 +10,6 @@
 #include "intel_gt_regs.h"
 #include "intel_sseu.h"
 
-#include "linux/string_helpers.h"
-
 void intel_sseu_set_info(struct sseu_dev_info *sseu, u8 max_slices,
 			 u8 max_subslices, u8 max_eus_per_subslice)
 {
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center