Skip to contentSkip to conversation

Add support for DP and HDMI on j721e-sk

PATCH Applied Rahul T R 3 participants 5 messages May 5, 2022 – May 6, 2022

Subsystems (2)
lore
Share & tools
lore

Rahul T R

author
#0 lore raw

v2 cover Add support for DP and HDMI on j721e-sk

The following series of patches enables DisplayPort and HDMI on j721e-sk

v2:
- Fix name for dpi1 dss endpoint

This series depends on
https://lore.kernel.org/all/[email protected]/
which adds required nodes in the SoC dtsi file

boot logs:
https://gist.githubusercontent.com/ravi-rahul/d2e139d8ff9446ede003291a6a3e8be5/raw/ed51498efe7f7bc4848dffb27e2b37e0beb7a94d/j7_sk_DP_HDMI_boot.log

kernel patch verify report:
https://gist.githubusercontent.com/ravi-rahul/1e2350b53ac7d6ba7694373c0b3bbb44/raw/f09f75821610b42ad1f8b4bf3e5ef7843de0c76e/report-kernel-patch-verify-sk-dp-hdmi.txt

Rahul T R (2):
arm64: dts: ti: k3-j721e-sk: Enable DisplayPort
arm64: dts: ti: k3-j721e-sk: Enable HDMI

 arch/arm64/boot/dts/ti/k3-j721e-sk.dts | 123 ++++++++++++++++++++++++-
 1 file changed, 119 insertions(+), 4 deletions(-)
Signature · 1 line
2.17.1
author
#1 lore raw

PATCH v2 1/2 arm64: dts: ti: k3-j721e-sk: Enable DisplayPort

Add the endpoint nodes to describe connection from DSS => MHDP => DisplayPort connector.

---
 arch/arm64/boot/dts/ti/k3-j721e-sk.dts | 45 +++++++++++++++++++++++---
 1 file changed, 41 insertions(+), 4 deletions(-)
arch/arm64/boot/dts/ti/k3-j721e-sk.dts +41 -4
index 98177a20b45f..07b1e40fbc47 100644
@@ -213,6 +213,18 @@
 		enable-active-high;
 	};
 
+	dp0: connector {
+		compatible = "dp-connector";
+		label = "DP0";
+		type = "full-size";
+		dp-pwr-supply = <&dp_pwr_3v3>;
+
+		port {
+			dp_connector_in: endpoint {
+				remote-endpoint = <&dp0_out>;
+			};
+		};
+	};
 };
 
 &main_pmx0 {
@@ -638,6 +650,8 @@
 &mhdp {
 	phys = <&torrent_phy_dp>;
 	phy-names = "dpphy";
+	pinctrl-names = "default";
+	pinctrl-0 = <&dp0_pins_default>;
 };
 
 &usbss0 {
@@ -718,6 +732,33 @@
 				 <&k3_clks 152 18>;	/* DPI1_EXT_CLKSEL_OUT0 */
 };
 
+&dss_ports {
+	port {
+		dpi0_out: endpoint {
+			remote-endpoint = <&dp0_in>;
+		};
+	};
+};
+
+&dp0_ports {
+	#address-cells = <1>;
+	#size-cells = <0>;
+
+	port@0 {
+		reg = <0>;
+		dp0_in: endpoint {
+			remote-endpoint = <&dpi0_out>;
+		};
+	};
+
+	port@4 {
+		reg = <4>;
+		dp0_out: endpoint {
+			remote-endpoint = <&dp_connector_in>;
+		};
+	};
+};
+
 &mcasp0 {
 	/* Unused */
 	status = "disabled";
@@ -852,10 +893,6 @@
 	status = "disabled";
 };
 
-&dss {
-	status = "disabled";
-};
-
 &icssg0_mdio {
 	status = "disabled";
 };
Signature · 1 line
2.17.1
author
#2 lore raw

PATCH v2 2/2 arm64: dts: ti: k3-j721e-sk: Enable HDMI

In reply to Rahul T R

Add node for dvi bridge and the endpoint nodes to describe connection from
DSS => TI TFP410 DPI-to-DVI Bridge => HDMI connector. Also add the required pinmux for HDMI hotplug and powerdown

---
 arch/arm64/boot/dts/ti/k3-j721e-sk.dts | 80 +++++++++++++++++++++++++-
 1 file changed, 79 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/ti/k3-j721e-sk.dts +79 -1
index 07b1e40fbc47..80358cba6954 100644
@@ -225,6 +225,59 @@
 			};
 		};
 	};
+
+	hdmi-connector {
+		compatible = "hdmi-connector";
+		label = "hdmi";
+		type = "a";
+
+		pinctrl-names = "default";
+		pinctrl-0 = <&hdmi_hpd_pins_default>;
+
+		ddc-i2c-bus = <&main_i2c1>;
+
+		/* HDMI_HPD */
+		hpd-gpios = <&main_gpio1 0 GPIO_ACTIVE_HIGH>;
+
+		port {
+			hdmi_connector_in: endpoint {
+				remote-endpoint = <&tfp410_out>;
+			};
+		};
+	};
+
+	dvi-bridge {
+		compatible = "ti,tfp410";
+
+		pinctrl-names = "default";
+		pinctrl-0 = <&hdmi_pdn_pins_default>;
+
+		powerdown-gpios = <&main_gpio0 127 GPIO_ACTIVE_LOW>;
+		ti,deskew = <0>;
+
+		ports {
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			port@0 {
+				reg = <0>;
+
+				tfp410_in: endpoint {
+					remote-endpoint = <&dpi1_out>;
+					pclk-sample = <1>;
+				};
+			};
+
+			port@1 {
+				reg = <1>;
+
+				tfp410_out: endpoint {
+					remote-endpoint =
+						<&hdmi_connector_in>;
+				};
+			};
+		};
+	};
 };
 
 &main_pmx0 {
@@ -329,6 +382,18 @@
 		>;
 	};
 
+	hdmi_hpd_pins_default: hdmi-hpd-pins-default {
+		pinctrl-single,pins = <
+			J721E_IOPAD(0x204, PIN_INPUT, 7) /* (AD5) UART1_RTSn.GPIO1_0 */
+		>;
+	};
+
+	hdmi_pdn_pins_default: hdmi-pdn-pins-default {
+		pinctrl-single,pins = <
+			J721E_IOPAD(0x200, PIN_INPUT, 7) /* (AC4) UART1_CTSn.GPIO0_127 */
+		>;
+	};
+
 	/* Reset for M.2 E Key slot on PCIe0  */
 	ekey_reset_pins_default: ekey-reset-pns-pins-default {
 		pinctrl-single,pins = <
@@ -733,11 +798,24 @@
 };
 
 &dss_ports {
-	port {
+	#address-cells = <1>;
+	#size-cells = <0>;
+
+	port@0  {
+		reg = <0>;
+
 		dpi0_out: endpoint {
 			remote-endpoint = <&dp0_in>;
 		};
 	};
+
+	port@1 {
+		reg = <1>;
+
+		dpi1_out: endpoint {
+			remote-endpoint = <&tfp410_in>;
+		};
+	};
 };
 
 &dp0_ports {
Signature · 1 line
2.17.1
Reviewed-by on the v2 series
#3 lore raw
In reply to Rahul T R
Quoted 14 lines · Rahul T R

The following series of patches enables DisplayPort and HDMI on j721e-sk

v2:
- Fix name for dpi1 dss endpoint

This series depends on
https://lore.kernel.org/all/[email protected]/
which adds required nodes in the SoC dtsi file

boot logs:

   https://gist.githubusercontent.com/ravi-rahul/d2e139d8ff9446ede003291a6a3e8be5/raw/ed51498efe7f7bc4848dffb27e2b37e0beb7a94d/j7_sk_DP_HDMI_boot.log

kernel patch verify report:

Quoted 9 lines
   https://gist.githubusercontent.com/ravi-rahul/1e2350b53ac7d6ba7694373c0b3bbb44/raw/f09f75821610b42ad1f8b4bf3e5ef7843de0c76e/report-kernel-patch-verify-sk-dp-hdmi.txt

Rahul T R (2):
arm64: dts: ti: k3-j721e-sk: Enable DisplayPort
arm64: dts: ti: k3-j721e-sk: Enable HDMI

 arch/arm64/boot/dts/ti/k3-j721e-sk.dts | 123 ++++++++++++++++++++++++-
 1 file changed, 119 insertions(+), 4 deletions(-)
maintainer Applied
#4 lore raw
In reply to Rahul T R

Hi Rahul T R,

Quoted 11 lines · Rahul T R

The following series of patches enables DisplayPort and HDMI on j721e-sk

v2:
- Fix name for dpi1 dss endpoint

This series depends on
https://lore.kernel.org/all/[email protected]/
which adds required nodes in the SoC dtsi file

[...]

I have applied the following to branch ti-k3-dts-next on [1]. Thank you!

[1/2] arm64: dts: ti: k3-j721e-sk: Enable DisplayPort

      commit: d4f3c8a169ab82b91ba1e10a495e900477a75cf5
[2/2] arm64: dts: ti: k3-j721e-sk: Enable HDMI
      commit: 7d4686fc3c2ad9bfd1eaf3c54515d6469e542578

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent up the chain during the next merge window (or sooner if it is a relevant bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
--
Vignesh