Skip to contentSkip to conversation

ARM: configs: at91: Enable options required for systemd

PATCH RESEND Superseded Mark Brown 2 participants 4 messages May 5, 2022

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH RESEND 1/1 ARM: configs: at91: Enable options required for systemd

Even smaller embedded systems are using systemd these days, as are test automation systems like KernelCI, so it is useful to be able to use systemd on these boards by default. Enable options that are missing in the at91_dt_defconfig, cgroups which is critical and autofs4 which is less critical but causes warnings on boot when not available.

---

This would be useful for KernelCI which uses a systemd based rootfs for many tests.

 arch/arm/configs/at91_dt_defconfig | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/configs/at91_dt_defconfig +2 -0
index 549d01be0b47..bbb7f400a57f 100644
@@ -4,6 +4,7 @@ CONFIG_SYSVIPC=y
 CONFIG_NO_HZ_IDLE=y
 CONFIG_HIGH_RES_TIMERS=y
 CONFIG_LOG_BUF_SHIFT=14
+CONFIG_CGROUPS=y
 CONFIG_BLK_DEV_INITRD=y
 CONFIG_CC_OPTIMIZE_FOR_SIZE=y
 CONFIG_KALLSYMS_ALL=y
@@ -205,6 +206,7 @@ CONFIG_PWM_ATMEL=y
 CONFIG_PWM_ATMEL_HLCDC_PWM=y
 CONFIG_PWM_ATMEL_TCB=y
 CONFIG_EXT4_FS=y
+CONFIG_AUTOFS4_FS=m
 CONFIG_FANOTIFY=y
 CONFIG_VFAT_FS=y
 CONFIG_TMPFS=y
Signature · 1 line
2.30.2
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Mark Brown

Even smaller embedded systems are using systemd these days, as are test automation systems like KernelCI, so it is useful to be able to use systemd on these boards by default. Enable options that are missing in the at91_dt_defconfig, cgroups which is critical and autofs4 which is less critical but causes warnings on boot when not available.

Quoted 5 lines

---

This would be useful for KernelCI which uses a systemd based rootfs for many tests.

Sure Mark, sorry for the delay. We are just generating the 5.19 branches right now.

and queued in at91-defconfig branch for 5.19. It should appear in linux-next in a couple of days.

Best regards,
Nicolas

Quoted 26 lines
  arch/arm/configs/at91_dt_defconfig | 2 ++
  1 file changed, 2 insertions(+)
arch/arm/configs/at91_dt_defconfig +2 -1
index 549d01be0b47..bbb7f400a57f 100644
@@ -4,6 +4,7 @@ CONFIG_SYSVIPC=y
  CONFIG_NO_HZ_IDLE=y
  CONFIG_HIGH_RES_TIMERS=y
  CONFIG_LOG_BUF_SHIFT=14
+CONFIG_CGROUPS=y
  CONFIG_BLK_DEV_INITRD=y
  CONFIG_CC_OPTIMIZE_FOR_SIZE=y
  CONFIG_KALLSYMS_ALL=y
@@ -205,6 +206,7 @@ CONFIG_PWM_ATMEL=y
  CONFIG_PWM_ATMEL_HLCDC_PWM=y
  CONFIG_PWM_ATMEL_TCB=y
  CONFIG_EXT4_FS=y
+CONFIG_AUTOFS4_FS=m
  CONFIG_FANOTIFY=y
  CONFIG_VFAT_FS=y
  CONFIG_TMPFS=y
--

2.30.2

Signature · 1 line
Nicolas Ferre
maintainer
#2 lore raw
In reply to Mark Brown

Mark,

Quoted 29 lines · Mark Brown

Even smaller embedded systems are using systemd these days, as are test automation systems like KernelCI, so it is useful to be able to use systemd on these boards by default. Enable options that are missing in the at91_dt_defconfig, cgroups which is critical and autofs4 which is less critical but causes warnings on boot when not available.

---

This would be useful for KernelCI which uses a systemd based rootfs for many tests.

  arch/arm/configs/at91_dt_defconfig | 2 ++
  1 file changed, 2 insertions(+)
arch/arm/configs/at91_dt_defconfig +1 -0
index 549d01be0b47..bbb7f400a57f 100644
@@ -4,6 +4,7 @@ CONFIG_SYSVIPC=y
  CONFIG_NO_HZ_IDLE=y
  CONFIG_HIGH_RES_TIMERS=y
  CONFIG_LOG_BUF_SHIFT=14
+CONFIG_CGROUPS=y
  CONFIG_BLK_DEV_INITRD=y
  CONFIG_CC_OPTIMIZE_FOR_SIZE=y
  CONFIG_KALLSYMS_ALL=y

arch/arm/configs/at91_dt_defconfig CONFIG_PWM_ATMEL=y · line 209

Quoted 4 lines
arch/arm/configs/at91_dt_defconfig +1 -0
@@ -205,6 +206,7 @@ CONFIG_PWM_ATMEL=y
  CONFIG_PWM_ATMEL_HLCDC_PWM=y
  CONFIG_PWM_ATMEL_TCB=y
  CONFIG_EXT4_FS=y
+CONFIG_AUTOFS4_FS=m

While trying to add this option to our other defconfigs, I read this in the CONFIG_AUTOFS4_FS entry for 5.18-rc1:

"This name exists for people to just automatically pick up the new name of the autofs Kconfig option. All it does is select the new option name.

It will go away in a release or two as people have transitioned to just plain AUTOFS_FS."

Don't we need to change to CONFIG_AUTOFS_FS now?

Regards,
Nicolas

Quoted 6 lines
arch/arm/configs/at91_dt_defconfig +0 -1
  CONFIG_FANOTIFY=y
  CONFIG_VFAT_FS=y
  CONFIG_TMPFS=y
--

2.30.2

Signature · 1 line
Nicolas Ferre
author
#3 lore raw
Quoted 11 lines · Nicolas Ferre

arch/arm/configs/at91_dt_defconfig CONFIG_PWM_ATMEL=y · line 209

Quoted 5 lines · Mark Brown
arch/arm/configs/at91_dt_defconfig +1 -0
@@ -205,6 +206,7 @@ CONFIG_PWM_ATMEL=y
  CONFIG_PWM_ATMEL_HLCDC_PWM=y
  CONFIG_PWM_ATMEL_TCB=y
  CONFIG_EXT4_FS=y
+CONFIG_AUTOFS4_FS=m

While trying to add this option to our other defconfigs, I read this in the CONFIG_AUTOFS4_FS entry for 5.18-rc1:

Quoted 8 lines

"This name exists for people to just automatically pick up the new name of the autofs Kconfig option. All it does is select the new option name.

It will go away in a release or two as people have transitioned to just plain AUTOFS_FS."

Don't we need to change to CONFIG_AUTOFS_FS now?

That should be fine. I was just picking up options from the systemd documentation.