Skip to contentSkip to conversation

dt-bindings: net: dsa: convert binding for mediatek switches

RFC Superseded Frank Wunderlich 3 participants 5 messages May 5, 2022 – May 6, 2022

Subsystems (5)

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

RFC v2 1/1 dt-bindings: net: dsa: convert binding for mediatek switches

From: Frank Wunderlich <[email protected]>

Convert txt binding to yaml binding for Mediatek switches.

---
v2:
- rename mediatek.yaml => mediatek,mt7530.yaml
- drop "boolean" in description
- drop description for interrupt-properties
- drop #interrupt-cells as requirement
- example: eth=>ethernet,mdio0=>mdio,comment indention
- replace 0 by GPIO_ACTIVE_HIGH in first example
- use port(s)-pattern from dsa.yaml
- adress/size-cells not added to required because this is defined at mdio-level inc current dts , not switch level

---
 .../bindings/net/dsa/mediatek,mt7530.yaml     | 429 ++++++++++++++++++
 .../devicetree/bindings/net/dsa/mt7530.txt    | 327 -------------
 2 files changed, 429 insertions(+), 327 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
 delete mode 100644 Documentation/devicetree/bindings/net/dsa/mt7530.txt
Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml new file +429 -0
new file mode 100644
index 000000000000..c119a1d4333e
@@ -0,0 +1,429 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/dsa/mediatek,mt7530.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Mediatek MT7530 Ethernet switch
+
+maintainers:
+  - Sean Wang <[email protected]>
+  - Landen Chao <[email protected]>
+  - DENG Qingfang <[email protected]>
+
+description: |
+  Port 5 of mt7530 and mt7621 switch is muxed between:
+  1. GMAC5: GMAC5 can interface with another external MAC or PHY.
+  2. PHY of port 0 or port 4: PHY interfaces with an external MAC like 2nd GMAC
+     of the SOC. Used in many setups where port 0/4 becomes the WAN port.
+     Note: On a MT7621 SOC with integrated switch: 2nd GMAC can only connected to
+       GMAC5 when the gpios for RGMII2 (GPIO 22-33) are not used and not
+       connected to external component!
+
+  Port 5 modes/configurations:
+  1. Port 5 is disabled and isolated: An external phy can interface to the 2nd
+     GMAC of the SOC.
+     In the case of a build-in MT7530 switch, port 5 shares the RGMII bus with 2nd
+     GMAC and an optional external phy. Mind the GPIO/pinctl settings of the SOC!
+  2. Port 5 is muxed to PHY of port 0/4: Port 0/4 interfaces with 2nd GMAC.
+     It is a simple MAC to PHY interface, port 5 needs to be setup for xMII mode
+     and RGMII delay.
+  3. Port 5 is muxed to GMAC5 and can interface to an external phy.
+     Port 5 becomes an extra switch port.
+     Only works on platform where external phy TX<->RX lines are swapped.
+     Like in the Ubiquiti ER-X-SFP.
+  4. Port 5 is muxed to GMAC5 and interfaces with the 2nd GAMC as 2nd CPU port.
+     Currently a 2nd CPU port is not supported by DSA code.
+
+  Depending on how the external PHY is wired:
+  1. normal: The PHY can only connect to 2nd GMAC but not to the switch
+  2. swapped: RGMII TX, RX are swapped; external phy interface with the switch as
+     a ethernet port. But can't interface to the 2nd GMAC.
+
+    Based on the DT the port 5 mode is configured.
+
+  Driver tries to lookup the phy-handle of the 2nd GMAC of the master device.
+  When phy-handle matches PHY of port 0 or 4 then port 5 set-up as mode 2.
+  phy-mode must be set, see also example 2 below!
+  * mt7621: phy-mode = "rgmii-txid";
+  * mt7623: phy-mode = "rgmii";
+
+  CPU-Ports need a phy-mode property:
+    Allowed values on mt7530 and mt7621:
+      - "rgmii"
+      - "trgmii"
+    On mt7531:
+      - "1000base-x"
+      - "2500base-x"
+      - "sgmii"
+
+
+properties:
+  compatible:
+    enum:
+      - mediatek,mt7530
+      - mediatek,mt7531
+      - mediatek,mt7621
+
+  "#address-cells":
+    const: 1
+
+  "#size-cells":
+    const: 0
+
+  core-supply:
+    description: |
+      Phandle to the regulator node necessary for the core power.
+
+  "#gpio-cells":
+    description: |
+      Must be 2 if gpio-controller is defined.
+    const: 2
+
+  gpio-controller:
+    type: boolean
+    description: |
+      if defined, MT7530's LED controller will run on GPIO mode.
+
+  "#interrupt-cells":
+    const: 1
+
+  interrupt-controller:
+    type: boolean
+
+  interrupts:
+    maxItems: 1
+
+  io-supply:
+    description: |
+      Phandle to the regulator node necessary for the I/O power.
+      See Documentation/devicetree/bindings/regulator/mt6323-regulator.txt
+      for details for the regulator setup on these boards.
+
+  mediatek,mcm:
+    type: boolean
+    description: |
+      if defined, indicates that either MT7530 is the part on multi-chip
+      module belong to MT7623A has or the remotely standalone chip as the
+      function MT7623N reference board provided for.
+
+  reset-gpios:
+    description: |
+      Should be a gpio specifier for a reset line.
+    maxItems: 1
+
+  reset-names:
+    description: |
+      Should be set to "mcm".
+    const: mcm
+
+  resets:
+    description: |
+      Phandle pointing to the system reset controller with line index for
+      the ethsys.
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+
+allOf:
+  - $ref: "dsa.yaml#"
+  - if:
+      required:
+        - mediatek,mcm
+    then:
+      required:
+        - resets
+        - reset-names
+    else:
+      required:
+        - reset-gpios
+
+  - if:
+      required:
+        - interrupt-controller
+    then:
+      required:
+        - interrupts
+
+  - if:
+      properties:
+        compatible:
+          items:
+            - const: mediatek,mt7530
+    then:
+      required:
+        - core-supply
+        - io-supply
+
+
+patternProperties:
+  "^(ethernet-)?ports$":
+    type: object
+
+    patternProperties:
+      "^(ethernet-)?port@[0-9]+$":
+        type: object
+        description: Ethernet switch ports
+
+        properties:
+          reg:
+            description: |
+              Port address described must be 6 for CPU port and from 0 to 5 for user ports.
+
+        unevaluatedProperties: false
+
+        allOf:
+          - $ref: dsa-port.yaml#
+          - if:
+              properties:
+                label:
+                  items:
+                    - const: cpu
+            then:
+              required:
+                - reg
+                - phy-mode
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+    mdio {
+        #address-cells = <1>;
+        #size-cells = <0>;
+        switch@0 {
+            compatible = "mediatek,mt7530";
+            #address-cells = <1>;
+            #size-cells = <0>;
+            reg = <0>;
+
+            core-supply = <&mt6323_vpa_reg>;
+            io-supply = <&mt6323_vemc3v3_reg>;
+            reset-gpios = <&pio 33 GPIO_ACTIVE_HIGH>;
+
+            ports {
+                #address-cells = <1>;
+                #size-cells = <0>;
+                port@0 {
+                    reg = <0>;
+                    label = "lan0";
+                };
+
+                port@1 {
+                    reg = <1>;
+                    label = "lan1";
+                };
+
+                port@2 {
+                    reg = <2>;
+                    label = "lan2";
+                };
+
+                port@3 {
+                    reg = <3>;
+                    label = "lan3";
+                };
+
+                port@4 {
+                    reg = <4>;
+                    label = "wan";
+                };
+
+                port@6 {
+                    reg = <6>;
+                    label = "cpu";
+                    ethernet = <&gmac0>;
+                    phy-mode = "trgmii";
+                    fixed-link {
+                        speed = <1000>;
+                        full-duplex;
+                    };
+                };
+            };
+        };
+    };
+
+  - |
+    //Example 2: MT7621: Port 4 is WAN port: 2nd GMAC -> Port 5 -> PHY port 4.
+
+    ethernet {
+        #address-cells = <1>;
+        #size-cells = <0>;
+        gmac0: mac@0 {
+            compatible = "mediatek,eth-mac";
+            reg = <0>;
+            phy-mode = "rgmii";
+
+            fixed-link {
+                speed = <1000>;
+                full-duplex;
+                pause;
+            };
+        };
+
+        gmac1: mac@1 {
+            compatible = "mediatek,eth-mac";
+            reg = <1>;
+            phy-mode = "rgmii-txid";
+            phy-handle = <&phy4>;
+        };
+
+        mdio: mdio-bus {
+            #address-cells = <1>;
+            #size-cells = <0>;
+
+            /* Internal phy */
+            phy4: ethernet-phy@4 {
+                reg = <4>;
+            };
+
+            mt7530: switch@1f {
+                compatible = "mediatek,mt7621";
+                #address-cells = <1>;
+                #size-cells = <0>;
+                reg = <0x1f>;
+                mediatek,mcm;
+
+                resets = <&rstctrl 2>;
+                reset-names = "mcm";
+
+                ports {
+                    #address-cells = <1>;
+                    #size-cells = <0>;
+
+                    port@0 {
+                        reg = <0>;
+                        label = "lan0";
+                    };
+
+                    port@1 {
+                        reg = <1>;
+                        label = "lan1";
+                    };
+
+                    port@2 {
+                        reg = <2>;
+                        label = "lan2";
+                    };
+
+                    port@3 {
+                        reg = <3>;
+                        label = "lan3";
+                    };
+
+                    /* Commented out. Port 4 is handled by 2nd GMAC.
+                    port@4 {
+                        reg = <4>;
+                        label = "lan4";
+                    };
+                    */
+
+                    port@6 {
+                        reg = <6>;
+                        label = "cpu";
+                        ethernet = <&gmac0>;
+                        phy-mode = "rgmii";
+
+                        fixed-link {
+                            speed = <1000>;
+                            full-duplex;
+                            pause;
+                        };
+                    };
+                };
+            };
+        };
+    };
+
+  - |
+    //Example 3: MT7621: Port 5 is connected to external PHY: Port 5 -> external PHY.
+
+    ethernet {
+        #address-cells = <1>;
+        #size-cells = <0>;
+        gmac_0: mac@0 {
+            compatible = "mediatek,eth-mac";
+            reg = <0>;
+            phy-mode = "rgmii";
+
+            fixed-link {
+                speed = <1000>;
+                full-duplex;
+                pause;
+            };
+        };
+
+        mdio0: mdio-bus {
+            #address-cells = <1>;
+            #size-cells = <0>;
+
+            /* External phy */
+            ephy5: ethernet-phy@7 {
+                reg = <7>;
+            };
+
+            switch@1f {
+                compatible = "mediatek,mt7621";
+                #address-cells = <1>;
+                #size-cells = <0>;
+                reg = <0x1f>;
+                mediatek,mcm;
+
+                resets = <&rstctrl 2>;
+                reset-names = "mcm";
+
+                ports {
+                    #address-cells = <1>;
+                    #size-cells = <0>;
+
+                    port@0 {
+                        reg = <0>;
+                        label = "lan0";
+                    };
+
+                    port@1 {
+                        reg = <1>;
+                        label = "lan1";
+                    };
+
+                    port@2 {
+                        reg = <2>;
+                        label = "lan2";
+                    };
+
+                    port@3 {
+                        reg = <3>;
+                        label = "lan3";
+                    };
+
+                    port@4 {
+                        reg = <4>;
+                        label = "lan4";
+                    };
+
+                    port@5 {
+                        reg = <5>;
+                        label = "lan5";
+                        phy-mode = "rgmii";
+                        phy-handle = <&ephy5>;
+                    };
+
+                    cpu_port0: port@6 {
+                        reg = <6>;
+                        label = "cpu";
+                        ethernet = <&gmac_0>;
+                        phy-mode = "rgmii";
+
+                        fixed-link {
+                            speed = <1000>;
+                            full-duplex;
+                            pause;
+                        };
+                    };
+                };
+            };
+        };
+    };
Documentation/devicetree/bindings/net/dsa/mt7530.txt deleted +0 -327

327 lines not on this page · raw message

Signature · 1 line
2.25.1
#1 lore raw
Quoted 5 lines · Frank Wunderlich

From: Frank Wunderlich <[email protected]>

Convert txt binding to yaml binding for Mediatek switches.

Thank you for your patch. There is something to discuss/improve.

Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml line 75

Quoted 7 lines
Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml new file +7 -0
+    const: 1
+
+  "#size-cells":
+    const: 0
+
+  core-supply:
+    description: |

Drop | everywhere where it is not needed (so in all places, AFAICT)

Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml line 80

Quoted 5 lines
Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml new file +5 -0
+      Phandle to the regulator node necessary for the core power.
+
+  "#gpio-cells":
+    description: |
+      Must be 2 if gpio-controller is defined.

Skip description, it's obvious from the GPIO controller schema.

Quoted 22 lines
Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml new file +22 -0
+    const: 2
+
+  gpio-controller:
+    type: boolean
+    description: |
+      if defined, MT7530's LED controller will run on GPIO mode.
+
+  "#interrupt-cells":
+    const: 1
+
+  interrupt-controller:
+    type: boolean
+
+  interrupts:
+    maxItems: 1
+
+  io-supply:
+    description: |
+      Phandle to the regulator node necessary for the I/O power.
+      See Documentation/devicetree/bindings/regulator/mt6323-regulator.txt
+      for details for the regulator setup on these boards.
+

Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml line 112

Quoted 10 lines
Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml new file +10 -0
+  mediatek,mcm:
+    type: boolean
+    description: |
+      if defined, indicates that either MT7530 is the part on multi-chip
+      module belong to MT7623A has or the remotely standalone chip as the
+      function MT7623N reference board provided for.
+
+  reset-gpios:
+    description: |
+      Should be a gpio specifier for a reset line.

Skip description.

Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml line 117

Quoted 5 lines
Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml new file +5 -0
+    maxItems: 1
+
+  reset-names:
+    description: |
+      Should be set to "mcm".

Skip description.

Quoted 34 lines
Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml new file +34 -0
+    const: mcm
+
+  resets:
+    description: |
+      Phandle pointing to the system reset controller with line index for
+      the ethsys.
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+
+allOf:
+  - $ref: "dsa.yaml#"
+  - if:
+      required:
+        - mediatek,mcm
+    then:
+      required:
+        - resets
+        - reset-names
+    else:
+      required:
+        - reset-gpios
+
+  - if:
+      required:
+        - interrupt-controller
+    then:
+      required:
+        - interrupts
+
+  - if:
+      properties:

Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml line 161

Quoted 10 lines
Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml new file +10 -0
+        compatible:
+          items:
+            - const: mediatek,mt7530
+    then:
+      required:
+        - core-supply
+        - io-supply
+
+
+patternProperties:

patternProperties go before allOf, just after regular properties.

Review

Quoted 2 lines
(quoted diff) +2 -0
+  "^(ethernet-)?ports$":
+    type: object

Also on this level:
unevaluatedProperties: false

Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml line 173

Quoted 10 lines
Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml new file +10 -0
+
+    patternProperties:
+      "^(ethernet-)?port@[0-9]+$":
+        type: object
+        description: Ethernet switch ports
+
+        properties:
+          reg:
+            description: |
+              Port address described must be 6 for CPU port and from 0 to 5 for user ports.

This looks like not wrapped @80 character.

Quoted 6 lines
Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml new file +6 -0
+
+        unevaluatedProperties: false
+
+        allOf:
+          - $ref: dsa-port.yaml#
+          - if:

Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml line 189

Quoted 10 lines
Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml new file +10 -0
+              properties:
+                label:
+                  items:
+                    - const: cpu
+            then:
+              required:
+                - reg
+                - phy-mode
+
+unevaluatedProperties: false

Best regards,
Krzysztof

#2 lore raw

Hi

Quoted 15 lines

Gesendet: Donnerstag, 05. Mai 2022 um 22:29 Uhr
Von: "Krzysztof Kozlowski" <[email protected]>
An: "Frank Wunderlich" <[email protected]>, [email protected]
Cc: "Frank Wunderlich" <[email protected]>, "Andrew Lunn" <[email protected]>, "Vivien Didelot" <[email protected]>, "Florian Fainelli" <[email protected]>, "Vladimir Oltean" <[email protected]>, "David S. Miller" <[email protected]>, "Jakub Kicinski" <[email protected]>, "Paolo Abeni" <[email protected]>, "Rob Herring" <[email protected]>, "Krzysztof Kozlowski" <[email protected]>, "Matthias Brugger" <[email protected]>, "Sean Wang" <[email protected]>, "Landen Chao" <[email protected]>, "DENG Qingfang" <[email protected]>, [email protected], [email protected], [email protected], [email protected], "Greg Ungerer" <[email protected]>, "René van Dorst" <[email protected]>, "Mauro Carvalho Chehab" <[email protected]>
Betreff: Re: [RFC v2] dt-bindings: net: dsa: convert binding for mediatek switches

Quoted 5 lines · Frank Wunderlich

From: Frank Wunderlich <[email protected]>

Convert txt binding to yaml binding for Mediatek switches.

Thank you for your patch. There is something to discuss/improve.

Quoted 9 lines

Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml line 75

Quoted 7 lines
Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml new file +7 -0
+    const: 1
+
+  "#size-cells":
+    const: 0
+
+  core-supply:
+    description: |

Drop | everywhere where it is not needed (so in all places, AFAICT)

is it necessary for multiline-descriptions or is indentation enough?

Quoted 7 lines

Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml line 80

Quoted 5 lines
Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml new file +5 -0
+      Phandle to the regulator node necessary for the core power.
+
+  "#gpio-cells":
+    description: |
+      Must be 2 if gpio-controller is defined.

Skip description, it's obvious from the GPIO controller schema.

ok

Quoted 26 lines
Quoted 26 lines
Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml new file +26 -0
+    const: 2
+
+  gpio-controller:
+    type: boolean
+    description: |
+      if defined, MT7530's LED controller will run on GPIO mode.
+
+  "#interrupt-cells":
+    const: 1
+
+  interrupt-controller:
+    type: boolean
+
+  interrupts:
+    maxItems: 1
+
+  io-supply:
+    description: |
+      Phandle to the regulator node necessary for the I/O power.
+      See Documentation/devicetree/bindings/regulator/mt6323-regulator.txt
+      for details for the regulator setup on these boards.
+
+  mediatek,mcm:
+    type: boolean
+    description: |
+      if defined, indicates that either MT7530 is the part on multi-chip
Quoted 8 lines

Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml line 112

Quoted 6 lines
Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml new file +6 -0
+      module belong to MT7623A has or the remotely standalone chip as the
+      function MT7623N reference board provided for.
+
+  reset-gpios:
+    description: |
+      Should be a gpio specifier for a reset line.

Skip description.

ok

Quoted 7 lines

Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml line 117

Quoted 5 lines
Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml new file +5 -0
+    maxItems: 1
+
+  reset-names:
+    description: |
+      Should be set to "mcm".

Skip description.

ok

Quoted 38 lines
Quoted 38 lines
Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml new file +38 -0
+    const: mcm
+
+  resets:
+    description: |
+      Phandle pointing to the system reset controller with line index for
+      the ethsys.
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+
+allOf:
+  - $ref: "dsa.yaml#"
+  - if:
+      required:
+        - mediatek,mcm
+    then:
+      required:
+        - resets
+        - reset-names
+    else:
+      required:
+        - reset-gpios
+
+  - if:
+      required:
+        - interrupt-controller
+    then:
+      required:
+        - interrupts
+
+  - if:
+      properties:
+        compatible:
+          items:
+            - const: mediatek,mt7530
+    then:
Quoted 8 lines

Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml line 161

Quoted 6 lines
Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml new file +6 -0
+      required:
+        - core-supply
+        - io-supply
+
+
+patternProperties:

patternProperties go before allOf, just after regular properties.

after required, right?

Quoted 5 lines

Review

Quoted 2 lines
(quoted diff) +2 -0
+  "^(ethernet-)?ports$":
+    type: object

Also on this level:
unevaluatedProperties: false

this is imho a bit redundant because in dsa.yaml (which is included now after patternProperties) it is already set on both levels.
Adding it here will fail in examples because of size/address-cells which are already defined in dsa.yaml... so i need to define them here again.

Quoted 4 lines
Quoted 4 lines
Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml new file +4 -0
+
+    patternProperties:
+      "^(ethernet-)?port@[0-9]+$":
+        type: object
Quoted 8 lines

Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml line 173

Quoted 6 lines
Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml new file +6 -0
+        description: Ethernet switch ports
+
+        properties:
+          reg:
+            description: |
+              Port address described must be 6 for CPU port and from 0 to 5 for user ports.

This looks like not wrapped @80 character.

i fix this

Quoted 11 lines
Quoted 11 lines
Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml new file +11 -0
+
+        unevaluatedProperties: false
+
+        allOf:
+          - $ref: dsa-port.yaml#
+          - if:
+              properties:
+                label:
+                  items:
+                    - const: cpu
+            then:
Quoted 8 lines

Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml line 189

Quoted 5 lines
Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml new file +5 -0
+              required:
+                - reg
+                - phy-mode
+
+unevaluatedProperties: false

Best regards,
Krzysztof

regards Frank

_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek

#3 lore raw
Quoted 11 lines · Frank Wunderlich
Quoted 9 lines

Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml line 75

Quoted 7 lines
Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml new file +7 -0
+    const: 1
+
+  "#size-cells":
+    const: 0
+
+  core-supply:
+    description: |

Drop | everywhere where it is not needed (so in all places, AFAICT)

is it necessary for multiline-descriptions or is indentation enough?

It's necessary only when YAML syntax characters appear in description or when you want specific formatting.

https://elixir.bootlin.com/linux/v5.18-rc5/source/Documentation/devicetree/bindings/example-schema.yaml#L97

https://yaml-multiline.info/

Quoted 6 lines
Quoted 4 lines

Review

Quoted 2 lines
(quoted diff) +2 -0
+
+patternProperties:

patternProperties go before allOf, just after regular properties.

after required, right?

properties do not go after required, so neither patternProperties should. Something like: propertes -> patternProperties -> dependencies -> required -> allOf -> additionalProperties -> examples

Quoted 9 lines
Quoted 6 lines

Review

Quoted 3 lines
(quoted diff) +2 -0
+  "^(ethernet-)?ports$":
+    type: object

Also on this level:
unevaluatedProperties: false

this is imho a bit redundant because in dsa.yaml (which is included now after patternProperties) it is already set on both levels.

dsa.yaml does not set it on ethernet-ports.

Quoted 2 lines

Adding it here will fail in examples because of size/address-cells which are already defined in dsa.yaml... so i need to define them here again.

You're right, it cannot be set here.

Best regards,
Krzysztof

#4 lore raw

Am 6. Mai 2022 09:15:12 MESZ schrieb Krzysztof Kozlowski <[email protected]>:

Quoted 13 lines · Frank Wunderlich
Quoted 11 lines
Quoted 9 lines

Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml line 75

Quoted 7 lines
Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml new file +7 -0
+    const: 1
+
+  "#size-cells":
+    const: 0
+
+  core-supply:
+    description: |

Drop | everywhere where it is not needed (so in all places, AFAICT)

is it necessary for multiline-descriptions or is indentation enough?

Quoted 7 lines

It's necessary only when YAML syntax characters appear in description or
when you want specific formatting.

https://elixir.bootlin.com/linux/v5.18-rc5/source/Documentation/devicetree/bindings/example-schema.yaml#L97

https://yaml-multiline.info/

Ok then i drop all except on examples

Quoted 10 lines
Quoted 6 lines
Quoted 4 lines

Review

Quoted 2 lines
(quoted diff) +2 -0
+
+patternProperties:

patternProperties go before allOf, just after regular properties.

after required, right?

properties do not go after required, so neither patternProperties should. Something like: propertes -> patternProperties -> dependencies -> required -> allOf -> additionalProperties -> examples

Thx for explanation

So i end up like this:

https://github.com/frank-w/BPI-R2-4.14/blob/5.18-mt7531-mainline/Documentation/devicetree/bindings/net/dsa/mediatek%2Cmt7530.yaml

Including followup (remove reset-gpios and add rgmii for mt7531).

Quoted 11 lines
Quoted 8 lines
Quoted 6 lines

Review

Quoted 3 lines
(quoted diff) +2 -0
+  "^(ethernet-)?ports$":
+    type: object

Also on this level:
unevaluatedProperties: false

this is imho a bit redundant because in dsa.yaml (which is included

now after patternProperties)

Quoted 1 line

it is already set on both levels.

Quoted 7 lines

dsa.yaml does not set it on ethernet-ports.

Quoted 1 line

Adding it here will fail in examples because of size/address-cells

which are already defined in dsa.yaml...

Quoted 1 line

so i need to define them here again.

You're right, it cannot be set here.

So i make no change here,right?

Quoted 2 lines

Best regards,
Krzysztof

regards Frank