Skip to contentSkip to conversation

tests/kms_flip: Update logic to calculate test duration

PATCH In review Karthik B S 3 participants 5 messages May 6, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tests/kms_flip: Update logic to calculate test duration

Few of the subtests are intended to run only for one iteration with duration of 0. But because of the existing logic to calculate duration, even these subtests are running in loop for 0.5s. This is causing excessive logging in the nonexisting-fb subtests.

Added check to use duration calculation logic only if duration is non-zero in the first place.

---
 tests/kms_flip.c | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)
tests/kms_flip.c +10 -4
index ce452dc8..773e6597 100755
@@ -1537,8 +1537,11 @@ static int run_test(int duration, int flags)
 	}
 
 	igt_require(modes);
-	duration = duration * 1000 / modes;
-	duration = max(500, duration);
+
+	if (duration) {
+		duration = duration * 1000 / modes;
+		duration = max(500, duration);
+	}
 
 	/* Find any connected displays */
 	for (i = 0; i < resources->count_connectors; i++) {
@@ -1605,8 +1608,11 @@ static int run_pair(int duration, int flags)
 	/* If we have fewer than 2 connected outputs then we won't have any
 	 * configuration at all. So skip in that case. */
 	igt_require_f(modes, "At least two displays required\n");
-	duration = duration * 1000 / modes;
-	duration = max(duration, 500);
+
+	if (duration) {
+		duration = duration * 1000 / modes;
+		duration = max(duration, 500);
+	}
 
 	/* Find a pair of connected displays */
 	for (i = 0; i < resources->count_connectors; i++) {
Signature · 1 line
2.22.0
#1 lore raw

[igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_flip: Update logic to calculate test duration

== Series Details ==

== Series Details ==

Series: tests/kms_flip: Update logic to calculate test duration
URL : https://patchwork.freedesktop.org/series/103655/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_11614 -> IGTPW_7047
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_7047 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_7047, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7047/index.html

Participating hosts (41 -> 40)
------------------------------

Additional (1): bat-adlm-1
Missing (2): fi-bsw-cyan fi-icl-u2

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_7047:

### IGT changes ###

#### Possible regressions ####

* igt@i915_selftest@live@workarounds:
- fi-bdw-5557u: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11614/fi-bdw-5557u/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7047/fi-bdw-5557u/igt@i915_selftest@[email protected]

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* igt@i915_selftest@live@gt_mocs:
- {bat-adlm-1}: NOTRUN -> [INCOMPLETE][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7047/bat-adlm-1/igt@i915_selftest@live@gt_mocs.html

Known issues
------------

Here are the changes found in IGTPW_7047 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_selftest@live@perf:
- fi-tgl-1115g4: [PASS][4] -> [DMESG-WARN][5] ([i915#2867]) +1 similar issue
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11614/fi-tgl-1115g4/igt@i915_selftest@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7047/fi-tgl-1115g4/igt@i915_selftest@[email protected]

* igt@kms_chamelium@common-hpd-after-suspend:
- fi-bsw-n3050: NOTRUN -> [SKIP][6] ([fdo#109271] / [fdo#111827])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7047/fi-bsw-n3050/igt@[email protected]

* igt@kms_flip@basic-flip-vs-modeset@b-edp1:
- bat-adlp-4: [PASS][7] -> [DMESG-WARN][8] ([i915#3576]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11614/bat-adlp-4/igt@kms_flip@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7047/bat-adlp-4/igt@kms_flip@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-bsw-n3050: NOTRUN -> [SKIP][9] ([fdo#109271])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7047/fi-bsw-n3050/igt@[email protected]

#### Possible fixes ####

* igt@core_hotunplug@unbind-rebind:
- {bat-rpls-2}: [DMESG-WARN][10] ([i915#4391]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11614/bat-rpls-2/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7047/bat-rpls-2/igt@[email protected]

* igt@i915_pm_rpm@module-reload:
- bat-adlp-4: [DMESG-WARN][12] ([i915#3576]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11614/bat-adlp-4/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7047/bat-adlp-4/igt@[email protected]

* igt@i915_selftest@live@execlists:
- fi-bsw-n3050: [INCOMPLETE][14] ([i915#2940] / [i915#5801]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11614/fi-bsw-n3050/igt@i915_selftest@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7047/fi-bsw-n3050/igt@i915_selftest@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5329]: https://gitlab.freedesktop.org/drm/intel/issues/5329
[i915#5401]: https://gitlab.freedesktop.org/drm/intel/issues/5401
[i915#5509]: https://gitlab.freedesktop.org/drm/intel/issues/5509
[i915#5537]: https://gitlab.freedesktop.org/drm/intel/issues/5537
[i915#5801]: https://gitlab.freedesktop.org/drm/intel/issues/5801

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_6467 -> IGTPW_7047

CI-20190529: 20190529
CI_DRM_11614: b34f19b38e76292c5ac846fb9a8d4d0c4036dd78 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_7047: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7047/index.html
IGT_6467: 929abc51cdd48d673efa03e025b1f31b557972ed @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7047/index.html

#2 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for tests/kms_flip: Update logic to calculate test duration (rev2)

In reply to Karthik B S
== Series Details ==

== Series Details ==

Series: tests/kms_flip: Update logic to calculate test duration (rev2)
URL : https://patchwork.freedesktop.org/series/103655/
State : success

== Summary ==

CI Bug Log - changes from IGT_6468 -> IGTPW_7051
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7051/index.html

Participating hosts (42 -> 42)
------------------------------

Additional (1): bat-jsl-1
Missing (1): fi-bsw-cyan

Known issues
------------

Here are the changes found in IGTPW_7051 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@kms_chamelium@common-hpd-after-suspend:
- fi-snb-2600: NOTRUN -> [SKIP][1] ([fdo#109271] / [fdo#111827])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7051/fi-snb-2600/igt@[email protected]

#### Possible fixes ####

* igt@i915_selftest@live@hangcheck:
- fi-snb-2600: [INCOMPLETE][2] ([i915#3921]) -> [PASS][3]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6468/fi-snb-2600/igt@i915_selftest@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7051/fi-snb-2600/igt@i915_selftest@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#5602]: https://gitlab.freedesktop.org/drm/intel/issues/5602
[i915#5917]: https://gitlab.freedesktop.org/drm/intel/issues/5917

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_6468 -> IGTPW_7051

CI-20190529: 20190529
CI_DRM_11616: 65a5fe9ac96c60bd6dfcc44a0bb8d584912ea53d @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_7051: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7051/index.html
IGT_6468: cffa5fffe9acddf49565b4caeeb5e3355ff2ea44 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7051/index.html

#3 lore raw

[igt-dev] ✓ Fi.CI.IGT: success for tests/kms_flip: Update logic to calculate test duration (rev2)

In reply to Karthik B S
== Series Details ==

== Series Details ==

Series: tests/kms_flip: Update logic to calculate test duration (rev2)
URL : https://patchwork.freedesktop.org/series/103655/
State : success

== Summary ==

CI Bug Log - changes from IGT_6468_full -> IGTPW_7051_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7051/index.html

Participating hosts (9 -> 8)
------------------------------

Missing (1): shard-rkl

Known issues
------------

Here are the changes found in IGTPW_7051_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_ctx_persistence@engines-cleanup:
- shard-snb: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#1099])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7051/shard-snb7/igt@[email protected]

* igt@gem_mmap_wc@coherency:
- shard-snb: [PASS][2] -> [SKIP][3] ([fdo#109271]) +1 similar issue
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6468/shard-snb7/igt@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7051/shard-snb6/igt@[email protected]

* igt@gem_ppgtt@blt-vs-render-ctxn:
- shard-snb: [PASS][4] -> [DMESG-FAIL][5] ([i915#3692] / [i915#4998])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6468/shard-snb4/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7051/shard-snb6/igt@[email protected]

* igt@i915_hangman@engine-engine-hang:
- shard-snb: NOTRUN -> [SKIP][6] ([fdo#109271]) +113 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7051/shard-snb5/igt@[email protected]

* igt@kms_chamelium@hdmi-hpd-enable-disable-mode:
- shard-snb: NOTRUN -> [SKIP][7] ([fdo#109271] / [fdo#111827]) +4 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7051/shard-snb2/igt@[email protected]

* igt@syncobj_timeline@transfer-timeline-point:
- shard-snb: NOTRUN -> [DMESG-FAIL][8] ([i915#5098])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7051/shard-snb5/igt@[email protected]

#### Possible fixes ####

* igt@gem_eio@in-flight-contexts-10ms:
- shard-snb: [FAIL][9] ([i915#4409]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6468/shard-snb6/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7051/shard-snb6/igt@[email protected]

* igt@i915_selftest@live@hangcheck:
- shard-snb: [INCOMPLETE][11] ([i915#3921]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6468/shard-snb4/igt@i915_selftest@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7051/shard-snb2/igt@i915_selftest@[email protected]

* igt@i915_suspend@fence-restore-tiled2untiled:
- {shard-tglu}: [DMESG-WARN][13] ([i915#5122]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6468/shard-tglu-8/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7051/shard-tglu-5/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110542]: https://bugs.freedesktop.org/show_bug.cgi?id=110542
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1063]: https://gitlab.freedesktop.org/drm/intel/issues/1063
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3319]: https://gitlab.freedesktop.org/drm/intel/issues/3319
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3376]: https://gitlab.freedesktop.org/drm/intel/issues/3376
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3692]: https://gitlab.freedesktop.org/drm/intel/issues/3692
[i915#3825]: https://gitlab.freedesktop.org/drm/intel/issues/3825
[i915#3828]: https://gitlab.freedesktop.org/drm/intel/issues/3828
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#3966]: https://gitlab.freedesktop.org/drm/intel/issues/3966
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4409]: https://gitlab.freedesktop.org/drm/intel/issues/4409
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#4998]: https://gitlab.freedesktop.org/drm/intel/issues/4998
[i915#5076]: https://gitlab.freedesktop.org/drm/intel/issues/5076
[i915#5098]: https://gitlab.freedesktop.org/drm/intel/issues/5098
[i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5182]: https://gitlab.freedesktop.org/drm/intel/issues/5182
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5287]: https://gitlab.freedesktop.org/drm/intel/issues/5287
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5614]: https://gitlab.freedesktop.org/drm/intel/issues/5614
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_6468 -> IGTPW_7051

CI-20190529: 20190529
CI_DRM_11616: 65a5fe9ac96c60bd6dfcc44a0bb8d584912ea53d @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_7051: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7051/index.html
IGT_6468: cffa5fffe9acddf49565b4caeeb5e3355ff2ea44 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7051/index.html

Reviewed-by on v1 1/1
#4 lore raw
In reply to Karthik B S

look ok to me

Quoted 45 lines · Karthik B S

Few of the subtests are intended to run only for one iteration with duration of 0. But because of the existing logic to calculate duration, even these subtests are running in loop for 0.5s. This is causing excessive logging in the nonexisting-fb subtests.

Added check to use duration calculation logic only if duration is non-zero in the first place.

---
  tests/kms_flip.c | 14 ++++++++++----
  1 file changed, 10 insertions(+), 4 deletions(-)
tests/kms_flip.c +10 -4
index ce452dc8..773e6597 100755
@@ -1537,8 +1537,11 @@ static int run_test(int duration, int flags)
  	}
 
  	igt_require(modes);
-	duration = duration * 1000 / modes;
-	duration = max(500, duration);
+
+	if (duration) {
+		duration = duration * 1000 / modes;
+		duration = max(500, duration);
+	}
 
  	/* Find any connected displays */
  	for (i = 0; i < resources->count_connectors; i++) {
@@ -1605,8 +1608,11 @@ static int run_pair(int duration, int flags)
  	/* If we have fewer than 2 connected outputs then we won't have any
  	 * configuration at all. So skip in that case. */
  	igt_require_f(modes, "At least two displays required\n");
-	duration = duration * 1000 / modes;
-	duration = max(duration, 500);
+
+	if (duration) {
+		duration = duration * 1000 / modes;
+		duration = max(duration, 500);
+	}
 
  	/* Find a pair of connected displays */
  	for (i = 0; i < resources->count_connectors; i++) {