Skip to contentSkip to conversation

kernel/crash_core.c : remove redundant check of ck_cmdline

PATCH Superseded lizhe 3 participants 3 messages May 6, 2022

Subsystems (3)

v4 of 5 Superseded Latest is v5 →

lore
Share & tools
lore

lizhe

author
#0 lore raw

PATCH v4 1/1 kernel/crash_core.c : remove redundant check of ck_cmdline

At the end of get_last_crashkernel(), the judgement of ck_cmdline is obviously unnecessary and causes redundance, let's clean it up.

---
 kernel/crash_core.c | 3 ---
 1 file changed, 3 deletions(-)
kernel/crash_core.c +0 -3
index 256cf6db573c..c232f01a2c54 100644
@@ -222,9 +222,6 @@ static __init char *get_last_crashkernel(char *cmdline,
 		p = strstr(p+1, name);
 	}
 
-	if (!ck_cmdline)
-		return NULL;
-
 	return ck_cmdline;
 }
 
Signature · 1 line
2.25.1
#1 lore raw

Add Andrew to CC list

Quoted 27 lines · lizhe

At the end of get_last_crashkernel(), the judgement of ck_cmdline is obviously unnecessary and causes redundance, let's clean it up.

---
 kernel/crash_core.c | 3 ---
 1 file changed, 3 deletions(-)
kernel/crash_core.c +0 -3
index 256cf6db573c..c232f01a2c54 100644
@@ -222,9 +222,6 @@ static __init char *get_last_crashkernel(char *cmdline,
 		p = strstr(p+1, name);
 	}
 
-	if (!ck_cmdline)
-		return NULL;
-
 	return ck_cmdline;
 }
 
Signature · 1 line
2.25.1
#2 lore raw
In reply to lizhe
Quoted 4 lines · lizhe

At the end of get_last_crashkernel(), the judgement of ck_cmdline is obviously unnecessary and causes redundance, let's clean it up.

Signed off by should be real name. Greg ask this already, but you did not ever answer [1].

[1]: https://lore.kernel.org/lkml/Yi2nfjH7aph6CuiX at kroah.com/

Quoted 20 lines
---
  kernel/crash_core.c | 3 ---
  1 file changed, 3 deletions(-)
kernel/crash_core.c +0 -3
index 256cf6db573c..c232f01a2c54 100644
@@ -222,9 +222,6 @@ static __init char *get_last_crashkernel(char *cmdline,
  		p = strstr(p+1, name);
  	}
 
-	if (!ck_cmdline)
-		return NULL;
-
  	return ck_cmdline;
  }