Skip to contentSkip to conversation

usbredir: avoid queuing hello packet on snapshot restore

PATCH In review Joelle van Dyne 2 participants 2 messages May 7, 2022 – Jun 9, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usbredir: avoid queuing hello packet on snapshot restore

When launching QEMU with "-loadvm", usbredir_create_parser() should avoid setting up the hello packet (just as with "-incoming". On the latest version of libusbredir, usbredirparser_unserialize() will return error if the parser is not "pristine."

---
 hw/usb/redirect.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
hw/usb/redirect.c +2 -1
index 3bc4dee7fe..f8bec9b292 100644
@@ -1280,7 +1280,8 @@ static void usbredir_create_parser(USBRedirDevice *dev)
     }
 #endif
 
-    if (runstate_check(RUN_STATE_INMIGRATE)) {
+    if (runstate_check(RUN_STATE_INMIGRATE) ||
+        runstate_check(RUN_STATE_PRELAUNCH)) {
         flags |= usbredirparser_fl_no_hello;
     }
     usbredirparser_init(dev->parser, VERSION, caps, USB_REDIR_CAPS_SIZE,
Signature · 1 line
2.28.0
#1 lore raw
Quoted 6 lines · Joelle van Dyne

When launching QEMU with "-loadvm", usbredir_create_parser() should avoid setting up the hello packet (just as with "-incoming". On the latest version of libusbredir, usbredirparser_unserialize() will return error if the parser is not "pristine."

Patch queued up.

thanks,
Gerd