ath11k: remove redundant assignment to variables vht_mcs and he_mcs
PATCH 1/1 ath11k: remove redundant assignment to variables vht_mcs and he_mcs
The variables vht_mcs and he_mcs are being initialized in the start of for-loops however they are re-assigned new values in the loop and not used outside the loop. The initializations are redundant and can be removed.
Cleans up clang scan warnings:
warning: Although the value stored to 'vht_mcs' is used in the enclosing expression, the value is never actually read from 'vht_mcs' [deadcode.DeadStores]
warning: Although the value stored to 'he_mcs' is used in the enclosing expression, the value is never actually read from 'he_mcs' [deadcode.DeadStores]
--- drivers/net/wireless/ath/ath11k/mac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/wireless/ath/ath11k/mac.c +2 -2
@@ -1951,7 +1951,7 @@ static void ath11k_peer_assoc_h_vht(struct ath11k *ar,/* Calculate peer NSS capability from VHT capabilities if STA * supports VHT. */ -for (i =0 , max_nss =0 , vht_mcs =0 ; i <NL80211_VHT_NSS_MAX ; i++) { +for (i =0 , max_nss =0 ; i <NL80211_VHT_NSS_MAX ; i++) { vht_mcs =__le16_to_cpu (vht_cap->vht_mcs.rx_mcs_map) >> (2 * i) &3 ;
@@ -2272,7 +2272,7 @@ static void ath11k_peer_assoc_h_he(struct ath11k *ar,/* Calculate peer NSS capability from HE capabilities if STA * supports HE. */ -for (i =0 , max_nss =0 , he_mcs =0 ; i <NL80211_HE_NSS_MAX ; i++) { +for (i =0 , max_nss =0 ; i <NL80211_HE_NSS_MAX ; i++) { he_mcs = he_tx_mcs >> (2 * i) &3 ;/* In case of fixed rates, MCS Range in he_tx_mcs might have
Signature · 1 line
2.35.1
Quoted 11 lines · Colin Ian King
The variables
vht_mcsandhe_mcsare being initialized in the start of for-loops however they are re-assigned new values in the loop and not used outside the loop. The initializations are redundant and can be removed.Cleans up clang scan warnings:
warning: Although the value stored to '
vht_mcs' is used in the enclosing expression, the value is never actually read from 'vht_mcs' [deadcode.DeadStores]
Quoted 6 lines
warning: Although the value stored to '
he_mcs' is used in the enclosing expression, the value is never actually read from 'he_mcs' [deadcode.DeadStores]Signed-off-by Colin Ian King <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
25c321e8534e ath11k: remove redundant assignment to variables vht_mcs and he_mcs
Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches