Skip to contentSkip to conversation

xr819-xradio: fixes for autobuild failures

PATCH In review Sergey Matyukevich 2 participants 6 messages May 7, 2022 – May 13, 2022

lore
Share & tools
lore
#0 lore raw

cover xr819-xradio: fixes for autobuild failures

Hi all,

Here are several changes aimed at fixing recent xr819-xradio autobuild failures.

Regards,
Sergey

Sergey Matyukevich (3):
package/xr819-xradio: bump version package/xr819-xradio: enable required kernel options package/xr819-xradio: enable for ARM only

 package/xr819-xradio/Config.in         |  1 +
 package/xr819-xradio/xr819-xradio.hash |  2 +-
 package/xr819-xradio/xr819-xradio.mk   | 10 +++++++++-
 3 files changed, 11 insertions(+), 2 deletions(-)
Signature · 6 lines
2.35.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

PATCH 1/3 package/xr819-xradio: bump version

Pull the latest xradio change that allows build testing on other platforms than ARM.

Fixes:
- http://autobuild.buildroot.net/results/7ad4a4b6b1612460427e667d98efc6df7b4a2153

---
 package/xr819-xradio/xr819-xradio.hash | 2 +-
 package/xr819-xradio/xr819-xradio.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
package/xr819-xradio/xr819-xradio.hash +1 -1
index 4a77db0d1a..89201a8eb7 100644
@@ -1,4 +1,4 @@
 # Locally computed
-sha256  06b91b1fcf98a261125b4d599ffcce2458fb9d0c1f38a4bd432a622b446f0f51  xr819-xradio-16180b6308e3c5dc42a92a663adf669028087ff7.tar.gz
+sha256  0d0449a85488b990d10ecdf67ac88bfbd39fa81c2df5dfcfed583975222afd33  xr819-xradio-4f0cfd5e869ca101e7c624d9ce05ba5d2b2a0bc2.tar.gz
 # Locally computed
 sha256  db296f2f7f35bca3a174efb0eb392b3b17bd94b341851429a3dff411b1c2fc73  LICENSE
package/xr819-xradio/xr819-xradio.mk +1 -1
index 5f60be887c..d4b9826f64 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-XR819_XRADIO_VERSION = 16180b6308e3c5dc42a92a663adf669028087ff7
+XR819_XRADIO_VERSION = 4f0cfd5e869ca101e7c624d9ce05ba5d2b2a0bc2
 XR819_XRADIO_SITE = $(call github,fifteenhex,xradio,$(XR819_XRADIO_VERSION))
 XR819_XRADIO_LICENSE = GPL-2.0
 XR819_XRADIO_LICENSE_FILES = LICENSE
Signature · 6 lines
2.35.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw

PATCH 2/3 package/xr819-xradio: enable required kernel options

In reply to Sergey Matyukevich

Enable Linux kernel configuration options required by xradio driver. Those are wireless networking support, sdio support, and power management core functions.

Fixes:
- http://autobuild.buildroot.net/results/7ad4a4b6b1612460427e667d98efc6df7b4a2153/

---
 package/xr819-xradio/xr819-xradio.mk | 8 ++++++++
 1 file changed, 8 insertions(+)
package/xr819-xradio/xr819-xradio.mk +8 -0
index d4b9826f64..835e229347 100644
@@ -9,5 +9,13 @@ XR819_XRADIO_SITE = $(call github,fifteenhex,xradio,$(XR819_XRADIO_VERSION))
 XR819_XRADIO_LICENSE = GPL-2.0
 XR819_XRADIO_LICENSE_FILES = LICENSE
 
+define XR819_XRADIO_LINUX_CONFIG_FIXUPS
+	$(call KCONFIG_ENABLE_OPT,CONFIG_WIRELESS)
+	$(call KCONFIG_ENABLE_OPT,CONFIG_CFG80211)
+	$(call KCONFIG_ENABLE_OPT,CONFIG_MAC80211)
+	$(call KCONFIG_ENABLE_OPT,CONFIG_MMC)
+	$(call KCONFIG_ENABLE_OPT,CONFIG_PM)
+endef
+
 $(eval $(kernel-module))
 $(eval $(generic-package))
Signature · 6 lines
2.35.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#3 lore raw

Re: [Buildroot] [PATCH 2/3] package/xr819-xradio: enable required kernel options

Quoted 17 lines · Sergey Matyukevich

Enable Linux kernel configuration options required by xradio driver. Those are wireless networking support, sdio support, and power management core functions.

Fixes:
- http://autobuild.buildroot.net/results/7ad4a4b6b1612460427e667d98efc6df7b4a2153/

---
  package/xr819-xradio/xr819-xradio.mk | 8 ++++++++
  1 file changed, 8 insertions(+)
package/xr819-xradio/xr819-xradio.mk +0 -0
index d4b9826f64..835e229347 100644

package/xr819-xradio/xr819-xradio.mk XR819_XRADIO_SITE = $(call github,fifteenhex,xradio,$(XR819_XRADIO_VERSION)) · line 17

Quoted 9 lines
package/xr819-xradio/xr819-xradio.mk +6 -0
@@ -9,5 +9,13 @@ XR819_XRADIO_SITE = $(call github,fifteenhex,xradio,$(XR819_XRADIO_VERSION))
  XR819_XRADIO_LICENSE = GPL-2.0
  XR819_XRADIO_LICENSE_FILES = LICENSE
 
+define XR819_XRADIO_LINUX_CONFIG_FIXUPS
+	$(call KCONFIG_ENABLE_OPT,CONFIG_WIRELESS)
+	$(call KCONFIG_ENABLE_OPT,CONFIG_CFG80211)
+	$(call KCONFIG_ENABLE_OPT,CONFIG_MAC80211)
+	$(call KCONFIG_ENABLE_OPT,CONFIG_MMC)
+	$(call KCONFIG_ENABLE_OPT,CONFIG_PM)

I've applied to master. However, these options have dependencies that need to
be checked as well. E.g. WIRELESS depends on NET (which is usually enabled, but you can't count on it). But it also depends on !S390 - in other words, you simply can't build this package for s390x, so that dependency has to be added to Config.in.

Could you check this stuff and update the options?

Regards,
Arnout

package/xr819-xradio/xr819-xradio.mk XR819_XRADIO_SITE = $(call github,fifteenhex,xradio,$(XR819_XRADIO_VERSION)) · line 21

Quoted 4 lines
package/xr819-xradio/xr819-xradio.mk +2 -0
+endef
+
  $(eval $(kernel-module))
  $(eval $(generic-package))

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#4 lore raw

PATCH 3/3 package/xr819-xradio: enable for ARM only

In reply to Sergey Matyukevich

The xradio driver is broken for kernel configurations with disabled power management core functionality (CONFIG_PM). The xradio package makefile attempts to enable all the required kernel configuration options, including CONFIG_PM. However certain architectures have no support for CONFIG_PM. Those are or1k, nios2, csky, and more.

One possible fix would be to exclude those architectures in the package Config.in. On the other hand, the xradio driver is rarely
used: orangepi_zero is the only such board in Buildroot. So it makes sense to keep it simple and enable xradio only for ARM. Any new xradio users will be considered on a case by case basis.

Fixes:
- http://autobuild.buildroot.net/results/2ad11cd7a9ca6b694854730e46260a944e8c4bac/

---
 package/xr819-xradio/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/xr819-xradio/Config.in +1 -0
index 9d7fa4b0f1..351ea95c79 100644
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_XR819_XRADIO
 	bool "xr819-xradio"
 	depends on BR2_LINUX_KERNEL
+	depends on BR2_arm
 	help
 	  Wireless driver for SDIO WiFi chip XR819
 
Signature · 6 lines
2.35.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#5 lore raw

Re: [Buildroot] [PATCH 3/3] package/xr819-xradio: enable for ARM only

Quoted 12 lines · Sergey Matyukevich

The xradio driver is broken for kernel configurations with disabled power management core functionality (CONFIG_PM). The xradio package makefile attempts to enable all the required kernel configuration options, including CONFIG_PM. However certain architectures have no support for CONFIG_PM. Those are or1k, nios2, csky, and more.

One possible fix would be to exclude those architectures in the package Config.in. On the other hand, the xradio driver is rarely
used: orangepi_zero is the only such board in Buildroot. So it makes sense to keep it simple and enable xradio only for ARM. Any new xradio users will be considered on a case by case basis.

Quoted 4 lines

Fixes:
- http://autobuild.buildroot.net/results/2ad11cd7a9ca6b694854730e46260a944e8c4bac/

I've applied this one as well, so forget my remark in the previous patch about
s390 :-)

package/xr819-xradio/Config.in line 4

Quoted 13 lines
---
  package/xr819-xradio/Config.in | 1 +
  1 file changed, 1 insertion(+)
package/xr819-xradio/Config.in +1 -0
index 9d7fa4b0f1..351ea95c79 100644
@@ -1,6 +1,7 @@
  config BR2_PACKAGE_XR819_XRADIO
  	bool "xr819-xradio"
  	depends on BR2_LINUX_KERNEL
+	depends on BR2_arm

aarch64 is likely as well, and why not add the BE variants too... So I added
those and applied to master, thanks.

Regards,
Arnout

package/xr819-xradio/Config.in line 7

Quoted 3 lines
package/xr819-xradio/Config.in +0 -0
  	help
  	  Wireless driver for SDIO WiFi chip XR819
 

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot