mm/shmem: restore setting of page variable
Subsystems (2)
PATCH 1/1 mm/shmem: restore setting of page variable
The clang build fails withmm/shmem.c:2337:8: error: variable 'page' is uninitialized when used here [-Werror,-Wuninitialized]
if (!page)
^~~~
In the commit listed in the fixes, there was a change to the from
page = shmem_alloc_page(..);
to
page = &shmem_alloc_folio(..)->page;
But in this case, instead of replacing, the setting of page was deleted. So restore page with its new api.
--- mm/shmem.c | 1 + 1 file changed, 1 insertion(+)
mm/shmem.c +1 -0
@@ -2334,6 +2334,7 @@ int shmem_mfill_atomic_pte(struct mm_struct *dst_mm,if (!*pagep) { ret = -ENOMEM ; + page = &shmem_alloc_folio (gfp, info, pgoff)->page;if (!page) goto out_unacct_blocks;
Signature · 1 line
2.27.0
Andrew Morton
maintainerQuoted 18 lines · On Mon, 9 May 2022 08:32:32 -0400 Tom Rix <[email protected]> wrote:
The clang build fails with
mm/shmem.c:2337:8: error: variable 'page' is uninitialized when used here [-Werror,-Wuninitialized]
if (!page)^~~~In the commit listed in the fixes, there was a change to the from
page =shmem_alloc_page(..);
to
page = &shmem_alloc_folio(..)->page;
But in this case, instead of replacing, the setting of page was deleted. So restore page with its new api....
mm/shmem.c int shmem_mfill_atomic_pte(struct mm_struct *dst_mm, · line 2340
Quoted 7 lines
mm/shmem.c +1
-0@@ -2334,6 +2334,7 @@ int shmem_mfill_atomic_pte(struct mm_struct *dst_mm,if (!*pagep) { ret = -ENOMEM ; + page = &shmem_alloc_folio (gfp, info, pgoff)->page;if (!page) goto out_unacct_blocks;
Thanks, this is fixed in v2 of Matthew's "Folio patches for 5.19" series.
I've just now pushed all that out to kernel.org so next linux-next should be a happier place.